| Subject: | [Patch] Fix test warnings about pack 'c' |
pack 'c' is for use with integers between -127 and +128, so the for loop generating 0 to 255 is just wrong.
You want "C" for that.
This is commented on in reviews, but nobody bothered to file a bug.
https://cpanratings.perl.org/dist/Data-HexDump
Its only been 18 or so years, no rush.
--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )
| Subject: | 0003-Don-t-use-signed-characters-for-0-255.patch |
From 42a5cc8219326af6d3475bace436f9d71032c23d Mon Sep 17 00:00:00 2001
From: Kent Fredric <kentnl@gentoo.org>
Date: Tue, 10 Oct 2017 08:17:59 +1300
Subject: Don't use signed characters for 0-255
'c' == -127 to 127
---
t/compare.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/compare.t b/t/compare.t
index f03d73d..3c25803 100644
--- a/t/compare.t
+++ b/t/compare.t
@@ -11,7 +11,7 @@ print "1..2\n";
# data
my $org = "";
for (my $i = 0; $i <= 255; $i++) {
- $org .= pack 'c', $i;
+ $org .= pack 'C', $i;
}
$org = $org x 17 . "more data";
--
2.14.1