Bug #12300 for DBIx-DBSchema: mysql enum column type

Fri Apr 15 09:07:37 2005 aorr [...] cpan.org - Ticket created

Subject:

mysql enum column type

Using the mysql driver, "enum" column types are not recognized and the module dies. A patch is included for the fix. Also, would also be nice if the module did not die on an unknown column type. My environment: Linux 2.4.18-3bigmem #1 SMP perl, v5.8.6 built for i686-linux DBIx::DBSchema::VERSION: 0.26 mysql Ver 14.7 Distrib 4.1.7, for pc-linux (i686) Regards, Andy Orr

--- mysql.pm.orig Thu Apr 14 17:18:38 2005 +++ mysql.pm Thu Apr 14 17:27:06 2005 @@ -38,5 +38,5 @@ $sth->execute or die $sth->errstr; map { - $_->{'Type'} =~ /^(\w+)$?([\d\,]+)?$?( unsigned)?$/ + $_->{'Type'} =~ /^(\w+)$?(['"\w\d\,]+)?$?( unsigned)?$/ or die "Illegal type: ". $_->{'Type'}. "\n"; my($type, $length) = ($1, $2);

Fri Apr 15 09:09:01 2005 ivan-pause [...] 420.am - Status changed from 'new' to 'open'

Fri Apr 15 09:18:29 2005 ivan-pause [...] 420.am - Correspondence added

[AORR - Fri Apr 15 09:07:37 2005]: Show quoted text

> Using the mysql driver, "enum" column types are not recognized and > the module dies. A patch is included for the fix.

Thanks for the patch! Applied to CVS; if you could test it out and let me know if it works for you that would be great. I tried to make the regex a little more permissable than yours; as far as I know enum types aren't limited to \w\d. You can download a snapshot at http://www.sisd.com/cgi-bin/viewcvs.cgi/DBIx-DBSchema/DBIx-DBSchema.tar.gz?tarball=1 Show quoted text

> Also, would also be nice if the module did not die on an unknown > column type.

What behaviour would you prefer?

Fri Apr 15 10:14:10 2005 aorr [...] cpan.org - Correspondence added

From:

AORR

[IVAN - Fri Apr 15 09:18:29 2005]: Show quoted text

> [AORR - Fri Apr 15 09:07:37 2005]: >

> > Using the mysql driver, "enum" column types are not recognized and > > the module dies. A patch is included for the fix.

> > Thanks for the patch! Applied to CVS; if you could test it out and > let me know if it works for you that would be great. I tried to make > the regex a little more permissable than yours; as far as I know enum > types aren't limited to \w\d. You can download a snapshot at > http://www.sisd.com/cgi-bin/viewcvs.cgi/DBIx-DBSchema/DBIx- > DBSchema.tar.gz?tarball=1

Thanks so much for the download! Show quoted text

> > Also, would also be nice if the module did not die on an unknown > > column type.

> > What behaviour would you prefer?

I'm using your module for a web based Mysql interface and it's been working great! When a table had a column with an enum type none of the columns were displayed. Never thought much of it, but after looking at the mysql driver, looked like an easy enough fix. I suppose "warn" would be better than "die" for an unknown column type? Thanks! Andy

Sat Apr 16 19:06:02 2005 ivan-pause [...] 420.am - Correspondence added

[AORR - Fri Apr 15 10:14:10 2005]: Show quoted text

> [IVAN - Fri Apr 15 09:18:29 2005]:

> > [AORR - Fri Apr 15 09:07:37 2005]:

> > > > > > Also, would also be nice if the module did not die on an unknown > > > column type.

> > > > What behaviour would you prefer?

> > I'm using your module for a web based Mysql interface and it's been > working great! When a table had a column with an enum type none of > the columns were displayed. Never thought much of it, but after > looking at the mysql driver, looked like an easy enough fix. I > suppose "warn" would be better than "die" for an unknown column > type?

The problem is not an "unknown" column type - the problem is an _unparsable_ column type. The module handles unknown column types fine. I'm sorry, but in this context I don't think it would be useful to just warn and continue. The error is thrown because the column couldn't be parsed; it seems vastly less useful to "warn" and return bogus information than to throw an exception.

Wed Sep 21 13:05:24 2005 Guest - Correspondence added

From:

Bernhard.Schmalhofer [...] biomax.de

It looks like I have run into the same issue. I get a table without columns when I have something like CREATE TABLE `dummy_8` ( `state` enum('SUBMITTED','NOT_SUBMITTED') default 'NOT_SUBMITTED' ) in my schema.

Tue Aug 14 19:05:50 2007 ivan-pause [...] 420.am - Fixed in 0.27 added

Tue Aug 14 19:05:50 2007 ivan-pause [...] 420.am - Fixed in 0.28 added

Tue Aug 14 19:05:51 2007 ivan-pause [...] 420.am - Fixed in 0.29 added

Tue Aug 14 19:05:51 2007 ivan-pause [...] 420.am - Fixed in 0.30 added

Tue Aug 14 19:05:51 2007 ivan-pause [...] 420.am - Fixed in 0.31 added

Tue Aug 14 19:05:51 2007 ivan-pause [...] 420.am - Fixed in 0.32 added

Tue Aug 14 19:05:51 2007 ivan-pause [...] 420.am - Fixed in 0.33 added

Tue Aug 14 19:06:01 2007 ivan-pause [...] 420.am - Correspondence added

this was fixed in 0.27

Tue Aug 14 19:06:03 2007 ivan-pause [...] 420.am - Status changed from 'open' to 'resolved'