Bug #122990 for RT-Extension-HistoryFilter: The version of Widget/Form/Select is broken with RT 4.4.x

Fri Sep 08 11:48:24 2017 ktm [...] rice.edu - Ticket created

Subject:	The version of Widget/Form/Select is broken with RT 4.4.x
Date:	Fri, 8 Sep 2017 10:40:11 -0500
To:	bug-RT-Extension-HistoryFilter [...] rt.cpan.org
From:	Kenneth Marshall <ktm [...] rice.edu>

Hi, The Widget/Form/Select file distributed with version 2.01 is broken with regards to the refresh interval tags. Here is a diff between the 2 versions: diff -u src/RT-Extension-HistoryFilter-2.01/html/Widgets/Form/Select src/rt-4.4.2/share/html/Widgets/Form/Select --- src/RT-Extension-HistoryFilter-2.01/html/Widgets/Form/Select 2014-08-26 04:03:21.000000000 -0500 +++ src/rt-4.4.2/share/html/Widgets/Form/Select 2017-07-12 09:23:39.000000000 -0500 @@ -2,7 +2,7 @@ %# %# COPYRIGHT: %# -%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC +%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC %# <sales@bestpractical.com> %# %# (Except where explicitly superseded by other copyright notices) @@ -91,7 +91,7 @@ % foreach my $v( @Values ) { % my $selected = ''; % $selected = 'selected="selected"' if delete $CurrentValue{ $v }; -<option value="<% $v %>" <% $selected |n %>><% loc($ValuesLabel{ $v } || $v) %></option> +<option value="<% $v %>" <% $selected |n %>><% loc(ref($ValuesLabel{ $v }) ? @{ $ValuesLabel{ $v } } : $ValuesLabel{ $v } || $v) %></option> % } % if ( $Alternative ) { @@ -120,7 +120,7 @@ } unless (defined $DefaultLabel ) { $DefaultLabel = loc('Use system default ([_1])', - join ', ', map loc($ValuesLabel{$_} || $_), grep defined, + join ', ', map loc(ref($ValuesLabel{$_}) ? @{ $ValuesLabel{$_ }} : $ValuesLabel{$_} || $_), grep defined, @DefaultValue ); } Regards, Ken

Mon Feb 05 06:19:39 2018 CLOOS [...] cpan.org - Taken

Mon Feb 05 06:19:58 2018 CLOOS [...] cpan.org - Status changed from 'new' to 'open'

Mon Feb 05 11:49:08 2018 CLOOS [...] cpan.org - Status changed from 'open' to 'patched'

Mon Feb 05 11:58:29 2018 CLOOS [...] cpan.org - Correspondence added

Hi Ken, I couldn't see any problems with the refresh interval widget, but anyway I updated the distributed widget with the version from RT 4.4.2. This is fixed in 2.02, which will be available on CPAN shortly. Regards Chris Am Fr 08. Sep 2017, 11:48:24, ktm@rice.edu schrieb: Show quoted text

> Hi, > > The Widget/Form/Select file distributed with version 2.01 is broken > with regards to the refresh interval tags. Here is a diff between > the 2 versions: > > diff -u src/RT-Extension-HistoryFilter-2.01/html/Widgets/Form/Select > src/rt-4.4.2/share/html/Widgets/Form/Select > --- src/RT-Extension-HistoryFilter-2.01/html/Widgets/Form/Select > 2014-08-26 04:03:21.000000000 -0500 > +++ src/rt-4.4.2/share/html/Widgets/Form/Select 2017-07-12 > 09:23:39.000000000 -0500 > @@ -2,7 +2,7 @@ > %# > %# COPYRIGHT: > %# > -%# This software is Copyright (c) 1996-2014 Best Practical Solutions, > LLC > +%# This software is Copyright (c) 1996-2017 Best Practical Solutions, > LLC > %# <sales@bestpractical.com> > %# > %# (Except where explicitly superseded by other copyright notices) > @@ -91,7 +91,7 @@ > % foreach my $v( @Values ) { > % my $selected = ''; > % $selected = 'selected="selected"' if delete $CurrentValue{ $v }; > -<option value="<% $v %>" <% $selected |n %>><% loc($ValuesLabel{ $v } > || $v) %></option> > +<option value="<% $v %>" <% $selected |n %>><% loc(ref($ValuesLabel{ > $v }) ? @{ $ValuesLabel{ $v } } : $ValuesLabel{ $v } || $v) > %></option> > % } > > % if ( $Alternative ) { > @@ -120,7 +120,7 @@ > } > unless (defined $DefaultLabel ) { > $DefaultLabel = loc('Use system default ([_1])', > - join ', ', map loc($ValuesLabel{$_} || $_), grep defined, > + join ', ', map loc(ref($ValuesLabel{$_}) ? @{ $ValuesLabel{$_ > }} : $ValuesLabel{$_} || $_), grep defined, > @DefaultValue > ); > } > > Regards, > Ken

Mon Feb 05 11:58:30 2018 CLOOS [...] cpan.org - Status changed from 'patched' to 'resolved'

Sun Feb 11 08:04:47 2018 CLOOS [...] cpan.org - Fixed in 2.02 added