Bug #122984 for Dist-Zilla-Plugin-Test-Compile: Generated META miss blib dependecny despite it is used in t/00-compile.t

Thu Sep 07 09:36:45 2017 ppisar [...] redhat.com - Ticket created

Subject:

Generated META miss blib dependecny despite it is used in t/00-compile.t

Dist-Zilla-Role-PluginBundle-PluginRemover-0.105 was released with a new Dist-Zilla-Plugin-Test-Compile and as a result it's META files are missing dependency on blib module despite it's used in t/00-compile.t on line 42 (the @switches variable defined on line 22). See CPAN RT#122981. Dist-Zilla-Role-PluginBundle-PluginRemover's author concluded: This appears to be the most recent change in the module that generates this file: https://github.com/karenetheridge/Dist-Zilla-Plugin-Test-Compile/commit/5817fa6853c40034953d3969a73f8aba7cdd06c0

Thu Sep 07 14:52:42 2017 ether [...] cpan.org - Correspondence added

On 2017-09-07 06:36:45, ppisar wrote: Show quoted text

> Dist-Zilla-Role-PluginBundle-PluginRemover-0.105 was released with a > new Dist-Zilla-Plugin-Test-Compile and as a result it's META files are > missing dependency on blib module despite it's used in t/00-compile.t > on line 42 (the @switches variable defined on line 22). See CPAN > RT#122981. > > https://github.com/karenetheridge/Dist-Zilla-Plugin-Test-Compile/commit/5817fa6853c40034953d3969a73f8aba7cdd06c0

blib version 1.07 is used conditionally, and is not required. The removal of this prereq entry was intentional, as the commit message clearly explains.

Thu Sep 07 14:52:43 2017 The RT System itself - Status changed from 'new' to 'open'

Thu Sep 07 14:52:43 2017 ether [...] cpan.org - Status changed from 'open' to 'rejected'

Fri Sep 08 02:51:47 2017 ppisar [...] redhat.com - Correspondence added

Subject:	Re: [rt.cpan.org #122984] Generated META miss blib dependecny despite it is used in t/00-compile.t
Date:	Fri, 8 Sep 2017 08:51:23 +0200
To:	Karen Etheridge via RT <bug-Dist-Zilla-Plugin-Test-Compile [...] rt.cpan.org>
From:	Petr Pisar <ppisar [...] redhat.com>

On Thu, Sep 07, 2017 at 02:52:43PM -0400, Karen Etheridge via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122984 > > > On 2017-09-07 06:36:45, ppisar wrote:

> > Dist-Zilla-Role-PluginBundle-PluginRemover-0.105 was released with a > > new Dist-Zilla-Plugin-Test-Compile and as a result it's META files are > > missing dependency on blib module despite it's used in t/00-compile.t > > on line 42 (the @switches variable defined on line 22). See CPAN > > RT#122981. > > > > https://github.com/karenetheridge/Dist-Zilla-Plugin-Test-Compile/commit/5817fa6853c40034953d3969a73f8aba7cdd06c0

> > blib version 1.07 is used conditionally, and is not required. The removal > of this prereq entry was intentional, as the commit message clearly > explains. >

I worry it's always used (at least on Perl 5.26.0). Take the Dist-Zilla-Role-PluginBundle-PluginRemover-0.105, replace the '-Mblib' with nonexisting module, eg. '-MXXXblib' at t/00-compile.t:23 and run the test. It simply fails: $ perl -Ilib t/00-compile.t 1..1 not ok 1 - Dist/Zilla/Role/PluginBundle/PluginRemover.pm loaded ok # Failed test 'Dist/Zilla/Role/PluginBundle/PluginRemover.pm loaded ok' # at t/00-compile.t line 46. # got: '512' # expected: '0' Can't locate XXXblib.pm in @INC (you may need to install the XXXblib module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5). BEGIN failed--compilation aborted. # Looks like you failed 1 test of 1. The referred patch touches the eval code but forgets the blib module has already been used in the open3() command few line above. -- Petr

Download signature.asc
application/pgp-signature 228b

Message body not shown because it is not plain text.

Fri Sep 08 12:06:28 2017 ether [...] cpan.org - Correspondence added

On 2017-09-07 23:51:47, ppisar wrote: Show quoted text

> The referred patch touches the eval code but forgets the blib module > has > already been used in the open3() command few line above.

I didn't forget. blib has been in core since version 5.004, which is well before any of the other requirements of the test. The eval { require .. } is only useful for the specific version of blib that was added later (and even that was added a long long time ago, as that git commit message says).