Skip Menu |

This queue is for tickets about the Graphics-TIFF CPAN distribution.

Report information
The Basics
Id: 122933
Status: open
Priority: 0/
Queue: Graphics-TIFF

People
Owner: jffry [...] posteo.net
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 6
Fixed in: (no value)



Subject: t/1.t test crashes with ImageMagick 7.0.6.9
After upgrading ImageMagick from 6.9.9.3 to 7.0.6.9 I experience this crash in t/1.t test: $ perl -Iblib/{lib,arch} t/1.t 1..43 ok 1 - use Graphics::TIFF; ok 2 - version string ok 3 - version ok 4 - IsCODECConfigured ok 5 - FileName ok 6 - An object of class 'Graphics::TIFF' isa 'Graphics::TIFF' ok 7 - Graphics::TIFF->can(...) ok 8 - ReadDirectory perl: MagickCore/exception.c:1034: ThrowMagickExceptionList: Assertion `exception->signature == MagickCoreSignature' failed. Aborted (core dumped) It crashes in ReadEXIFDirectory() method call: SKIP: { skip 'Image::Magick not installed', 36 if $@; my $image = Image::Magick->new; $image->Read('rose:'); $image->Set( density => '72x72' ); $image->Write('test.tif'); my $tif = Graphics::TIFF->Open( 'test.tif', 'r' ); is( $tif->FileName, 'test.tif', 'FileName' ); isa_ok $tif, 'Graphics::TIFF'; can_ok $tif, qw(Close ReadDirectory GetField); is( $tif->ReadDirectory, 0, 'ReadDirectory' ); → is( $tif->ReadEXIFDirectory(0), 0, 'ReadEXIFDirectory' ); [...] } The assert comes from ImageMagick's Perl binding, but the ReadEXIFDirectory() method is a binding to LibTFF's TIFFReadEXIFDirectory() function. I have libtiff-4.0.8. I'm not sure where the problem is.
Subject: Re: [rt.cpan.org #122933] t/1.t test crashes with ImageMagick 7.0.6.9
Date: Thu, 19 Oct 2017 21:47:06 +0200
To: bug-Graphics-TIFF [...] rt.cpan.org
From: Jeff <jffry [...] posteo.net>
Subject: Re: [rt.cpan.org #122933] t/1.t test crashes with ImageMagick 7.0.6.9
To: bug-Graphics-TIFF [...] rt.cpan.org
From: Jeff <jffry [...] posteo.net>
Sorry for the delay. On 31/08/17 15:27, Petr Pisar via RT wrote: Show quoted text
> After upgrading ImageMagick from 6.9.9.3 to 7.0.6.9 I experience this crash in t/1.t test:
Show quoted text
> ok 8 - ReadDirectory > perl: MagickCore/exception.c:1034: ThrowMagickExceptionList: Assertion `exception->signature == MagickCoreSignature' failed. > Aborted (core dumped) > > It crashes in ReadEXIFDirectory() method call:
Show quoted text
> → is( $tif->ReadEXIFDirectory(0), 0, 'ReadEXIFDirectory' );
Show quoted text
> The assert comes from ImageMagick's Perl binding, but the ReadEXIFDirectory() method is a binding to LibTFF's TIFFReadEXIFDirectory() function. I have libtiff-4.0.8. > > I'm not sure where the problem is.
IM v7 hasn't made it to my development machines yet. I'll look at this when it does. Alternatively - if you could provide me with the smallest possible test.tif that reproduces the problem - e.g. density 1x1, then I can build it into the tests as uu or base64 encoded and then try to fix the bug.
Download signature.asc
application/pgp-signature 833b

Message body not shown because it is not plain text.

Subject: Re: [rt.cpan.org #122933] t/1.t test crashes with ImageMagick 7.0.6.9
Date: Thu, 2 Nov 2017 14:56:31 +0100
To: Jeffrey Ratcliffe via RT <bug-Graphics-TIFF [...] rt.cpan.org>
From: Petr Pisar <ppisar [...] redhat.com>
On Thu, Oct 19, 2017 at 03:47:41PM -0400, Jeffrey Ratcliffe via RT wrote: Show quoted text
> IM v7 hasn't made it to my development machines yet. > > I'll look at this when it does. Alternatively - if you could provide me > with the smallest possible test.tif that reproduces the problem - e.g. > density 1x1, then I can build it into the tests as uu or base64 encoded > and then try to fix the bug. >
No hurry. The IM v7 upgrade was reverted to v6 in Fedora 28 because of many regressions in depending packages. Thus I have not available it now and I cannot provide you the image. -- Petr
Download signature.asc
application/pgp-signature 228b

Message body not shown because it is not plain text.

Le Jeu 02 Nov 2017 09:55:57, ppisar a écrit : Show quoted text
> No hurry. The IM v7 upgrade was reverted to v6 in Fedora 28 because of many > regressions in depending packages. Thus I have not available it now and
That's still an issue in other distributions, eg: in Mageia Linux. It fails with: +perl5.32.0: MagickCore/exception.c:1118: ThrowMagickExceptionList: Assertion `exception->signature == MagickCoreSignature' failed.
Le Mer 11 Nov 2020 10:17:36, TVIGNAUD a écrit : Show quoted text
> That's still an issue in other distributions, eg: in Mageia Linux. > It fails with: > +perl5.32.0: MagickCore/exception.c:1118: ThrowMagickExceptionList: > Assertion `exception->signature == MagickCoreSignature' failed.
Commenting those 2 tests makes the testsuite to "pass"
Subject: test-workaround.patch
diff -up ./t/1.t.tv ./t/1.t --- ./t/1.t.tv 2020-10-27 14:25:36.000000000 +0100 +++ ./t/1.t 2020-11-11 16:22:34.597748735 +0100 @@ -1,7 +1,7 @@ use warnings; use strict; use Graphics::TIFF ':all'; -use Test::More tests => 49; +use Test::More tests => 47; use Test::Deep; BEGIN { use_ok('Graphics::TIFF') } @@ -36,7 +36,7 @@ SKIP: { is( $tif->ReadDirectory, 0, 'ReadDirectory' ); - is( $tif->ReadEXIFDirectory(0), 0, 'ReadEXIFDirectory' ); + #is( $tif->ReadEXIFDirectory(0), 0, 'ReadEXIFDirectory' ); is( $tif->NumberOfDirectories, 1, 'NumberOfDirectories' ); @@ -108,7 +108,7 @@ SKIP: { is( length( $tif->ReadRawStrip( 1, 20 ) ), 20, 'ReadRawStrip' ); - is( $tif->ReadTile( 0, 0, 0, 0 ), undef, 'ReadTile' ); + #is( $tif->ReadTile( 0, 0, 0, 0 ), undef, 'ReadTile' ); my $filename = 'out.txt'; open my $fh, '>', $filename;
Le Mer 11 Nov 2020 10:24:14, TVIGNAUD a écrit : Show quoted text
> Le Mer 11 Nov 2020 10:17:36, TVIGNAUD a écrit :
> > That's still an issue in other distributions, eg: in Mageia Linux. > > It fails with: > > +perl5.32.0: MagickCore/exception.c:1118: ThrowMagickExceptionList: > > Assertion `exception->signature == MagickCoreSignature' failed.
> > Commenting those 2 tests makes the testsuite to "pass"
It happens on several CPAN testers. See http://matrix.cpantesters.org/?dist=Graphics-TIFF+7 http://www.cpantesters.org/cpan/report/feab8c94-18e3-11eb-88b6-7b6c1f24ea8f http://www.cpantesters.org/cpan/report/563d974c-1897-11eb-879d-f0621f24ea8f http://www.cpantesters.org/cpan/report/5e6638f2-1897-11eb-879d-f0621f24ea8f http://www.cpantesters.org/cpan/report/4b58a8bc-1897-11eb-879d-f0621f24ea8f http://www.cpantesters.org/cpan/report/405d1588-1897-11eb-879d-f0621f24ea8f (…)
What happens if you create the image as per the test with ImageMagick, then deinstall ImageMagick, comment out the part of the test that creates the file, and run the test?