Bug #122927 for Moo: Upgraded Moo class should possibly report itself as immutable

Wed Aug 30 05:22:44 2017 CHESNOKOV [...] cpan.org - Ticket created

Subject:

Moo should possibly report itself as immutable

...and it doesn't. Example: perl -E 'package My::Moo::Class { use Moo; } package My::Moose::Class { use Moose; __PACKAGE__->meta->make_immutable; } say $_->meta->is_immutable for My::Moo::Class, My::Moose::Class;' 0 1

Wed Aug 30 05:35:12 2017 CHESNOKOV [...] cpan.org - Subject changed from 'Moo should possibly report itself as immutable' to 'Upgraded Moo classes should possibly report themselves as immutable'

Wed Aug 30 05:35:32 2017 CHESNOKOV [...] cpan.org - Subject changed from 'Upgraded Moo classes should possibly report themselves as immutable' to 'Upgraded Moo class should possibly report itself as immutable'

Wed Aug 30 13:11:19 2017 karen [...] froods.org - Correspondence added

Subject:	Re: [rt.cpan.org #122927] Moo should possibly report itself as immutable
Date:	Wed, 30 Aug 2017 10:10:58 -0700
To:	bug-Moo [...] rt.cpan.org
From:	Karen Etheridge <karen [...] froods.org>

It's not immutable though. You can call a meta function (e.g. from Moose::Meta::Class) that inflates the fake metaclass to a real Moose one, and then makes the requested modifications, without having to say ->make_mutable first. On Wed, Aug 30, 2017 at 2:22 AM, Илья Чесноков via RT <bug-Moo@rt.cpan.org> wrote: Show quoted text

> Wed Aug 30 05:22:44 2017: Request 122927 was acted upon. > Transaction: Ticket created by CHESNOKOV > Queue: Moo > Subject: Moo should possibly report itself as immutable > Broken in: 2.003002 > Severity: Normal > Owner: Nobody > Requestors: CHESNOKOV@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=122927 > > > > ...and it doesn't. > > Example: > > perl -E 'package My::Moo::Class { use Moo; } package My::Moose::Class { > use Moose; __PACKAGE__->meta->make_immutable; } say > $_->meta->is_immutable for My::Moo::Class, My::Moose::Class;' > 0 > 1 >

Wed Aug 30 13:11:21 2017 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 01 07:27:53 2017 CHESNOKOV [...] cpan.org - Correspondence added

On Wed Aug 30 13:11:19 2017, karen@froods.org wrote: Show quoted text

> It's not immutable though. You can call a meta function (e.g. from > Moose::Meta::Class) that inflates the fake metaclass to a real Moose one, > and then makes the requested modifications, without having to say > ->make_mutable first.

That sounds a bit strange because the documentation says: Show quoted text

>make_immutable itself is a no-op, since we generate metaclasses that are already immutable, and users converting from Moose had an unfortunate tendency to accidentally load Moose by calling it.