Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Data-Dumper CPAN distribution.

Report information
The Basics
Id: 12282
Status: open
Priority: 0/
Queue: Data-Dumper

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc: DBOOK [...] cpan.org
AdminCc:

Bug Information
Severity: Important
Broken in: 2.121
Fixed in: (no value)



Subject: Data::Dumper should not install to site_perl
The Makefile.PL of Data::Dumper needs an additional line to install the module to the core module directory. Without this line Data::Dumper gets installed to site_perl and is never seen by programs, because the core module directory has precedence over site_perl. See the attached patch. Regards, Slaven
--- ./Makefile.PL.orig 2005-04-14 12:11:54.000000000 +0200 +++ ./Makefile.PL 2005-04-14 12:12:09.000000000 +0200 @@ -8,4 +8,5 @@ WriteMakefile( DIST_DEFAULT => 'all tardist', }, MAN3PODS => {}, + INSTALLDIRS => 'perl', );
From: Ola Finsbraaten
[SREZIC - Thu Apr 14 06:15:29 2005]: Show quoted text
> The Makefile.PL of Data::Dumper needs an additional line to install [..]
This bug was filed 4 months ago. It's quite simple and the submitter attached a patch. Why has this not been fixed? O.F. --
On 2005-08-29 23:42:37, guest wrote: Show quoted text
> [SREZIC - Thu Apr 14 06:15:29 2005]: >
> > The Makefile.PL of Data::Dumper needs an additional line to install [..]
> > This bug was filed 4 months ago. It's quite simple and the submitter > attached a patch. Why has this not been fixed? > > O.F. > -- > >
I just ran into this, in 2016. Wow, OMG, WTF!
On 2005-04-14 03:15:29, SREZIC wrote: Show quoted text
> The Makefile.PL of Data::Dumper needs an additional line to install the > module to the core module directory. Without this line Data::Dumper gets > installed to site_perl and is never seen by programs, because the > core module directory has precedence over site_perl. > > See the attached patch. > > Regards, > Slaven
The patch isn't quite right. It should be: WriteMakefile( ... + $] >= 5.005 && $] <= 5.011000 ? ( INSTALLDIRS => 'perl' ) : (), ... );
On Sat Jul 02 18:21:19 2016, ETHER wrote: Show quoted text
> The patch isn't quite right. It should be: > > WriteMakefile( > ... > + $] >= 5.005 && $] <= 5.011000 ? ( INSTALLDIRS => 'perl' ) : (), > ... > ); > >
This adjustment needs to be done, on 5.012 or greater (where site_perl is correctly ordered) dual-life modules should not be overwriting the core module directory. See for example https://metacpan.org/source/EXODIST/Test-Simple-1.302037/Makefile.PL#L37 (but Data::Dumper was cored in 5.005, where Test::Simple was cored in 5.006002).