Skip Menu |

This queue is for tickets about the Mail-OpenDKIM CPAN distribution.

Report information
The Basics
Id: 122811
Status: resolved
Priority: 0/
Queue: Mail-OpenDKIM
People
Owner: INFRACANI [...] cpan.org
Requestors: Pascal [...] rkfd.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 4203
Fixed in: (no value)

History Show all quoted text
  Tue Aug 15 23:27:11 2017 Pascal [...] rkfd.com - Ticket created
Subject: KeyFile argument does not work
The documentation shows passing the name of the file containing the private key as an argument named KeyFile. Doing so results in the error: Can't call method "data" on an undefined value at /usr/local/lib64/perl5/Mail/OpenDKIM/Signer.pm line 131 It appears Signer.pm is expecting a Mail::OpenDKIM::PrivateKey to be passed as an argument named Key. I inserted the below in Signer.pm before line 128 to allow both the current and documented functionality. croak 'Private key not found' unless $args{Key} || ($args{KeyFile} && ($args{Key} = Mail::OpenDKIM::PrivateKey->load(File => $args{KeyFile})));
  Wed Aug 16 02:04:31 2017 INFRACANI [...] cpan.org - Correspondence added
On Tue Aug 15 23:27:11 2017, Pascal@rkfd.com wrote: Show quoted text
> The documentation shows passing the name of the file containing the > private key as an argument named KeyFile. Doing so results in the > error: Can't call method "data" on an undefined value at > /usr/local/lib64/perl5/Mail/OpenDKIM/Signer.pm line 131 > > It appears Signer.pm is expecting a Mail::OpenDKIM::PrivateKey to be > passed as an argument named Key. I inserted the below in Signer.pm > before line 128 to allow both the current and documented > functionality. > > croak 'Private key not found' unless $args{Key} || ($args{KeyFile} && > ($args{Key} = Mail::OpenDKIM::PrivateKey->load(File => > $args{KeyFile})));
Thank you for your report. Yes, looks like your analysis is correct. I'll apply patches along the lines you suggest.
  Wed Aug 16 02:04:32 2017 The RT System itself - Status changed from 'new' to 'open'
  Wed Aug 16 02:04:32 2017 INFRACANI [...] cpan.org - Taken
  Thu Aug 17 10:33:24 2017 INFRACANI [...] cpan.org - Correspondence added
On Wed Aug 16 02:04:31 2017, INFRACANI wrote: Show quoted text
> > croak 'Private key not found' unless $args{Key} || ($args{KeyFile} && > > ($args{Key} = Mail::OpenDKIM::PrivateKey->load(File => > > $args{KeyFile})));
> > Thank you for your report. Yes, looks like your analysis is correct. I'll > apply patches along the lines you suggest.
A patch with equivalent functionality has been applied in version 4204.
  Thu Aug 17 10:33:25 2017 INFRACANI [...] cpan.org - Status changed from 'open' to 'resolved'