Bug #122800 for Data-Dx: Bug: Output not working on Windows (included fix)

Mon Aug 14 11:29:55 2017 wrb4181 [...] gmail.com - Ticket created

Subject:	Bug: Output not working on Windows (included fix)
Date:	Mon, 14 Aug 2017 10:56:07 -0400
To:	bug-data-dx [...] rt.cpan.org
From:	William Barker <wrb4181 [...] gmail.com>

Data::Dx-0.000006 Strawberry 5.26.0 Windows 10 64-bit Output does not display correctly on Windows. Example: use 5.26.0 use warnings; use Data::Dx; my $x = 5; Dx $x; # ←[34m#line 11 test.pl #←[0m←[1;38;5;136m$x←[0m←[1;38;5;245m = ←[0m←[36m1←[0m Problem is Term::ANSIColor does not work under Windows terminals. However, Win32::Console::ANSI does, and pretty much uses the same settings. Fix line #67 Either: state $colorer = eval { require Win32::Console::ANSI; require Term::ANSIColor; or state $colorer = eval { if ( $^O = 'MSWin32' ) { require Win32::Console::ANSI; }; else { require Term::ANSIColor; };

Mon Aug 14 12:58:42 2017 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #122800] Bug: Output not working on Windows (included fix)
Date:	Mon, 14 Aug 2017 17:41:40 +0200
To:	bug-Data-Dx [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Thanks William. I've added a version of your patch, but have no way to test it. I just uploaded the new release, so when you have a moment you might like to download it and see whether my adjustment solves your problem. I'll leave the issue open until I hear back from you either way. Much appreciated, Damian

Mon Aug 14 12:58:43 2017 The RT System itself - Status changed from 'new' to 'open'

Mon Aug 14 13:14:18 2017 wrb4181 [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122800] Bug: Output not working on Windows (included fix)
Date:	Mon, 14 Aug 2017 13:13:44 -0400
To:	bug-Data-Dx [...] rt.cpan.org
From:	William Barker <wrb4181 [...] gmail.com>

Yes works great now. Thank you. Also, just wanted to say that as far as I'm aware Win32::Console::ANSI comes in the default Strawberry and ActiveState installs. -William On Mon, Aug 14, 2017 at 12:58 PM, damian@conway.org via RT < bug-Data-Dx@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122800 > > > Thanks William. > > I've added a version of your patch, but have no way to test it. > I just uploaded the new release, so when you have a moment > you might like to download it and see whether my adjustment > solves your problem. > > I'll leave the issue open until I hear back from you either way. > > Much appreciated, > > Damian > >

Mon Aug 14 13:19:40 2017 DCONWAY [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Aug 14 13:20:46 2017 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #122800] Bug: Output not working on Windows (included fix)
Date:	Mon, 14 Aug 2017 19:19:20 +0200
To:	bug-Data-Dx [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Thanks for confirming the fix, William. I'll close the report now. Damian

Mon Aug 14 13:26:25 2017 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #122800] Bug: Output not working on Windows (included fix)
Date:	Mon, 14 Aug 2017 17:41:40 +0200
To:	bug-Data-Dx [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Thanks William. I've added a version of your patch, but have no way to test it. I just uploaded the new release, so when you have a moment you might like to download it and see whether my adjustment solves your problem. I'll leave the issue open until I hear back from you either way. Much appreciated, Damian