Bug #12272 for Apache-Dir: Support for mp2?

Wed Apr 13 11:13:44 2005 Guest - Ticket created

Subject:

Support for mp2?

Hi David, Will this module ever support mp2? Given the recent announcement of RC5, it may be that you'll need to release Apache2::Dir to support mp2. I'm still trying to figure out how the changes will affect my software. Thanks, William

Wed Apr 13 12:27:51 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [cpan #12272] Support for mp2?
Date:	Wed, 13 Apr 2005 09:20:49 -0700
To:	bug-Apache-Dir [...] rt.cpan.org
RT-Send-Cc:

On Apr 13, 2005, at 8:13 AM, Guest via RT wrote: Show quoted text

> Will this module ever support mp2? Given the recent announcement of > RC5, it may be that you'll need to release Apache2::Dir to support > mp2. I'm still trying to figure out how the changes will affect my > software.

Actually, I think that Apache-Dir will not be necessary in mod_perl2, becuase mp2 does not handle directory requests at all by default. But I would ask on the mod_perl list just to be sure. Cheers, David

Wed Apr 13 12:36:19 2005 Guest - Correspondence added

[david@kineticode.com - Wed Apr 13 12:27:51 2005]: Show quoted text

> Actually, I think that Apache-Dir will not be necessary in mod_perl2, > becuase mp2 does not handle directory requests at all by default. But I > would ask on the mod_perl list just to be sure.

Funny you should mention that as it is how I came to be aware of your module[1]. It may make more sense when you see my configuration which is in the thread. Any further suggestions/advice? Thanks, William [1] http://marc.theaimsgroup.com/?l=apache-modperl&m=111340046622703&w=2

Wed Apr 13 12:53:46 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [cpan #12272] Support for mp2?
Date:	Wed, 13 Apr 2005 09:53:33 -0700
To:	bug-Apache-Dir [...] rt.cpan.org
RT-Send-Cc:

On Apr 13, 2005, at 9:36 AM, Guest via RT wrote: Show quoted text

> Funny you should mention that as it is how I came to be aware of your > module[1]. It may make more sense when you see my configuration which > is > in the thread. Any further suggestions/advice?

Get Jon and Dave to add the fixup handler to the Apache2 Mason handler? Regards, David

Wed Apr 13 13:39:33 2005 Guest - Correspondence added

[david@kineticode.com - Wed Apr 13 12:53:46 2005]: Show quoted text

> Get Jon and Dave to add the fixup handler to the Apache2 Mason handler?

David, I'm not using Mason and don't know what you mean about the fixup handler. Is there a reference to this on perl.apache.org? Thanks, William

Wed Apr 13 13:57:23 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [cpan #12272] Support for mp2?
Date:	Wed, 13 Apr 2005 10:57:14 -0700
To:	bug-Apache-Dir [...] rt.cpan.org
RT-Send-Cc:

On Apr 13, 2005, at 10:39 AM, Guest via RT wrote: Show quoted text

> I'm not using Mason and don't know what you mean about the fixup > handler. Is there a reference to this on perl.apache.org?

That document I wrote on masonhq.com. is the best resource that I know of. Sorry I can't be more help. Regards, David

Wed Apr 13 14:18:08 2005 Guest - Correspondence added

[david@kineticode.com - Wed Apr 13 13:57:23 2005]: Show quoted text

> That document I wrote on masonhq.com. is the best resource that I know > of.

That's what Geoff Young told me also. I just adjusted Apache::Dir to support mp2. Doing so was easy but unfortunately does not solve the problems that I described in my post to mod_perl. Back to the list. Sorry to bother you. William

Wed Apr 13 15:54:03 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [cpan #12272] Support for mp2?
Date:	Wed, 13 Apr 2005 12:53:54 -0700
To:	bug-Apache-Dir [...] rt.cpan.org
RT-Send-Cc:

On Apr 13, 2005, at 11:18 AM, Guest via RT wrote: Show quoted text

> That's what Geoff Young told me also. I just adjusted Apache::Dir to > support mp2.

Do you have a patch for that? David

Wed Apr 13 16:42:21 2005 Guest - Correspondence added

[david@kineticode.com - Wed Apr 13 15:54:03 2005]: Show quoted text

> Do you have a patch for that?

I just replaced Apache::Constants with Apache::Const. This makes it only suitable for Apache2 pre-RC5. From what I've understood so far regarding the new RC5[1], you'd need to change Apache::Const to Apache2::Const. Although there are ways to support both mp1 and mp2 with the same module, I don't know if the mp2 team is suggesting that module authors also rename their modules or support either version via a single Apache:: module. The document[1] doesn't really say. HTH, William [1] http://perl.apache.org/docs/2.0/rename.html

Wed Apr 13 17:29:45 2005 david [...] kineticode.com - Correspondence added

From:	David Wheeler <david [...] kineticode.com>
Subject:	Re: [cpan #12272] Support for mp2?
Date:	Wed, 13 Apr 2005 14:29:33 -0700
To:	bug-Apache-Dir [...] rt.cpan.org
RT-Send-Cc:

On Apr 13, 2005, at 1:42 PM, Guest via RT wrote: Show quoted text

> Although there are ways to support both mp1 and mp2 with the same > module, I don't know if the mp2 team is suggesting that module authors > also rename their modules or support either version via a single > Apache:: module. The document[1] doesn't really say.

I think it depends on the module. Apache::Dir isn't too complex. So if it just needs to use the proper constants class, it can probably just do something like this: my $const_class = $ENV{MOD_PERL_API_VERSION} ? Apache2::Const : Apache::Constants; eval "use $const_class qw(DECLINED DIR_MAGIC_TYPE HTTP_MOVED_PERMANENTLY)"; This assumes RC5, of course. Regards, David

Wed Apr 13 17:50:05 2005 Guest - Correspondence added

[david@kineticode.com - Wed Apr 13 17:29:45 2005]: Show quoted text

> I think it depends on the module. Apache::Dir isn't too complex. So if > it just needs to use the proper constants class, it can probably just > do something like this:

I tend to agree with you that it depends on the module. That patch looks good to me though I can't test it as I'm not having a problem which it was built to handle :). TTYL, William

Mon Sep 05 10:05:18 2005 dwheeler [...] cpan.org - Fixed in 0.04 added

Mon Sep 05 10:05:18 2005 dwheeler [...] cpan.org - Status changed from 'new' to 'resolved'