Bug #122437 for HTTP-XSCookies: HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl

Tue Jul 11 10:22:40 2017 nanis [...] cpan.org - Ticket created

Subject:	HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Tue, 11 Jul 2017 10:22:25 -0400
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	"A. Sinan Unur" <nanis [...] cpan.org>

This is due to: 1. Use of strcasecmp in baker.xs. [_stricmp][1] might help. Also, `strings.h` does not exist on Windows. 2. Inclusion of `unistd.h` in `gmem.c`. Interestingly, with that line commented out, the file still compiles OK. I am not sure why it is needed. 3. Use of `gmtime_r`. I believe Windows' [_gmtime64][2] provides equivalent functionality (but with a different interface). I am reporting this because, currently, failing to build `HTTP::XSCookies` breaks the Dancer build on this system as well[3]. I am not sure if I will have the time to put together a patch, but, at the very least bailing out of the installation on unsupported platforms might be something to add to your module's Makefile.PL. Thank you. -- Sinan [1]: https://msdn.microsoft.com/en-us/library/k59z8dwe.aspx [2]: https://msdn.microsoft.com/en-us/library/0z9czt0w.aspx [3]: https://github.com/PerlDancer/Dancer2/issues/1358

Wed Jul 12 02:59:40 2017 gonzalo.diethelm [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122437] HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Wed, 12 Jul 2017 08:59:29 +0200
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	Gonzalo Diethelm <gonzalo.diethelm [...] gmail.com>

I have uploaded HTTP-XSCookies-0.000008.tar.gz to CPAN with (I hope) fixes for all these issues when compiling on Windows. I don't have a Windows environment to try my changes, so please let me know if you find anything else. And thanks for the bug report! Cheers, Gonzo On Tue, Jul 11, 2017 at 4:22 PM, nanis@cpan.org via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text

> Tue Jul 11 10:22:40 2017: Request 122437 was acted upon. > Transaction: Ticket created by nanis@cpan.org > Queue: HTTP-XSCookies > Subject: HTTP::XSCookies 0.000007 fails to build on Windows with > Visual Studio built perl > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: nanis@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > > > This is due to: > > 1. Use of strcasecmp in baker.xs. [_stricmp][1] might help. Also, > `strings.h` does not exist on Windows. > > 2. Inclusion of `unistd.h` in `gmem.c`. Interestingly, with that line > commented out, the file still compiles OK. I am not sure why it is > needed. > > 3. Use of `gmtime_r`. I believe Windows' [_gmtime64][2] provides > equivalent functionality (but with a different interface). > > I am reporting this because, currently, failing to build > `HTTP::XSCookies` breaks the Dancer build on this system as well[3]. > > I am not sure if I will have the time to put together a patch, but, at > the very least bailing out of the installation on unsupported > platforms might be something to add to your module's Makefile.PL. > > Thank you. > > -- Sinan > > [1]: https://msdn.microsoft.com/en-us/library/k59z8dwe.aspx > [2]: https://msdn.microsoft.com/en-us/library/0z9czt0w.aspx > [3]: https://github.com/PerlDancer/Dancer2/issues/1358 >

-- Gonzalo Diethelm gonzalo.diethelm@gmail.com

Wed Jul 12 02:59:40 2017 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 12 07:09:16 2017 nanis [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #122437] HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Wed, 12 Jul 2017 07:09:01 -0400
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	"A. Sinan Unur" <nanis [...] cpan.org>

On Wed, Jul 12, 2017 at 2:59 AM, Gonzalo Diethelm via RT <bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > > I have uploaded HTTP-XSCookies-0.000008.tar.gz to CPAN with (I hope) fixes > for all these issues when compiling on Windows.

Unfortunately, I get: t\10_bake_crush.t .......... 1/? Free to wrong pool 152b7f9dc30 not 90000e528263e02a at t\10_bake_crush.t line 98. t\10_bake_crush.t .......... Dubious, test returned 5 (wstat 1280, 0x500) All 29 subtests passed t\20_cookie_baker_bake.t ... ok t\20_cookie_baker_crush.t .. 1/? Free to wrong pool 1a37e17df10 not 100090cac79f7771 at t\20_cookie_baker_crush.t line 37. t\20_cookie_baker_crush.t .. Dubious, test returned 5 (wstat 1280, 0x500) All 10 subtests passed t\30_cookie_baker_xs.t ..... 1/? Free to wrong pool 13ca71a3cf0 not 1000238fdfb1a6c7 at t\30_cookie_baker_xs.t line 37. t\30_cookie_baker_xs.t ..... Dubious, test returned 5 (wstat 1280, 0x500) All 10 subtests passed t\80_memory_leak.t ......... skipped: Test::MemoryGrowth is needed for this test I am afraid I am going to have to spend some "quality" time with the debugger to see what's going on, but I am not sure when I am going to be able to do that. Of course, these problems may be due to something that is wrong with my perl build as well. If it is any consolation, all the tests pass, but the "free to wrong pool" messes things up. Thank you. -- Sinan

Wed Jul 12 11:07:08 2017 gonzalo.diethelm [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122437] HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Wed, 12 Jul 2017 17:06:47 +0200
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	Gonzalo Diethelm <gonzalo.diethelm [...] gmail.com>

From what little I remember, these errors happen when using malloc / realloc / free on Windows, instead of Perl's "native" memory allocation / deallocation functions. Sob. I had forgotten how much I hate developing in Windows. I will try to find out how this is supposed to be handled. Cheers, Gonzo On Wed, Jul 12, 2017 at 1:09 PM, nanis@cpan.org via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text

> Queue: HTTP-XSCookies > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > > On Wed, Jul 12, 2017 at 2:59 AM, Gonzalo Diethelm via RT > <bug-HTTP-XSCookies@rt.cpan.org> wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > > > > I have uploaded HTTP-XSCookies-0.000008.tar.gz to CPAN with (I hope)

> fixes

> > for all these issues when compiling on Windows.

> > Unfortunately, I get: > > t\10_bake_crush.t .......... 1/? Free to wrong pool 152b7f9dc30 not > 90000e528263e02a at t\10_bake_crush.t line 98. > t\10_bake_crush.t .......... Dubious, test returned 5 (wstat 1280, 0x500) > All 29 subtests passed > t\20_cookie_baker_bake.t ... ok > t\20_cookie_baker_crush.t .. 1/? Free to wrong pool 1a37e17df10 not > 100090cac79f7771 at t\20_cookie_baker_crush.t line 37. > t\20_cookie_baker_crush.t .. Dubious, test returned 5 (wstat 1280, 0x500) > All 10 subtests passed > t\30_cookie_baker_xs.t ..... 1/? Free to wrong pool 13ca71a3cf0 not > 1000238fdfb1a6c7 at t\30_cookie_baker_xs.t line 37. > t\30_cookie_baker_xs.t ..... Dubious, test returned 5 (wstat 1280, 0x500) > All 10 subtests passed > t\80_memory_leak.t ......... skipped: Test::MemoryGrowth is needed for > this test > > I am afraid I am going to have to spend some "quality" time with the > debugger to see what's going on, but I am not sure when I am going to > be able to do that. Of course, these problems may be due to something > that is wrong with my perl build as well. > > If it is any consolation, all the tests pass, but the "free to wrong > pool" messes things up. > > Thank you. > > -- Sinan >

-- Gonzalo Diethelm gonzalo.diethelm@gmail.com

Wed Jul 12 11:15:55 2017 nanis [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #122437] HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Wed, 12 Jul 2017 11:15:41 -0400
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	"A. Sinan Unur" <nanis [...] cpan.org>

On Wed, Jul 12, 2017 at 11:07 AM, Gonzalo Diethelm via RT <bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > I will try to find out how this is supposed to be handled.

Thank you for all your work on this.

Thu Jul 13 02:53:34 2017 gonzalo.diethelm [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122437] HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Thu, 13 Jul 2017 08:53:25 +0200
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	Gonzalo Diethelm <gonzalo.diethelm [...] gmail.com>

Hey, no worries. I avoided returning to the crazy world of Win32 development for as long as I could, but now that other stuff depends on this, I need to do the right thing. Someone here had been nagging me about this for a long time anyway... I just uploaded HTTP-XSCookies-0.000009.tar.gz to CPAN, where I replaced all the memory management with Perl's macros (Newx, Safefree and friends). All tests still pass on my laptop; I am now curious to see if this fixes the Win32 problems. You can also grab the latest from https://github.com/gonzus/http-xscookies Please let me know how it goes! Cheers, Gonzo On Wed, Jul 12, 2017 at 5:15 PM, nanis@cpan.org via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text

> Queue: HTTP-XSCookies > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > > On Wed, Jul 12, 2017 at 11:07 AM, Gonzalo Diethelm via RT > <bug-HTTP-XSCookies@rt.cpan.org> wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > > I will try to find out how this is supposed to be handled.

> > Thank you for all your work on this. >

-- Gonzalo Diethelm gonzalo.diethelm@gmail.com

Thu Jul 13 06:27:03 2017 nanis [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #122437] HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Thu, 13 Jul 2017 06:26:46 -0400
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	"A. Sinan Unur" <nanis [...] cpan.org>

On Thu, Jul 13, 2017 at 2:53 AM, Gonzalo Diethelm via RT <bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 >

Show quoted text

> I just uploaded HTTP-XSCookies-0.000009.tar.gz to CPAN, where I replaced > all the memory management with Perl's macros (Newx, Safefree and friends). > All tests still pass on my laptop; I am now curious to see if this fixes > the Win32 problems.

Yup, that did the trick: C:\> cpanm https://cpan.metacpan.org/authors/id/G/GO/GONZUS/HTTP-XSCookies-0.000009.tar.gz --> Working on https://cpan.metacpan.org/authors/id/G/GO/GONZUS/HTTP-XSCookies-0.000009.tar.gz Fetching https://cpan.metacpan.org/authors/id/G/GO/GONZUS/HTTP-XSCookies-0.000009.tar.gz ... OK Configuring HTTP-XSCookies-0.000009 ... OK Building and testing HTTP-XSCookies-0.000009 ... OK Successfully installed HTTP-XSCookies-0.000009 1 distribution installed Thank you. -- Sinan

Thu Jul 13 06:49:08 2017 gonzalo.diethelm [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122437] HTTP::XSCookies 0.000007 fails to build on Windows with Visual Studio built perl
Date:	Thu, 13 Jul 2017 12:48:56 +0200
To:	bug-HTTP-XSCookies [...] rt.cpan.org
From:	Gonzalo Diethelm <gonzalo.diethelm [...] gmail.com>

Oh, awesome. Thanks for confirming. It's a keeper, then! Cheers, Gonzo On Thu, Jul 13, 2017 at 12:27 PM, nanis@cpan.org via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text

> Queue: HTTP-XSCookies > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 > > > On Thu, Jul 13, 2017 at 2:53 AM, Gonzalo Diethelm via RT > <bug-HTTP-XSCookies@rt.cpan.org> wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=122437 >

>

> > I just uploaded HTTP-XSCookies-0.000009.tar.gz to CPAN, where I replaced > > all the memory management with Perl's macros (Newx, Safefree and

> friends).

> > All tests still pass on my laptop; I am now curious to see if this fixes > > the Win32 problems.

> > Yup, that did the trick: > > C:\> cpanm https://cpan.metacpan.org/authors/id/G/GO/GONZUS/HTTP- > XSCookies-0.000009.tar.gz > --> Working on https://cpan.metacpan.org/authors/id/G/GO/GONZUS/HTTP- > XSCookies-0.000009.tar.gz > Fetching https://cpan.metacpan.org/authors/id/G/GO/GONZUS/HTTP- > XSCookies-0.000009.tar.gz > ... OK > Configuring HTTP-XSCookies-0.000009 ... OK > Building and testing HTTP-XSCookies-0.000009 ... OK > Successfully installed HTTP-XSCookies-0.000009 > 1 distribution installed > > Thank you. > > -- Sinan >

-- Gonzalo Diethelm gonzalo.diethelm@gmail.com