Skip Menu |

This queue is for tickets about the JSON CPAN distribution.

Report information
The Basics
Id: 122421
Status: resolved
Priority: 0/
Queue: JSON
People
Owner: Nobody in particular
Requestors: ilmari+cpan [...] ilmari.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jul 10 08:28:01 2017 ilmari+cpan [...] ilmari.org - Ticket created
Subject: Requires Test::More 0.88
t/00_load_backport.pp fails on pristine 5.8.x perls, because it calls isa_ok() on the class name returned by JSON->backend, which doesn't work until Test::More 0.88. Additionally t/e02_bool.t uses note() which was not added until Test::More 0.82. Either the Test::More requirement needs bumping, or these tests need rewriting to not use such "modern" Test::More features.
  Mon Jul 10 09:36:27 2017 ishigaki [...] cpan.org - Correspondence added
On Mon Jul 10 21:28:01 2017, ilmari wrote: Show quoted text
> t/00_load_backport.pp fails on pristine 5.8.x perls, because it calls > isa_ok() on the class name returned by JSON->backend, which doesn't > work until Test::More 0.88. > > Additionally t/e02_bool.t uses note() which was not added until > Test::More 0.82. > > Either the Test::More requirement needs bumping, or these tests need > rewriting to not use such "modern" Test::More features.
Thanks for spotting this. Fixed with https://github.com/makamaka/JSON/commit/1bb0e44e83f03dc5afcc0b85e1703760290c49fa
  Mon Jul 10 09:36:28 2017 The RT System itself - Status changed from 'new' to 'open'
  Mon Jul 10 09:36:33 2017 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'
  Thu Dec 06 12:56:30 2018 ishigaki [...] cpan.org - Correspondence added
On Mon Jul 10 22:36:27 2017, ISHIGAKI wrote: Show quoted text
> On Mon Jul 10 21:28:01 2017, ilmari wrote:
> > t/00_load_backport.pp fails on pristine 5.8.x perls, because it calls > > isa_ok() on the class name returned by JSON->backend, which doesn't > > work until Test::More 0.88. > > > > Additionally t/e02_bool.t uses note() which was not added until > > Test::More 0.82. > > > > Either the Test::More requirement needs bumping, or these tests need > > rewriting to not use such "modern" Test::More features.
> > Thanks for spotting this. Fixed with > https://github.com/makamaka/JSON/commit/1bb0e44e83f03dc5afcc0b85e1703760290c49fa
This has been fixed already. Closed. Thanks!
  Thu Dec 06 12:56:31 2018 ishigaki [...] cpan.org - Status changed from 'patched' to 'resolved'