Skip Menu |

This queue is for tickets about the Mail-DKIM CPAN distribution.

Report information
The Basics
Id: 122384
Status: open
Priority: 0/
Queue: Mail-DKIM

People
Owner: mbradshaw [...] cpan.org
Requestors: 4stevejames [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Mail::DKIM Issues
Date: Thu, 6 Jul 2017 21:14:14 -0700
To: bug-Mail-DKIM [...] rt.cpan.org
From: Steve James <4stevejames [...] gmail.com>
1. Mail::DKIM::Signer will not produce signatures passable by Gmail if any headers that contain address lists do not have at least one space after each comma in the list. For example: *To:* address1@example1.org*,*address2@example2.org will not produce a correct DKIM signature w/ relaxed canonicalization because there is not a space after the comma delimiter in the address list. This applies to all headers that can take an address list. I believe this is an issue with the canonicalization algorithm. 2. If Mail::DKIM is used in conjunction w/ Email::Simple or Email::MIME, the Mail::DKIM::TextWrap algorithm produces nicely wrapped signatures. However, when setting the header via Email::Simple:header_set(), the CR/LFs inserted by TextWrap are converted to CR/CR/LF's which is clearly wrong and will cause failing DKIM tests. It would be nice to be able to set the line termination character for TextWrap in the Mail::DKIM::Signer::new() parameters, since I found that if the line termination is instead LF, then header_set() will convert it to the correct CR/LF sequences. 3. Mail::DKIM::Verifier should state what the requested algorithm is in the results detail if the result is invalid (unsupported algorithm). This helps with troubleshooting. 4. For the new extended_headers() method, it would be very helpful to just be able to specify the extended headers in the new() parameters. You could simply use an additional delimiter ( = or => ) that is checked for in the Headers parameter. If the extra delimiter exists then the headers are processed as extended headers. 5. Right now, I am seeing detailed fail results as "message has been altered" or "body has been altered". I would request an additional "headers have been altered" fail message... that should be doable and would really help. Thanks! -- *Steve James*
Issue 1, unable to reproduce. Show quoted text
> 1. Mail::DKIM::Signer will not produce signatures passable by Gmail if any > headers that contain address lists do not have at least one space after > each comma in the list. > > For example: > > *To:* address1@example1.org*,*address2@example2.org > > will not produce a correct DKIM signature w/ relaxed canonicalization > because there is not a space after the comma delimiter in the address > list. This applies to all headers that can take an address list. I > believe this is an issue with the canonicalization algorithm.
Authentication-Results: mx.google.com; dkim=pass header.i=@<REDACTED> header.b=WV+R3uGM; spf=fail (google.com: domain of <REDACTED> as permitted sender) smtp.mailfrom=<REDACTED> Date: Sat, 29 Jul 2017 15:47:40 -0700 (PDT) Message-Id: <597d108c.99d1370a.dfd38.0f11SMTPIN_ADDED_MISSING@mx.google.com> DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=<REDACTED>; h=from :subject:subject:to; s=sysmsg-1; bh=vxHXq7bMZ9+UHGuKBsbQKsDHmmk=; b= WV+R3uGM1H/y3QdRDATisLPaIhPU6zmo393xiKsczbKFN7R13jBjPI/kCoqB1x0e PtPkidHkRrdbghUSSrodUPndNL/FI4u/b++n6DJNZKIORqF9H1lyegP8PxJjB4Z0 WSvHE0jbFnX2UoGeKBjOUR4glVQDt+YY8KqKz5367NA= From: test@example.com To: one@example.com,two@example.com Subject: Test