Skip Menu |

This queue is for tickets about the LWP-Online CPAN distribution.

Report information
The Basics
Id: 122310
Status: new
Priority: 0/
Queue: LWP-Online

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.08
Fixed in: (no value)



Subject: Yahoo's exclamation mark may not appear
It seems that it's possible that the content on www.yahoo.com has no occurrence of "Yahoo!", just occurrences of "Yahoo" without the exclamation mark. So probably the regexp should be fixed to match just /Yahoo/ This could also be the explanation why the "opposite results" test sometimes fails: ... # Failed test 'online() and offline() return opposite results' # at t/02_main.t line 32. # got: '1' # expected: '' # Looks like you failed 1 test of 6. t/02_main.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests ...
On 2017-07-02 04:56:54, SREZIC wrote: Show quoted text
> It seems that it's possible that the content on www.yahoo.com has no > occurrence of "Yahoo!", just occurrences of "Yahoo" without the > exclamation mark. So probably the regexp should be fixed to match just > /Yahoo/ > > This could also be the explanation why the "opposite results" test > sometimes fails: > > ... > # Failed test 'online() and offline() return opposite results' > # at t/02_main.t line 32. > # got: '1' > # expected: '' > # Looks like you failed 1 test of 6. > t/02_main.t ...... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/6 subtests > ...
Proposed patch (which also addresses RT #114154): http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/LWP-Online-1.08-RT114154.patch