Bug #122255 for File-Path: "cannot chdir to child for ..." errors in some CPAN distributions

On Tue Jun 27 15:17:10 2017, SREZIC wrote: Show quoted text
Yes. Run attached program app.pl, first in perl-5.26.0, (File::Path v2.1201) then in blead (which has been updated to File::Path v2.14). Results attached. This is almost certainly a consequence of the changes we made in order to deal with https://rt.cpan.org/Ticket/Display.html?id=121951. We'll have to see whether we can avoid these problems without impacting the security changes. This will not be easy or quickly forthcoming. Thank you very much. Jim Keenan

use 5.12.0; use warnings; use File::Path qw( make_path remove_tree); use File::Temp qw( tempdir ); use File::Spec; use Fcntl qw(:mode); my $tdir = tempdir( CLEANUP => 1 ); chdir $tdir or die "Unable to chdir to $tdir: $!"; my $subdir = $$; say "subdir: $subdir"; my @created; @created = make_path($subdir); (scalar(@created) == 1) ? say "Created 1 subdirectory" : say "Problem creating subdirectory"; my $p = File::Spec->catdir($tdir, $subdir); (-d $p) ? say "$p exists" : say "$p does not exist"; my @perms = stat($p); printf("%04o\n" => S_IMODE($perms[2])); my $rv; $rv = chmod(oct(0400), $p); ($rv == 1) ? say "chmod 1 directory to 0400" : say "problem chmod to 0400: $rv"; @perms = stat($p); printf("%04o\n" => S_IMODE($perms[2])); my $removed_count; $removed_count = remove_tree($p); ($removed_count == 1) ? say "deleted 1 directory" : say "problem remove_tree: $removed_count"; (! -d $p) ? say "$p no longer exists" : say "$p still exists - WTF"; say "\nFinished";

$ perl -v | head -2 | tail -1; perl -MFile::Path -E 'say $File::Path::VERSION;'; perl app.pl This is perl 5, version 26, subversion 0 (v5.26.0) built for x86_64-linux 2.1201 subdir: 17390 Created 1 subdirectory /tmp/o_ryFjSTLj/17390 exists 0775 chmod 1 directory to 0400 0256 deleted 1 directory /tmp/o_ryFjSTLj/17390 no longer exists Finished $ ~/testing/blead/bin/perl -v | head -2 | tail -1; ~/testing/blead/bin/perl -I~/testing/blead/lib -MFile::Path -E 'say $File::Path::VERSION;'; ~/testing/blead/bin/perl -I~/testing/blead/lib app.pl This is perl 5, version 27, subversion 2 (v5.27.2 (v5.27.1-77-g571ee10)) built for x86_64-linux 2.14 subdir: 17408 Created 1 subdirectory /tmp/0V0huqj44F/17408 exists 0775 chmod 1 directory to 0400 0256 cannot chdir to child for /tmp/0V0huqj44F/17408: Permission denied at app.pl line 28. problem remove_tree: 0 /tmp/0V0huqj44F/17408 still exists - WTF Finished cannot chdir to child for /tmp/0V0huqj44F/17408: Permission denied at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 795. cannot remove directory for /tmp/0V0huqj44F: Directory not empty at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 795.

On Tue Jun 27 15:17:10 2017, SREZIC wrote: Show quoted text
Here we have a significant problem: File::Temp's dependence on File::Path::rmtree. If I run the program attached, filetemp.pl, under perl-5.26.0 and File::Path 2.1201, no warnings are emitted and all tempdirs are removed. If, I however, I run the program with Perl 5 blead and File::Path 2.14, then warnings are emitted after the code has run but at the point where 'CLEANUP => 1' is taking effect. The tempdirs are not removed, defeating the point of the 'CLEANUP => 1'. The tail of the output from the debugger is also attached. ##### $ ls -ltr /tmp | tail -5 -rw------- 1 jkeenan jkeenan 0 Jun 28 10:08 38eS2lsUa0 drwx------ 3 jkeenan jkeenan 4096 Jun 28 10:09 Y1Ko2x75Mv -rw------- 1 jkeenan jkeenan 0 Jun 28 10:10 RIoQN4x57v drwx------ 3 jkeenan jkeenan 4096 Jun 28 10:23 86wXLcdhTP drwx------ 3 jkeenan jkeenan 4096 Jun 28 10:24 9f9BWnRVYW $ ~/testing/blead/bin/perl -I~/testing/blead/lib filetemp.pl Perl version: 5.027002 File::Path version: 2.14 subdir name: 29081 Created 1 subdirectory /tmp/NSJxaEJaDH/29081 exists directory permissions: 0775 chmod 1 directory to 0 directory permissions: 0000 Finished cannot chdir to child for /tmp/NSJxaEJaDH/29081: Permission denied at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784. cannot remove directory for /tmp/NSJxaEJaDH: Directory not empty at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784. $ ls -ltr /tmp | tail -5 drwx------ 3 jkeenan jkeenan 4096 Jun 28 10:09 Y1Ko2x75Mv -rw------- 1 jkeenan jkeenan 0 Jun 28 10:10 RIoQN4x57v drwx------ 3 jkeenan jkeenan 4096 Jun 28 10:23 86wXLcdhTP drwx------ 3 jkeenan jkeenan 4096 Jun 28 10:24 9f9BWnRVYW drwx------ 3 jkeenan jkeenan 4096 Jun 28 10:33 NSJxaEJaDH ##### Relevant code from File::Temp 0.2304: ##### # Set up an end block to use these arrays END { local($., $@, $!, $^E, $?); cleanup(at_exit => 1); # <-- line 738 } # Cleanup function. Always triggered on END (with at_exit => 1) but # can be invoked manually. sub cleanup { ... foreach my $dir (@dirs) { if (-d $dir) { ... if ($at_exit) { $cwd = Cwd::abs_path(File::Spec->curdir) if not defined $cwd; my $abs = Cwd::abs_path($dir); if ($abs eq $cwd) { $cwd_to_remove = $dir; next; } } eval { rmtree($dir, $DEBUG, 0); }; # <-- line 784 warn $@ if ($@ && $^W); } } #####

Finished cannot chdir to child for /tmp/9f9BWnRVYW/28957: Permission denied at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784. at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Path.pm line 65. File::Path::_error(HASH(0x183e4d0), "cannot chdir to child", "/tmp/9f9BWnRVYW/28957") called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Path.pm line 429 File::Path::_rmtree(HASH(0x183e4d0), ARRAY(0x1671d48)) called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Path.pm line 500 File::Path::_rmtree(HASH(0x18362c0), ARRAY(0x16712f8)) called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Path.pm line 366 File::Path::rmtree("/tmp/9f9BWnRVYW", 0, 0) called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784 eval {...} called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784 File::Temp::cleanup("at_exit", 1) called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 738 File::Temp::END() called at filetemp.pl line 0 eval {...} called at filetemp.pl line 0 cannot remove directory for /tmp/9f9BWnRVYW: Directory not empty at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784. at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Path.pm line 65. File::Path::_error(HASH(0x18362c0), "cannot remove directory", "/tmp/9f9BWnRVYW") called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Path.pm line 549 File::Path::_rmtree(HASH(0x18362c0), ARRAY(0x16712f8)) called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Path.pm line 366 File::Path::rmtree("/tmp/9f9BWnRVYW", 0, 0) called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784 eval {...} called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 784 File::Temp::cleanup("at_exit", 1) called at /home/jkeenan/testing/blead/lib/perl5/5.27.2/File/Temp.pm line 738 File::Temp::END() called at filetemp.pl line 0 eval {...} called at filetemp.pl line 0 Debugged program terminated. Use q to quit or R to restart, use o inhibit_exit to avoid stopping after program termination, h q, h R or h o to get additional info.

use 5.12.0; use warnings; use File::Path qw( make_path rmtree ); use File::Temp qw( tempdir tempfile ); use File::Spec; use Fcntl qw(:mode); use Cwd; say "Perl version: $]"; say "File::Path version: $File::Path::VERSION"; my $subdir = $$; say "subdir name: $subdir"; my $cwd = cwd(); my $tdir = tempdir( CLEANUP => 1 ); chdir $tdir or die "Unable to chdir to $tdir: $!"; my @created; @created = make_path($subdir); (scalar(@created) == 1) ? say "Created 1 subdirectory" : say "Problem creating subdirectory"; my $p = File::Spec->catdir($tdir, $subdir); (-d $p) ? say "$p exists" : say "$p does not exist"; my @perms = stat($p); printf("directory permissions: %04o\n" => S_IMODE($perms[2])); my $rv; $rv = chmod(0, $p); ($rv == 1) ? say "chmod 1 directory to 0" : say "problem chmod to 0: $rv"; @perms = stat($p); printf("directory permissions: %04o\n" => S_IMODE($perms[2])); chdir $cwd or die "Unable to chdir to $cwd: $!"; say "\nFinished";