Skip Menu |

This queue is for tickets about the Keyword-TreeFold CPAN distribution.

Report information
The Basics
Id: 122184
Status: open
Priority: 0/
Queue: Keyword-TreeFold

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc: DCONWAY [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: v0.1.1
Fixed in: (no value)



CC: DCONWAY [...] cpan.org
Subject: Test suite started to fail (with newest Keyword::Declare?)
My smoker systems started to report the following failure: ... Can't use string ("()") as a HASH ref while "strict refs" in use at /home/cpansand/.cpan/build/2017062221/Keyword-TreeFold-v0.1.1-2/lib/Keyword/TreeFold.pm line 108. t/10-Lexical-Count.t ..... Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run Can't use string ("( $left, $rite )") as a HASH ref while "strict refs" in use at /home/cpansand/.cpan/build/2017062221/Keyword-TreeFold-v0.1.1-2/lib/Keyword/TreeFold.pm line 108. t/11-Algorithm-Sanity.t .. Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run # Failed test 'Single lexical fails' # at t/12-Single-Lexical.t line 30. # 'Can't use string ("( $left )") as a HASH ref while "strict refs" in use at /home/cpansand/.cpan/build/2017062221/Keyword-TreeFold-v0.1.1-2/lib/Keyword/TreeFold.pm line 108. # Compilation failed in require at (eval 7) line 1. # ' # doesn't match '(?^u:^Bogus tree_fold:)' # Looks like you failed 1 test of 1. t/12-Single-Lexical.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests ... Statistical analysis suggests that this happens if newer Keyword::Declare versions (>=0.001000) are installed (negative theta means "fail"): **************************************************************** Regression 'mod:Keyword::Declare' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 59954190010307112.00 [1='eq_0.001000'] -1.0000 0.0000 -33307883339059504.00 [2='eq_0.001002'] -1.0000 0.0000 -30176280551905472.00 R^2= 1.000, N= 100, K= 3 ****************************************************************
Subject: Re: [rt.cpan.org #122184] Test suite started to fail (with newest Keyword::Declare?)
Date: Fri, 23 Jun 2017 05:36:26 -0400
To: bug-Keyword-TreeFold [...] rt.cpan.org
From: Damian Conway <damian [...] conway.org>
The module assumes that the $argz variable of the tree-fold keyword is a PPI object. The documentation has always cautioned against that assumption. This problem could be fixed by replacing: my @varz = map { $_->isa( 'PPI::Token::Symbol' ) ? $_->{ content } : () } map { $_->isa( 'PPI::Statement::Expression' ) ? @{ $_->{ children } } : () } @{ $argz->{ children } }; with: my @varz = grep {defined} $argz =~ m{((?&PerlVariable)) $PPR::GRAMMAR}gx; Damian