Bug #122173 for Time-Piece: Time-Piece: _crt_localtime() fails to extend stack sufficiently

Thu Jun 22 09:45:32 2017 davem [...] iabyn.com - Ticket created

Subject:	Time-Piece: _crt_localtime() fails to extend stack sufficiently
Date:	Thu, 22 Jun 2017 14:44:58 +0100
To:	bug-Time-Piece [...] rt.cpan.org
From:	Dave Mitchell <davem [...] iabyn.com>

In Piece.xs, _crt_localtime() does an EXTEND(SP, 9). It should be 10, not 9, to allow for the PUSHs(newSViv(mytm.tm_isdst)) following the push_common_tm(). -- No matter how many dust sheets you use, you will get paint on the carpet.

Thu Jun 22 12:27:30 2017 ESAYM [...] cpan.org - Correspondence added

On Thu Jun 22 09:45:32 2017, davem@iabyn.com wrote: Show quoted text

> In Piece.xs, _crt_localtime() does an EXTEND(SP, 9). It should be 10, not > 9, to allow for the PUSHs(newSViv(mytm.tm_isdst)) following the > push_common_tm(). >

Wow, not sure how you caught that, good eyes. Looks like I'm the one to blame: https://github.com/Dual-Life/Time-Piece/commit/1eb5bf89cb019db66cf305f8cbb4575c8f7719fd as well. Will be fixed in 1.3201

Thu Jun 22 12:27:31 2017 The RT System itself - Status changed from 'new' to 'open'

Thu Jun 22 15:10:53 2017 davem [...] iabyn.com - Correspondence added

Subject:	Re: [rt.cpan.org #122173] Time-Piece: _crt_localtime() fails to extend stack sufficiently
Date:	Thu, 22 Jun 2017 20:10:43 +0100
To:	Samuel Smith via RT <bug-Time-Piece [...] rt.cpan.org>
From:	Dave Mitchell <davem [...] iabyn.com>

On Thu, Jun 22, 2017 at 12:27:36PM -0400, Samuel Smith via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122173 > > > On Thu Jun 22 09:45:32 2017, davem@iabyn.com wrote:

> > In Piece.xs, _crt_localtime() does an EXTEND(SP, 9). It should be 10, not > > 9, to allow for the PUSHs(newSViv(mytm.tm_isdst)) following the > > push_common_tm().

Show quoted text

> Wow, not sure how you caught that, good eyes.

I have a new debugging feature shortly to be added to bleadperl which checks whether a pp function (in this case pp_entersub) does enough EXTEND()s or similar to justify the number of elements it returns on the stack. Show quoted text

> Will be fixed in 1.3201

Thanks. -- Art is anything that has a label (especially if the label is "untitled 1")

Fri Jun 23 13:23:19 2017 ESAYM [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jun 23 13:23:19 2017 ESAYM [...] cpan.org - Fixed in 1.3201 added