Bug #122129 for GooCanvas2: Tests fail (GooCanvas2 -> Goo::Canvas2?)

Mon Jun 19 01:47:45 2017 SREZIC [...] cpan.org - Ticket created

Subject:

Tests fail (GooCanvas2 -> Goo::Canvas2?)

Tests fail with 0.04 and 0.05: PERL_DL_NONLAZY=1 "/opt/perl-5.22.3/bin/perl5.22.3" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Can't locate Goo/Canvas2.pm in @INC (you may need to install the Goo::Canvas2 module) (@INC contains: /home/cpansand/.cpan/build/2017061903/GooCanvas2-0.05-0/blib/lib /home/cpansand/.cpan/build/2017061903/GooCanvas2-0.05-0/blib/arch /home/cpansand/.cpan/build/2017061903/Prty-1.108-0/blib/arch /home/cpansand/.cpan/build/2017061903/Prty-1.108-0/blib/lib /home/cpansand/.cpan/build/2017061903/Prty-1.108-0/blib/arch /home/cpansand/.cpan/build/2017061903/Prty-1.108-0/blib/lib /opt/perl-5.22.3/lib/site_perl/5.22.3/x86_64-linux /opt/perl-5.22.3/lib/site_perl/5.22.3 /opt/perl-5.22.3/lib/5.22.3/x86_64-linux /opt/perl-5.22.3/lib/5.22.3 .) at t/GooCanvas2.t line 13. BEGIN failed--compilation aborted at t/GooCanvas2.t line 13. t/GooCanvas2.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 1/1 subtests For me it looks like GooCanvas2 has to be renamed to Goo::Canvas2. Also I think that you should delete the now-created top level namespace GooCanvas2 in the PAUSE interface.

Mon Jun 19 02:47:24 2017 PERLMAX [...] cpan.org - Correspondence added

On Mon Jun 19 01:47:45 2017, SREZIC wrote: Dear Slaven Rezic, Thank you very much for your bug report. I think, it is solved in the 0.06 version, which I just uploaded. Show quoted text

> For me it looks like GooCanvas2 has to be renamed to Goo::Canvas2.

Yes, this is right. I changed the name, because I didn't accomplish name corrections and Goo::Canvas2::Canvas looked for me very ugly. Show quoted text

> Also I think that you should delete the now-created top level > namespace GooCanvas2 in the PAUSE interface.

Sorry, I don't understand this? I am still a Newbie. Could you explain this in more detail? Why should I delete the toplevel namespace? Again, Thank you very very much! Max

Mon Jun 19 02:47:24 2017 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 19 03:01:12 2017 PERLMAX [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Jun 19 13:07:50 2017 SREZIC [...] cpan.org - Correspondence added

On 2017-06-19 02:47:24, PERLMAX wrote: Show quoted text

> On Mon Jun 19 01:47:45 2017, SREZIC wrote: > Dear Slaven Rezic, > Thank you very much for your bug report. I think, it is solved in the > 0.06 version, which I just uploaded. >

> > For me it looks like GooCanvas2 has to be renamed to Goo::Canvas2.

> > Yes, this is right. I changed the name, because I didn't accomplish > name corrections and Goo::Canvas2::Canvas looked for me very ugly.

This did not happen in 0.06, it seems. I still see GooCanvas2. I expect the module to be named Goo::Canvas2. Show quoted text

>

> > Also I think that you should delete the now-created top level > > namespace GooCanvas2 in the PAUSE interface.

> > Sorry, I don't understand this? I am still a Newbie. Could you explain > this in more detail? Why should I delete the toplevel namespace?

Once you renamed GooCanvas2 to Goo::Canvas2 there's an extra unneeded toplevel namespace.

Mon Jun 19 13:07:56 2017 SREZIC [...] cpan.org - Status changed from 'resolved' to 'open'

Mon Jun 19 14:31:11 2017 PERLMAX [...] cpan.org - Correspondence added

Show quoted text

> This did not happen in 0.06, it seems. I still see GooCanvas2. I > expect the module to be named Goo::Canvas2.

No, the module name should be GooCanvas2, because otherwise There are too much colons for my taste. The module creates several (sub)classes (Canvas, CanvasItem, CanvasRect) and for example Goo::Canvas2::CanvasRect or Goo::Canvas::Canvas etc.pp. doesn't please me. I don't think that this is a problem, or? Other modules have similar names consisting of two words (for example AnyEvent instead of Any::Event). There is a module of the old Goo::Canvas version for Gtk2. But there isn't the problem because the "subclasses" are directly rooted under Goo::Canvas (instead of Goo::Canvas::Canvas). As I said I couldn't accomplish name corrections and for maintaining reasons I don't want to make things too complicated. Show quoted text

> Once you renamed GooCanvas2 to Goo::Canvas2 there's an extra unneeded > toplevel namespace.

Ah, okay, I understand. But because I renamed the module already after version 0.01 and the first release on CPAN was 0.04 there is only one toplevel namespace (GooCanvas2). Nevertheless thank you very much for the hint...

Mon Jun 19 14:44:47 2017 SREZIC [...] cpan.org - Correspondence added

On 2017-06-19 14:31:11, PERLMAX wrote: Show quoted text

> > This did not happen in 0.06, it seems. I still see GooCanvas2. I > > expect the module to be named Goo::Canvas2.

> > No, the module name should be GooCanvas2, because otherwise There are > too much colons for my taste. The module creates several (sub)classes > (Canvas, CanvasItem, CanvasRect) and for example > Goo::Canvas2::CanvasRect or Goo::Canvas::Canvas etc.pp. doesn't please > me. I don't think that this is a problem, or? Other modules have > similar names consisting of two words (for example AnyEvent instead of > Any::Event). > There is a module of the old Goo::Canvas version for Gtk2. But there > isn't the problem because the "subclasses" are directly rooted under > Goo::Canvas (instead of Goo::Canvas::Canvas). As I said I couldn't > accomplish name corrections and for maintaining reasons I don't want > to make things too complicated.

I see. My impression was that it should be Goo::Canvas2 because Goo::Canvas already existed.

Mon Jun 19 14:44:52 2017 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'