Bug #122044 for Filter-Simple: With 0.92_01 installed, the testsuite of POWERMAN/Text-MiniTmpl-v2.0.0.tar.gz fails

Thu Jun 08 02:17:26 2017 ANDK [...] cpan.org - Ticket created

Subject:

With 0.92_01 installed, the testsuite of POWERMAN/Text-MiniTmpl-v2.0.0.tar.gz fails

As per subject. It's the t/filter.t test that fails now with: Missing right curly or square bracket at ./t/tmpl/filter.txt line 4, at end of line syntax error at ./t/tmpl/filter.txt line 4, at EOF at t/filter.t line 9. # Looks like your test exited with 2 before it could output anything. t/filter.t ................ Dubious, test returned 2 (wstat 512, 0x200) Failed 1/1 subtests I just reproduced this with perl 5.22.3 and 5.24.1. Both had a working Text::MiniTmpl with Simple::Filter 0.92. Thanks,

Thu Jun 08 13:54:29 2017 ANDK [...] cpan.org - Correspondence added

RT-Send-CC:

corion [...] cpan.org

I just reproduced this also with a perl 5.26.0 which had Filter::Simple 0.93 and a working Text-MiniTmpl-v2.0.0. I downgraded this to CORION/Filter-Simple-0.92_01.tar.gz and then tested again POWERMAN/Text-MiniTmpl-v2.0.0.tar.gz and it failed the test with the same diagnostics as described above.

Thu Jun 08 14:16:14 2017 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Thu Jun 08 13:54:29 2017, ANDK wrote: Show quoted text

> I just reproduced this also with a perl 5.26.0 which had > Filter::Simple 0.93 and a working Text-MiniTmpl-v2.0.0. I downgraded > this to CORION/Filter-Simple-0.92_01.tar.gz and then tested again > POWERMAN/Text-MiniTmpl-v2.0.0.tar.gz and it failed the test with the > same diagnostics as described above.

Are you saying that 0.93 is working fine and that we just need a new CPAN release?

Thu Jun 08 14:16:14 2017 The RT System itself - Status changed from 'new' to 'open'

Thu Jun 08 14:34:36 2017 ANDK [...] cpan.org - Correspondence added

I fear it's more complicated. In the last year failing reports have increased. There seems to be some other disturbing influence that can cause fails on raise.t, smoke.t, errline.t, unicode.t, caller.t.

Thu Jun 08 15:34:56 2017 corion [...] cpan.org - Correspondence added

Thanks for reporting this bug. Filter::Simple 0.92_1 is my beta "release" that fixes the line numbers for here-documents, but it seems while implementing that I broke something that Text::MiniTmpl relies on. It uses one interesting trick to apply source filters to arbitrary code, namely do() instead of eval(). I guess that this is at least part of the puzzle because I can reproduce the failure on Windows with Filter::Simple 0.92_1, but not with 0.91. But that feature in isolation is not enough so I have to investigate further what causes that breakage. open my $fhe, '<', \$template or die "open: $!"; local @INC = ( sub {shift @INC; $fhe}, @INC ); my $code = do '[eval]'; -max

Wed Jun 21 15:49:14 2017 corion [...] cpan.org - Correspondence added

Hello Andreas, thank you very much for reporting this bug. The bug was an error in Filter::Simple, which did not process the last line of filter input if the last line did not end with a newline. I've added a new test that tests for that situation and released 0.93_01 to CPAN. Hopefully the smoke test works out with that version.