Bug #122019 for DBD-Pg: v3.6.2 not compiled under strawberry perl 5.26 x64

Tue Jun 06 00:49:16 2017 ZDM [...] cpan.org - Ticket created

Subject:

v3.6.2 not compiled under strawberry perl 5.26 x64

run cpanm for perl v5.26.0 MSWin32-x64-multi-thread: cpanm (App::cpanminus) 1.7043 on perl 5.026000 built for MSWin32-x64-multi-thread Work directory is C:\Users\zdm\AppData\Local\Temp\.cpanm/work/1496721686.9988 You have make D:\devel\perl\c\bin\gmake.exe You have LWP 6.26 You have D:\devel\msys2\usr\bin\tar.exe, D:\devel\msys2\usr\bin\gzip.exe and D:\devel\msys2\usr\bin\bzip2.exe Searching DBD::Pg () on metacpan ... --> Working on DBD::Pg Fetching https://cpan.metacpan.org/authors/id/T/TU/TURNSTEP/DBD-Pg-3.6.2.tar.gz ... OK Unpacking DBD-Pg-3.6.2.tar.gz DBD-Pg-3.6.2/ DBD-Pg-3.6.2/MANIFEST DBD-Pg-3.6.2/quote.c DBD-Pg-3.6.2/dbivport.h DBD-Pg-3.6.2/README.win32 DBD-Pg-3.6.2/Makefile.PL DBD-Pg-3.6.2/Pg.xs DBD-Pg-3.6.2/types.h DBD-Pg-3.6.2/t/ DBD-Pg-3.6.2/t/dbdpg_test_setup.pl DBD-Pg-3.6.2/t/01connect.t DBD-Pg-3.6.2/t/06bytea.t DBD-Pg-3.6.2/t/00basic.t DBD-Pg-3.6.2/t/99cleanup.t DBD-Pg-3.6.2/t/02attribs.t DBD-Pg-3.6.2/t/03dbmethod.t DBD-Pg-3.6.2/t/lib/ DBD-Pg-3.6.2/t/lib/App/ DBD-Pg-3.6.2/t/lib/App/Info.pm DBD-Pg-3.6.2/t/lib/App/Info/ DBD-Pg-3.6.2/t/lib/App/Info/Handler.pm DBD-Pg-3.6.2/t/lib/App/Info/Request.pm DBD-Pg-3.6.2/t/lib/App/Info/RDBMS/ DBD-Pg-3.6.2/t/lib/App/Info/RDBMS/PostgreSQL.pm DBD-Pg-3.6.2/t/lib/App/Info/RDBMS.pm DBD-Pg-3.6.2/t/lib/App/Info/Handler/ DBD-Pg-3.6.2/t/lib/App/Info/Handler/Print.pm DBD-Pg-3.6.2/t/lib/App/Info/Handler/Prompt.pm DBD-Pg-3.6.2/t/lib/App/Info/Util.pm DBD-Pg-3.6.2/t/08async.t DBD-Pg-3.6.2/t/30unicode.t DBD-Pg-3.6.2/t/04misc.t DBD-Pg-3.6.2/t/12placeholders.t DBD-Pg-3.6.2/t/01constants.t DBD-Pg-3.6.2/t/00_signature.t DBD-Pg-3.6.2/t/09arrays.t DBD-Pg-3.6.2/t/07copy.t DBD-Pg-3.6.2/t/20savepoints.t DBD-Pg-3.6.2/t/03smethod.t DBD-Pg-3.6.2/LICENSES/ DBD-Pg-3.6.2/LICENSES/artistic.txt DBD-Pg-3.6.2/LICENSES/gpl-2.0.txt DBD-Pg-3.6.2/testme.tmp.pl DBD-Pg-3.6.2/win32.mak DBD-Pg-3.6.2/dbdimp.c DBD-Pg-3.6.2/types.c DBD-Pg-3.6.2/TODO DBD-Pg-3.6.2/lib/ DBD-Pg-3.6.2/lib/Bundle/ DBD-Pg-3.6.2/lib/Bundle/DBD/ DBD-Pg-3.6.2/lib/Bundle/DBD/Pg.pm DBD-Pg-3.6.2/Pg.pm DBD-Pg-3.6.2/META.yml DBD-Pg-3.6.2/Changes DBD-Pg-3.6.2/README.dev DBD-Pg-3.6.2/README DBD-Pg-3.6.2/Pg.h DBD-Pg-3.6.2/dbdimp.h DBD-Pg-3.6.2/.perlcriticrc DBD-Pg-3.6.2/MANIFEST.SKIP DBD-Pg-3.6.2/SIGNATURE DBD-Pg-3.6.2/quote.h Entering DBD-Pg-3.6.2 Checking configure dependencies from META.yml Checking if you have DBI 1.614 ... Yes (1.636) Checking if you have version 0 ... Yes (0.9918) Running Makefile.PL Configuring DBD-Pg-3.6.2 ... Configuring DBD::Pg 3.6.2 PostgreSQL version: 90603 (default port: 5432) POSTGRES_HOME: (not set) POSTGRES_INCLUDE: D:/devel/perl/c/include POSTGRES_LIB: D:/devel/perl/c/lib OS: MSWin32 Checking if your kit is complete... Looks good Using DBI 1.636 (for perl 5.026000 on MSWin32-x64-multi-thread) installed in d:/devel/perl/perl/vendor/lib/auto/DBI/ Generating a gmake-style Makefile Writing Makefile for DBD::Pg Writing MYMETA.yml and MYMETA.json OK Checking dependencies from MYMETA.json ... Checking if you have DBI 1.614 ... Yes (1.636) Checking if you have version 0 ... Yes (0.9918) Checking if you have Test::More 0.88 ... Yes (1.302085) Checking if you have ExtUtils::MakeMaker 6.11 ... Yes (7.28) Checking if you have Time::HiRes 0 ... Yes (1.9742) Building and testing DBD-Pg-3.6.2 ... cp lib/Bundle/DBD/Pg.pm blib\lib/Bundle/DBD/Pg.pm cp Pg.pm blib\lib\DBD/Pg.pm Running Mkbootstrap for Pg () "D:\devel\perl\perl\bin\perl.exe" -MExtUtils::Command -e chmod -- 644 "Pg.bs" "D:\devel\perl\perl\bin\perl.exe" -MExtUtils::Command::MM -e cp_nonempty -- Pg.bs blib\arch\auto\DBD\Pg\Pg.bs 644 "D:\devel\perl\perl\bin\perl.exe" -p -e "s/~DRIVER~/Pg/g; s/^do\(/dontdo\(/" D:\devel\perl\perl\vendor\lib\auto\DBI\Driver.xst > Pg.xsi "D:\devel\perl\perl\bin\perl.exe" "D:\devel\perl\perl\lib\ExtUtils/xsubpp" -typemap D:\devel\perl\perl\lib\ExtUtils\typemap Pg.xs > Pg.xsc "D:\devel\perl\perl\bin\perl.exe" -MExtUtils::Command -e mv -- Pg.xsc Pg.c gcc -c -I"D:/devel/perl/c/include" -ID:\devel\perl\perl\vendor\lib\auto\DBI -s -O2 -DWIN32 -DWIN64 -DCONSERVATIVE -D__USE_MINGW_ANSI_STDIO -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -fwrapv -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=90603 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.6.2\" -DXS_VERSION=\"3.6.2\" "-ID:\devel\perl\perl\lib\CORE" Pg.c gcc -c -I"D:/devel/perl/c/include" -ID:\devel\perl\perl\vendor\lib\auto\DBI -s -O2 -DWIN32 -DWIN64 -DCONSERVATIVE -D__USE_MINGW_ANSI_STDIO -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -fwrapv -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=90603 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.6.2\" -DXS_VERSION=\"3.6.2\" "-ID:\devel\perl\perl\lib\CORE" dbdimp.c gcc -c -I"D:/devel/perl/c/include" -ID:\devel\perl\perl\vendor\lib\auto\DBI -s -O2 -DWIN32 -DWIN64 -DCONSERVATIVE -D__USE_MINGW_ANSI_STDIO -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -fwrapv -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=90603 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.6.2\" -DXS_VERSION=\"3.6.2\" "-ID:\devel\perl\perl\lib\CORE" quote.c gcc -c -I"D:/devel/perl/c/include" -ID:\devel\perl\perl\vendor\lib\auto\DBI -s -O2 -DWIN32 -DWIN64 -DCONSERVATIVE -D__USE_MINGW_ANSI_STDIO -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -fwrapv -fno-strict-aliasing -mms-bitfields -DPGLIBVERSION=90603 -DPGDEFPORT=5432 -s -O2 -DVERSION=\"3.6.2\" -DXS_VERSION=\"3.6.2\" "-ID:\devel\perl\perl\lib\CORE" types.c "D:\devel\perl\perl\bin\perl.exe" -MExtUtils::Mksymlists \ -e "Mksymlists('NAME'=>\"DBD::Pg\", 'DLBASE' => 'Pg', 'DL_FUNCS' => { }, 'FUNCLIST' => [], 'IMPORTS' => { }, 'DL_VARS' => []);" g++.exe Pg.def -o blib\arch\auto\DBD\Pg\Pg.xs.dll -mdll -s -L"D:\devel\perl\perl\lib\CORE" -L"D:\devel\perl\c\lib" Pg.o dbdimp.o quote.o types.o "D:\devel\perl\perl\lib\CORE\libperl526.a" "D:\devel\perl\c\lib\libpq.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libm.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libsecur32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libmoldname.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libkernel32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libuser32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libgdi32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libwinspool.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libcomdlg32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libadvapi32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libshell32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libole32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\liboleaut32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libnetapi32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libuuid.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libws2_32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libmpr.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libwinmm.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libversion.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libodbc32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libodbccp32.a" "D:\devel\perl\c\x86_64-w64-mingw32\lib\libcomctl32.a" -Wl,--enable-auto-image-base quote.o:quote.c:(.text+0x63d): undefined reference to `__imp__snprintf.constprop.4' collect2.exe: error: ld returned 1 exit status gmake: *** [Makefile:496: blib\arch\auto\DBD\Pg\Pg.xs.dll] Error 1 FAIL ! Installing DBD::Pg failed. See C:\Users\zdm\AppData\Local\Temp\.cpanm\work\1496721686.9988\build.log for details. Retry with --force to force install it.

Thu Jul 20 01:46:18 2017 kmx [...] cpan.org - Correspondence added

You need the following patch

diff -ru DBD-Pg-3.6.0/Pg.h DBD-Pg-3.6.0_patched/Pg.h
--- DBD-Pg-3.6.0/Pg.h 2017-03-29 00:03:37.000000000 +0200
+++ DBD-Pg-3.6.0_patched/Pg.h 2017-05-12 13:59:09.337883200 +0200
@@ -14,9 +14,11 @@
 static int errno;
 #include <string.h>
 #define strcasecmp(s1,s2) stricmp((s1), (s2))
+#ifndef __USE_MINGW_ANSI_STDIO
 #ifndef snprintf
 #define snprintf _snprintf
 #endif
+#endif
 #else
 #include <strings.h>
 #endif

Thu Jul 20 01:46:19 2017 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 20 01:48:05 2017 dzagashev [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122019] v3.6.2 not compiled under strawberry perl 5.26 x64
Date:	Thu, 20 Jul 2017 08:47:39 +0300
To:	bug-DBD-Pg [...] rt.cpan.org
From:	"dzagashev [...] gmail.com" <dzagashev [...] gmail.com>

I will try, thank you. On 20.07.2017 08:46, kmx via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122019 > > > You need the following patch > > diff -ru DBD-Pg-3.6.0/Pg.h DBD-Pg-3.6.0_patched/Pg.h > --- DBD-Pg-3.6.0/Pg.h 2017-03-29 00:03:37.000000000 +0200 > +++ DBD-Pg-3.6.0_patched/Pg.h 2017-05-12 13:59:09.337883200 +0200 > @@ -14,9 +14,11 @@ > static int errno; > #include <string.h> > #define strcasecmp(s1,s2) stricmp((s1), (s2)) > +#ifndef __USE_MINGW_ANSI_STDIO > #ifndef snprintf > #define snprintf _snprintf > #endif > +#endif > #else > #include <strings.h> > #endif >

Sun Feb 04 10:19:02 2018 greg [...] turnstep.com - Correspondence added

Show quoted text

> +#ifndef __USE_MINGW_ANSI_STDIO

I don't think this will work, as we already have a #ifdef WIN32 that provides the snprintf mapping. As with a similar recent bug, the problem appears in quote.c, so adding this to quote.h may help: #ifdef WIN32 #ifndef snprintf #define snprintf _snprintf #endif #endif

Sun Feb 04 10:19:03 2018 greg [...] turnstep.com - Taken

Sun Feb 04 15:10:52 2018 dzagashev [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122019] v3.6.2 not compiled under strawberry perl 5.26 x64
Date:	Sun, 4 Feb 2018 22:10:30 +0200
To:	bug-DBD-Pg [...] rt.cpan.org
From:	"dzagashev [...] gmail.com" <dzagashev [...] gmail.com>

Hi, this patch works. I use it. On 04.02.2018 17:19, Greg Sabino Mullane via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122019 > >

>> +#ifndef __USE_MINGW_ANSI_STDIO

> > I don't think this will work, as we already have a #ifdef WIN32 that provides the snprintf mapping. As with a similar recent bug, the problem appears in quote.c, so adding this to quote.h may help: > > #ifdef WIN32 > #ifndef snprintf > #define snprintf _snprintf > #endif > #endif >

Sun Feb 04 16:56:10 2018 greg [...] turnstep.com - Correspondence added

On Sun Feb 04 15:10:52 2018, dzagashev@gmail.com wrote: Show quoted text

> Hi, this patch works. > I use it.

Excellent, thank you for the quick reply.

Sun Feb 04 16:56:11 2018 greg [...] turnstep.com - Status changed from 'open' to 'patched'

Mon Feb 12 22:53:43 2018 greg [...] turnstep.com - Status changed from 'patched' to 'resolved'

Mon Feb 12 22:53:43 2018 greg [...] turnstep.com - Fixed in 3.7.1 added

Tue Feb 13 17:33:56 2018 dzagashev [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #122019] Resolved: v3.6.2 not compiled under strawberry perl 5.26 x64
Date:	Wed, 14 Feb 2018 00:33:40 +0200
To:	bug-DBD-Pg [...] rt.cpan.org
From:	"dzagashev [...] gmail.com" <dzagashev [...] gmail.com>

Hi, are you sure, that this issue is closed? I don;t see any significant changes in the source code. On 13.02.2018 05:53, Greg Sabino Mullane via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=122019 > > > According to our records, your request has been resolved. If you have any > further questions or concerns, please respond to this message. >