Bug #121794 for Perl-ImportReport: perlcritic.t may die even with tests skipped

Sat May 20 02:21:15 2017 CHORNY [...] cpan.org - Ticket created

Subject:

perlcritic.t may die even with tests skipped

If error appears in the END block, it will lead to failure even if tests are skipped after loading Test::Perl::Critic. See for ex. http://www.cpantesters.org/cpan/report/606aa06d-6c1b-1014-b32f-3adcd52a00bf Solution is to skip based on $ENV{'do_perl_critic_tests'} before trying lo load Test::Perl::Critic. It also will be faster. -- Alexandr Ciornii, http://chorny.net

Sat May 20 22:46:46 2017 ether [...] cpan.org - Correspondence added

On 2017-05-19 23:21:15, CHORNY wrote: Show quoted text

> If error appears in the END block, it will lead to failure even if > tests are skipped after loading Test::Perl::Critic. See for ex. > http://www.cpantesters.org/cpan/report/606aa06d-6c1b-1014-b32f- > 3adcd52a00bf > > Solution is to skip based on $ENV{'do_perl_critic_tests'} before > trying lo load Test::Perl::Critic. It also will be faster.

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Sat May 20 22:46:46 2017 The RT System itself - Status changed from 'new' to 'open'

Wed May 24 09:03:41 2017 dmuey [...] cpan.org - Correspondence added

Show quoted text

> Either move these tests to xt/, or guard them with: > > plan skip_all => "These tests are for authors only!" unless > $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

thanks, will do. I use RELEASE_TESTING in new code this is just old :)