Skip Menu |

This queue is for tickets about the Pod-Perldoc CPAN distribution.

Report information
The Basics
Id: 121771
Status: resolved
Priority: 0/
Queue: Pod-Perldoc

People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Invalid identifier "$Pod::Perldoc::VERSION" in t/00_load.t
cperl5.27.1 with strict names detected the following minor bug: my $version = do { no strict 'refs'; ${ '$' . $class . '::VERSION' } }; The symbol name needs to be without the $ -- Reini Urban
Subject: 0001-Pod-Perldoc-fix-t-00_load.t.patch
From 4baef2011c19453a9087856abae07b7f9bbe1a66 Mon Sep 17 00:00:00 2001 From: Reini Urban <rurban@cpan.org> Date: Thu, 18 May 2017 12:52:56 +0200 Subject: [PATCH] Pod-Perldoc: fix t/00_load.t Invalid identifier "$Pod::Perldoc::VERSION" while "strict names" in use at t/00_load.t line 21. detected by cperl 5.27.1 --- cpan/Pod-Perldoc/t/00_load.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git cpan/Pod-Perldoc/t/00_load.t cpan/Pod-Perldoc/t/00_load.t index 936f8a4..662f9d5 100644 --- cpan/Pod-Perldoc/t/00_load.t +++ cpan/Pod-Perldoc/t/00_load.t @@ -18,6 +18,6 @@ plan tests => scalar @classes; foreach my $class ( @classes ) { require_ok( $class ); - my $version = do { no strict 'refs'; ${ '$' . $class . '::VERSION' } }; + my $version = do { no strict 'refs'; ${ $class . '::VERSION' } }; note( "$class $version" ) if defined $version } -- 2.8.4 (Apple Git-73)
On Thu May 18 07:01:59 2017, RURBAN wrote: Show quoted text
> The symbol name needs to be without the $
Thanks for the patch! Applied as aa2babc76b1bd78ee44c9374e2d205062e861843 on github