Skip Menu |

This queue is for tickets about the Test-Mock-LWP CPAN distribution.

Report information
The Basics
Id: 121706
Status: resolved
Worked: 3 min
Priority: 0/
Queue: Test-Mock-LWP

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.08
Fixed in: 0.08



Subject: Makefile.PL fails on Perl without "." in @INC
Perl 5.26.0 removes "." from @INC and Makefile.PL fails: $ perl Makefile.PL Can't locate inc/Module/Install.pm in @INC (you may need to install the inc::Module::Install module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at Makefile.PL line 4. BEGIN failed--compilation aborted at Makefile.PL line 4. A fix is attached. Another solution is not to use inc::Module::Install all declare it as a configure-time dependency.
Subject: Test-Mock-LWP-0.08-Fix-building-on-Perl-without-.-in-INC.patch
From 8f2f1cd4a2999d6b3b611e64681129b0ce19c9e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 16 May 2017 14:36:11 +0200 Subject: [PATCH] Fix building on Perl without "." in @INC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.PL b/Makefile.PL index 66617a4..b798bbe 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,6 +1,7 @@ #!/usr/bin/perl -w use warnings; use strict; +BEGIN { push @INC, '.'; } use inc::Module::Install; name 'Test-Mock-LWP'; -- 2.9.4
On 2017-05-16 05:39:43, ppisar wrote: Show quoted text
> Another solution is not to use inc::Module::Install all declare it as > a configure-time dependency.
NO PLEASE DO NOT add anything to do with Module::Install into configure-requires. Best is to shift off of MI entirely.
On Tue May 16 11:11:28 2017, ETHER wrote: Show quoted text
> On 2017-05-16 05:39:43, ppisar wrote: >
> > Another solution is not to use inc::Module::Install all declare it as > > a configure-time dependency.
> > NO PLEASE DO NOT add anything to do with Module::Install into > configure-requires. > > Best is to shift off of MI entirely.
PR https://github.com/lukec/cpan-test-mock-lwp/pull/3 hacks Makefile.PL to add '.' to @INC for the duration of its execution. This gets us over the hump until Module::Install can be removed.
The 0.08 Makefile.PL has the supplied fix; thanks!