Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 121629
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri May 12 03:59:26 2017 ether [...] cpan.org - Ticket created
Subject: new kwalitee metric: version in META.* does not match the version of the "main" module
similar to RT#116787 ("new kwalitee metric: distribution name does not match a module in the distribution"), it would be helpful (e.g. for ToddR's prototype CPAN archiver/grepper) to know which distributions declare a different version in the META file than the $VERSION of the "main" module (the module whose name matches the distribution name). Ideally we would like to fix all such broken distributions, and add a rule (in PAUSE?) to enforce this restriction in the future.
  Fri May 12 04:28:57 2017 ishigaki [...] cpan.org - Correspondence added
On Fri May 12 16:59:26 2017, ETHER wrote: Show quoted text
> similar to RT#116787 ("new kwalitee metric: distribution name does not > match a module in the distribution"), it would be helpful (e.g. for > ToddR's prototype CPAN archiver/grepper) to know which distributions > declare a different version in the META file than the $VERSION of the > "main" module (the module whose name matches the distribution name). > > Ideally we would like to fix all such broken distributions, and add a > rule (in PAUSE?) to enforce this restriction in the future.
It looks like this is not a new metric, but an improvement of the existing package_version_matches_dist_version metric, to make it only pass when the dist version matches the main module's version, instead of any of module versions in the distribution, correct?
  Fri May 12 04:28:58 2017 The RT System itself - Status changed from 'new' to 'open'
  Fri May 12 05:27:50 2017 ether [...] cpan.org - Severity Wishlist added
  Fri May 12 09:19:48 2017 ether [...] cpan.org - Correspondence added
On 2017-05-12 01:28:57, ISHIGAKI wrote: Show quoted text
> It looks like this is not a new metric, but an improvement of the > existing package_version_matches_dist_version metric, to make it only > pass when the dist version matches the main module's version, instead > of any of module versions in the distribution, correct?
Oops, I forgot about that existing metric! Yes, I think it would be more correct to require that the main module's version matches. We could make a new metric to check if any of the versions in the distribution are out of sync with each other, but it's more important that the main module's version matches the distributions (many people like to leave all the other versions undefined).
  Sat May 13 08:31:41 2017 ishigaki [...] cpan.org - Correspondence added
On Fri May 12 22:19:48 2017, ETHER wrote: Show quoted text
> On 2017-05-12 01:28:57, ISHIGAKI wrote: >
> > It looks like this is not a new metric, but an improvement of the > > existing package_version_matches_dist_version metric, to make it only > > pass when the dist version matches the main module's version, instead > > of any of module versions in the distribution, correct?
> > Oops, I forgot about that existing metric! Yes, I think it would be > more correct to require that the main module's version matches. We > could make a new metric to check if any of the versions in the > distribution are out of sync with each other, but it's more important > that the main module's version matches the distributions (many people > like to leave all the other versions undefined).
Implemented with https://github.com/cpants/Module-CPANTS-SiteKwalitee/commit/371e289b8896e40141a0d1382f941a770d45aec5 and the result is: https://cpants.cpanauthors.org/kwalitee/main_module_version_matches_dist_version Thanks for the input.
  Sat May 13 08:31:42 2017 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'