Bug #121538 for Net-SSLeay: Runtime failure in version 1.81 when OpenSSL was not built with Engine support

Fri May 05 16:06:19 2017 Paul.Green [...] stratus.com - Ticket created

CC:	"Farley, Paul" <Paul.Farley [...] stratus.com>, "Green, Paul" <Paul.Green [...] stratus.com>
Subject:	Runtime failure in version 1.81 when OpenSSL was not built with Engine support
Date:	Fri, 5 May 2017 19:58:57 +0000
To:	"bug-Net-SSLeay [...] rt.cpan.org" <bug-Net-SSLeay [...] rt.cpan.org>
From:	"Green, Paul" <Paul.Green [...] stratus.com>

Gentle Net::SSLeay maintainers, I previously a related bug (#120330) back on February 22 of this year, which you kindly fixed on March 1, and released in Net::SSLeay version 1.81. Many thanks. That cleared up the first issue. Now I have run into the next problem, which is that the code is still referencing ENGINE-related functions at runtime. Our standard version of OpenSSL doesn't include Engine support, so that's a problem. Not sure how I missed this back in February. This change should have no effect on any current users of Net::SSLeay because up until this point, the package assumed that ENGINE support was always present. All my two patches do is to enable people who do not have ENGINE support in their OpenSSL to still use Net::SSLeay. Here is the patch to version 1.81 to resolve this issue. diff -ur Net-SSLeay-1.81-0/SSLeay.xs Net-SSLeay-1.81-1/SSLeay.xs --- Net-SSLeay-1.81-0/SSLeay.xs 2017-05-05 15:53:43 -0400 +++ Net-SSLeay-1.81-1/SSLeay.xs 2017-05-05 15:55:26 -0400 @@ -50,6 +50,7 @@ * 1/ SSleay.xs is expected to build/pass test suite * - with openssl 0.9.6 and newer versions * - with perl 5.8 and newer versions + * - with or without ENGINE support * * 2/ Fix all compiler warnings - we expect 100% clean build * @@ -2393,6 +2394,7 @@ RETVAL #if OPENSSL_VERSION_NUMBER >= 0x0090700fL +#ifndef OPENSSL_NO_ENGINE #define REM5 "NOTE: requires 0.9.7+" void @@ -2410,6 +2412,7 @@ ENGINE * e int flags +#endif /* OPENSSL_NO_ENGINE */ #endif /* OPENSSL_VERSION_NUMBER >= 0x0090700fL */ void ** end patch ** You may mark my previous bug, #120330 as resolved by version 1.81. That change was correct, just not complete enough. Thanks PG -- Sr. Technical Consultant, Stratus Technologies, Inc. Maynard, MA 01754-1482

Fri May 05 17:57:33 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #121538] Runtime failure in version 1.81 when OpenSSL was not built with Engine support
Date:	Fri, 5 May 2017 22:08:58 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Thanks. I won't get a chance to assess your patch for a few weeks Cheers Sent from my iPhone Show quoted text

> On 5 May 2017, at 9:06 pm, Paul Green via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Fri May 05 16:06:19 2017: Request 121538 was acted upon. > Transaction: Ticket created by Paul.Green@stratus.com > Queue: Net-SSLeay > Subject: Runtime failure in version 1.81 when OpenSSL was not built with Engine support > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: Paul.Green@stratus.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121538 > > > > Gentle Net::SSLeay maintainers, > > I previously a related bug (#120330) back on February 22 of this year, which you kindly fixed on March 1, and released in Net::SSLeay version 1.81. Many thanks. That cleared up the first issue. Now I have run into the next problem, which is that the code is still referencing ENGINE-related functions at runtime. Our standard version of OpenSSL doesn't include Engine support, so that's a problem. Not sure how I missed this back in February. > > This change should have no effect on any current users of Net::SSLeay because up until this point, the package assumed that ENGINE support was always present. All my two patches do is to enable people who do not have ENGINE support in their OpenSSL to still use Net::SSLeay. > > Here is the patch to version 1.81 to resolve this issue. > > diff -ur Net-SSLeay-1.81-0/SSLeay.xs Net-SSLeay-1.81-1/SSLeay.xs > --- Net-SSLeay-1.81-0/SSLeay.xs 2017-05-05 15:53:43 -0400 > +++ Net-SSLeay-1.81-1/SSLeay.xs 2017-05-05 15:55:26 -0400 > @@ -50,6 +50,7 @@ > * 1/ SSleay.xs is expected to build/pass test suite > * - with openssl 0.9.6 and newer versions > * - with perl 5.8 and newer versions > + * - with or without ENGINE support > * > * 2/ Fix all compiler warnings - we expect 100% clean build > * > @@ -2393,6 +2394,7 @@ > RETVAL > > #if OPENSSL_VERSION_NUMBER >= 0x0090700fL > +#ifndef OPENSSL_NO_ENGINE > #define REM5 "NOTE: requires 0.9.7+" > > void > @@ -2410,6 +2412,7 @@ > ENGINE * e > int flags > > +#endif /* OPENSSL_NO_ENGINE */ > #endif /* OPENSSL_VERSION_NUMBER >= 0x0090700fL */ > > void > > ** end patch ** > > You may mark my previous bug, #120330 as resolved by version 1.81. That change was correct, just not complete enough. > > Thanks > PG > -- > Sr. Technical Consultant, Stratus Technologies, Inc. > Maynard, MA 01754-1482

Fri May 05 17:57:34 2017 The RT System itself - Status changed from 'new' to 'open'

Mon May 08 09:31:20 2017 Paul.Green [...] stratus.com - Correspondence added

Subject:	RE: [rt.cpan.org #121538] Runtime failure in version 1.81 when OpenSSL was not built with Engine support
Date:	Mon, 8 May 2017 13:29:42 +0000
To:	"bug-Net-SSLeay [...] rt.cpan.org" <bug-Net-SSLeay [...] rt.cpan.org>
From:	"Green, Paul" <Paul.Green [...] stratus.com>

That’s not a problem. I’ve given my customer an avoidance. PG From: Mike McCauley via RT [mailto:bug-Net-SSLeay@rt.cpan.org] Sent: Friday, May 05, 2017 5:58 PM To: Green, Paul <Paul.Green@stratus.com> Subject: Re: [rt.cpan.org #121538] Runtime failure in version 1.81 when OpenSSL was not built with Engine support <URL: https://rt.cpan.org/Ticket/Display.html?id=121538<https://rt.cpan.org/Ticket/Display.html?id=121538> > Thanks. I won't get a chance to assess your patch for a few weeks Cheers Sent from my iPhone Show quoted text

> On 5 May 2017, at 9:06 pm, Paul Green via RT <bug-Net-SSLeay@rt.cpan.org<mailto:bug-Net-SSLeay@rt.cpan.org>> wrote: > > Fri May 05 16:06:19 2017: Request 121538 was acted upon. > Transaction: Ticket created by Paul.Green@stratus.com<mailto:Paul.Green@stratus.com> > Queue: Net-SSLeay > Subject: Runtime failure in version 1.81 when OpenSSL was not built with Engine support > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: Paul.Green@stratus.com<mailto:Paul.Green@stratus.com> > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121538<https://rt.cpan.org/Ticket/Display.html?id=121538> > > > > Gentle Net::SSLeay maintainers, > > I previously a related bug (#120330) back on February 22 of this year, which you kindly fixed on March 1, and released in Net::SSLeay version 1.81. Many thanks. That cleared up the first issue. Now I have run into the next problem, which is that the code is still referencing ENGINE-related functions at runtime. Our standard version of OpenSSL doesn't include Engine support, so that's a problem. Not sure how I missed this back in February. > > This change should have no effect on any current users of Net::SSLeay because up until this point, the package assumed that ENGINE support was always present. All my two patches do is to enable people who do not have ENGINE support in their OpenSSL to still use Net::SSLeay. > > Here is the patch to version 1.81 to resolve this issue. > > diff -ur Net-SSLeay-1.81-0/SSLeay.xs Net-SSLeay-1.81-1/SSLeay.xs > --- Net-SSLeay-1.81-0/SSLeay.xs 2017-05-05 15:53:43 -0400 > +++ Net-SSLeay-1.81-1/SSLeay.xs 2017-05-05 15:55:26 -0400 > @@ -50,6 +50,7 @@ > * 1/ SSleay.xs is expected to build/pass test suite > * - with openssl 0.9.6 and newer versions > * - with perl 5.8 and newer versions > + * - with or without ENGINE support > * > * 2/ Fix all compiler warnings - we expect 100% clean build > * > @@ -2393,6 +2394,7 @@ > RETVAL > > #if OPENSSL_VERSION_NUMBER >= 0x0090700fL > +#ifndef OPENSSL_NO_ENGINE > #define REM5 "NOTE: requires 0.9.7+" > > void > @@ -2410,6 +2412,7 @@ > ENGINE * e > int flags > > +#endif /* OPENSSL_NO_ENGINE */ > #endif /* OPENSSL_VERSION_NUMBER >= 0x0090700fL */ > > void > > ** end patch ** > > You may mark my previous bug, #120330 as resolved by version 1.81. That change was correct, just not complete enough. > > Thanks > PG > -- > Sr. Technical Consultant, Stratus Technologies, Inc. > Maynard, MA 01754-1482

Fri Jul 27 13:28:37 2018 chrisn [...] cpan.org - Correspondence added

RT-Send-CC:

Paul.Farley [...] stratus.com

On Fri May 05 21:06:19 2017, Paul.Green@stratus.com wrote: Show quoted text

> Gentle Net::SSLeay maintainers, > > I previously a related bug (#120330) back on February 22 of this year, > which you kindly fixed on March 1, and released in Net::SSLeay version > 1.81. Many thanks. That cleared up the first issue. Now I have run > into the next problem, which is that the code is still referencing > ENGINE-related functions at runtime. Our standard version of OpenSSL > doesn't include Engine support, so that's a problem. Not sure how I > missed this back in February. > > This change should have no effect on any current users of Net::SSLeay > because up until this point, the package assumed that ENGINE support > was always present. All my two patches do is to enable people who do > not have ENGINE support in their OpenSSL to still use Net::SSLeay. > > Here is the patch to version 1.81 to resolve this issue. > > diff -ur Net-SSLeay-1.81-0/SSLeay.xs Net-SSLeay-1.81-1/SSLeay.xs > --- Net-SSLeay-1.81-0/SSLeay.xs 2017-05-05 15:53:43 -0400 > +++ Net-SSLeay-1.81-1/SSLeay.xs 2017-05-05 15:55:26 -0400 > @@ -50,6 +50,7 @@ > * 1/ SSleay.xs is expected to build/pass test suite > * - with openssl 0.9.6 and newer versions > * - with perl 5.8 and newer versions > + * - with or without ENGINE support > * > * 2/ Fix all compiler warnings - we expect 100% clean build > * > @@ -2393,6 +2394,7 @@ > RETVAL > > #if OPENSSL_VERSION_NUMBER >= 0x0090700fL > +#ifndef OPENSSL_NO_ENGINE > #define REM5 "NOTE: requires 0.9.7+" > > void > @@ -2410,6 +2412,7 @@ > ENGINE * e > int flags > > +#endif /* OPENSSL_NO_ENGINE */ > #endif /* OPENSSL_VERSION_NUMBER >= 0x0090700fL */ > > void > > ** end patch **

Thanks, Paul - patch applied, with minor modifications to document the potential unavailability of the ENGINE_* functions and to credit you for the patch in the Changes file: https://github.com/radiator-software/p5-net-ssleay/pull/16 This will be included in the next developer release (1.86_04) and the next stable release after that.

Fri Jul 27 13:28:39 2018 chrisn [...] cpan.org - Status changed from 'open' to 'patched'

Fri Jul 27 13:28:39 2018 chrisn [...] cpan.org - Taken

Mon Jul 30 19:33:32 2018 chrisn [...] cpan.org - Status changed from 'patched' to 'resolved'

Mon Jul 30 19:33:32 2018 chrisn [...] cpan.org - Fixed in 1.86_04 added