Skip Menu |

This queue is for tickets about the Moo-Google CPAN distribution.

Report information
The Basics
Id: 121515
Status: open
Priority: 0/
Queue: Moo-Google

People
Owner: Nobody in particular
Requestors: DROLSKY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: The name is very confusing
Calling this "Moo::Google" when it is built on _Moose_ instead of _Moo_ is very confusing. That said, naming things after what they're built on is not a good practice. It's much better if the name describes what it does rather than what it is made of. So with that in mind maybe it's best to call it something like "WebService::Google::Base" or something along those lines.
On Wed May 03 12:43:09 2017, DROLSKY wrote: Show quoted text
> Calling this "Moo::Google" when it is built on _Moose_ instead of > _Moo_ is very confusing. That said, naming things after what they're > built on is not a good practice. It's much better if the name > describes what it does rather than what it is made of. So with that in > mind maybe it's best to call it something like > "WebService::Google::Base" or something along those lines.
I second this! Unrelated, I think in a similar ticket, you (Pavel) announced you were going to share the code on github. Have you? I'd love to take a poke at it. Thanks and best regards, Steffen
Subject: Re: [rt.cpan.org #121515] The name is very confusing
Date: Fri, 26 May 2017 02:31:21 +0300
To: bug-Moo-Google [...] rt.cpan.org
From: Pavel Serikov <pavel.p.serikov [...] gmail.com>
Hi Steffen and Dave, Sorry for delay in reply, I was busy with other projects. Now source code is published on Github, you are welcome to take a look and make a pull request ;) https://github.com/pavelsr/moo-google According module name complain - I'm sorry, but I hadn't invented better name. Thought that almost all Perl developers use Metacpan and will easily check that my module depends on Moose too. And also I had plans for future to migrate module to clean Moo or even to Mojo::Base to make module lightweight. Anyway, if you know better name - you are welcome to suggest it, I will make a refactoring, no problem. 2017-05-24 12:48 GMT+03:00 Steffen Mueller via RT < bug-Moo-Google@rt.cpan.org>: Show quoted text
> Queue: Moo-Google > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=121515 > > > On Wed May 03 12:43:09 2017, DROLSKY wrote:
> > Calling this "Moo::Google" when it is built on _Moose_ instead of > > _Moo_ is very confusing. That said, naming things after what they're > > built on is not a good practice. It's much better if the name > > describes what it does rather than what it is made of. So with that in > > mind maybe it's best to call it something like > > "WebService::Google::Base" or something along those lines.
> > I second this! > > Unrelated, I think in a similar ticket, you (Pavel) announced you were > going to share the code on github. Have you? I'd love to take a poke at it. > > Thanks and best regards, > Steffen >
-- Best regards, Pavel Serikov +7 (988) 585-19-00 pavel.p.serikov@gmail.com (E-mail/Gtalk/G+) skype: rus_61
On 2017-05-25 18:31:30, pavel.p.serikov@gmail.com wrote: Show quoted text
> Hi Steffen and Dave, > > Sorry for delay in reply, I was busy with other projects. > > Now source code is published on Github, you are welcome to take a look > and > make a pull request ;) > https://github.com/pavelsr/moo-google > > According module name complain - I'm sorry, but I hadn't invented > better > name. > Thought that almost all Perl developers use Metacpan and will easily > check > that my module depends on Moose too. > And also I had plans for future to migrate module to clean Moo or even > to > Mojo::Base to make module lightweight. > > Anyway, if you know better name - you are welcome to suggest it, I > will > make a refactoring, no problem.
As I suggested originally, I think WebService::Google::Base would be okay. Alternatively maybe WebService::Google::Framework or WebService::Google::Toolkit or something else starting with WebService::Google::
On 2017-05-25 18:31:30, pavel.p.serikov@gmail.com wrote: Show quoted text
> Hi Steffen and Dave, > > Sorry for delay in reply, I was busy with other projects. > > Now source code is published on Github, you are welcome to take a look > and > make a pull request ;) > https://github.com/pavelsr/moo-google
If you want to use GitHub issues (which according to your META.json you do), you might find https://metacpan.org/release/RTx-ToGitHub handy.