Skip Menu |

This queue is for tickets about the Time-Local-TZ CPAN distribution.

Report information
The Basics
Id: 121469
Status: resolved
Priority: 0/
Queue: Time-Local-TZ

People
Owner: cpan [...] bambra.net
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.03

Attachments
fail.Time-Local-TZ-0.02.amd64-freebsd.10.3-release-p11.1493714940.68230.rpt



Subject: tests fail on freebsd systems
I observe test failures on my freebsd 9 & 10 smokers. A sample test log looks like this: ... # Failed test 'tz_localtime('Europe/Moscow', 1493043119') as string with TZ set' # at t/01-tz_localtime-tz_timelocal.t line 40. # got: 'Mon Apr 24 18:11:59 2017' # expected: 'Mon Apr 24 17:11:59 2017' # Failed test 'tz_localtime('Europe/Moscow', 1493043119) as array with TZ set' # at t/01-tz_localtime-tz_timelocal.t line 43. # Structures begin differing at: # $got->[2] = '18' # $expected->[2] = '17' # Failed test 'tz_localtime('Europe/Moscow', 1493043119') as string with TZ unset' # at t/01-tz_localtime-tz_timelocal.t line 49. # got: 'Mon Apr 24 18:11:59 2017' # expected: 'Mon Apr 24 17:11:59 2017' # Failed test 'tz_localtime('Europe/Moscow', 1493043119) as array with TZ unset' # at t/01-tz_localtime-tz_timelocal.t line 52. # Structures begin differing at: # $got->[2] = '18' # $expected->[2] = '17' Out of memory! A context appears to have been destroyed without first calling release(). Based on $@ it does not look like an exception was thrown (this is not always a reliable test) This is a problem because the global error variables ($!, $@, and $?) will not be restored. In addition some release callbacks will not work properly from inside a DESTROY method. Here are the context creation details, just in case a tool forgot to call release(): File: t/01-tz_localtime-tz_timelocal.t Line: 67 Tool: Test::More::ok Cleaning up the CONTEXT stack... # Looks like your test exited with 1 just after 62. Out of memory! t/01-tz_localtime-tz_timelocal.t .. Failed 13/71 subtests ... Additionally to the "out of memory" errors, there are also segmentation faults and bus errors.
Hi Slaven, Thank you very much for your report. Show quoted text
> # Failed test 'tz_localtime('Europe/Moscow', 1493043119') as string > with TZ set' > # at t/01-tz_localtime-tz_timelocal.t line 40. > # got: 'Mon Apr 24 18:11:59 2017' > # expected: 'Mon Apr 24 17:11:59 2017'
Usually this kind of errors appears on hosts with obsolete tzdata. Are you sure you have fresh one? I don't see the way to write the tests which are independent from tzdata version. Show quoted text
> Additionally to the "out of memory" errors, there are also > segmentation faults and bus errors.
I made ugly dist for the initial version, it contains artefacts from my build. Can you please check again version 0.02? It is cleaned up and have small changes. On FreeBSD 10 I have tests passed. Thanks.
On 2017-05-02 07:09:21, Bambr wrote: Show quoted text
> Hi Slaven, > Thank you very much for your report. >
> > # Failed test 'tz_localtime('Europe/Moscow', 1493043119') as string > > with TZ set' > > # at t/01-tz_localtime-tz_timelocal.t line 40. > > # got: 'Mon Apr 24 18:11:59 2017' > > # expected: 'Mon Apr 24 17:11:59 2017'
> Usually this kind of errors appears on hosts with obsolete tzdata. Are > you sure you have fresh one?
This is possible --- I see this only on my freebsd9 smoker, not on the freebsd10 smoker. Show quoted text
> I don't see the way to write the tests which are independent from > tzdata version. > >
> > Additionally to the "out of memory" errors, there are also > > segmentation faults and bus errors.
> I made ugly dist for the initial version, it contains artefacts from > my build. Can you please check again version 0.02? It is cleaned up > and have small changes. On FreeBSD 10 I have tests passed.
Attached is a sample fail report with 0.02 on my freebsd10.3 smoker. Regards, Slaven
Subject: fail.Time-Local-TZ-0.02.amd64-freebsd.10.3-release-p11.1493714940.68230.rpt

Message body not shown because it is not plain text.

Hi Slaven, I made new release 0.03, seems it fix BSD problems (I tried with two environments). I will wait for your check or automated reports. Thank you for your help again!
On 2017-05-18 08:55:07, Bambr wrote: Show quoted text
> Hi Slaven, > > I made new release 0.03, seems it fix BSD problems (I tried with two > environments). I will wait for your check or automated reports. Thank > you for your help again!
Confirmed on my freebsd 10 system. Resolving.