Bug #121293 for Term-ReadLine-Tiny: Experimental pop on scalar is now forbidden

Sat Apr 22 10:10:48 2017 SREZIC [...] cpan.org - Ticket created

Subject:

Experimental pop on scalar is now forbidden

Module compilation fails for perls >= 5.24 (with the above error message) and perls <= 5.12 (for roughly the same reason): # Failed test 'use Term::ReadLine::Tiny;' # at t/00-load.t line 7. # Tried to use 'Term::ReadLine::Tiny'. # Error: Experimental pop on scalar is now forbidden at /home/cpansand/.cpan/build/2017042215/Term-ReadLine-Tiny-1.00-5/blib/lib/Term/ReadLine/Tiny.pm line 282, near "$history unless" # Compilation failed in require at t/00-load.t line 7. # BEGIN failed--compilation aborted at t/00-load.t line 7. # Failed test 'use Term::ReadLine::Tiny;' # at t/00-load.t line 7. # Tried to use 'Term::ReadLine::Tiny'. # Error: Type of arg 1 to pop must be array (not private variable) at /usr/home/eserte/.cpan/build/2017042215/Term-ReadLine-Tiny-1.00-1/blib/lib/Term/ReadLine/Tiny.pm line 282, near "$history unless" # Compilation failed in require at t/00-load.t line 7. # BEGIN failed--compilation aborted at t/00-load.t line 7.

Mon Apr 24 14:23:10 2017 SREZIC [...] cpan.org - Broken in 1.00 added

Mon Apr 24 14:23:10 2017 SREZIC [...] cpan.org - Broken in 1.01 added

Wed May 03 20:12:14 2017 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

Here is a patch.

Subject:

open_A5BqVTyi.txt

diff -rup Term-ReadLine-Tiny-1.01-gc0TYI-orig/lib/Term/ReadLine/Tiny.pm Term-ReadLine-Tiny-1.01-gc0TYI/lib/Term/ReadLine/Tiny.pm --- Term-ReadLine-Tiny-1.01-gc0TYI-orig/lib/Term/ReadLine/Tiny.pm 2017-04-23 22:40:42.000000000 -0700 +++ Term-ReadLine-Tiny-1.01-gc0TYI/lib/Term/ReadLine/Tiny.pm 2017-05-03 17:10:47.000000000 -0700 @@ -281,7 +281,7 @@ sub readline { print $out $char; $history->[$#$history] = $line; - pop $history unless defined($minline) and length($line) >= $minline; + pop @$history unless defined($minline) and length($line) >= $minline; $result = $line; last; }

Wed May 03 20:12:15 2017 The RT System itself - Status changed from 'new' to 'open'

Thu May 04 02:57:49 2017 ORKUN [...] cpan.org - Correspondence added

03 May 2017 Çrş, 20:12:14 tarihinde, SPROUT yazdı: Show quoted text

> Here is a patch.

https://github.com/orkunkaraduman/p5-Term-ReadLine-Tiny/commit/6b099c3a42b9d6fbb66256654e0997de244ce0c5

Thu May 04 02:57:50 2017 ORKUN [...] cpan.org - Status changed from 'open' to 'resolved'

Thu May 04 02:57:55 2017 ORKUN [...] cpan.org - Fixed in 1.03 added

Thu May 04 17:34:31 2017 ORKUN [...] cpan.org - Correspondence added

04 May 2017 Prş, 02:57:49 tarihinde, ORKUN yazdı: Show quoted text

> 03 May 2017 Çrş, 20:12:14 tarihinde, SPROUT yazdı:

> > Here is a patch.

> > > https://github.com/orkunkaraduman/p5-Term-ReadLine- > Tiny/commit/6b099c3a42b9d6fbb66256654e0997de244ce0c5

Thu May 04 17:34:32 2017 ORKUN [...] cpan.org - Taken