Bug #121230 for HTML-Tree: Undeclared dependency Test::Fatal (5.04)

Tue Apr 18 02:44:22 2017 SREZIC [...] cpan.org - Ticket created

Subject:

Undeclared dependency Test::Fatal (5.04)

The test suite fails if Test::Fatal is not installed: ... Can't locate Test/Fatal.pm in @INC (you may need to install the Test::Fatal module) (@INC contains: ... .) at t/construct_tree.t line 9. BEGIN failed--compilation aborted at t/construct_tree.t line 9. # Looks like your test exited with 2 before it could output anything. t/construct_tree.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 75/75 subtests ...

Tue Apr 18 19:21:50 2017 Jeff.Fearn [...] gmail.com - Taken

Tue Apr 18 19:21:59 2017 Jeff.Fearn [...] gmail.com - Status changed from 'new' to 'open'

Tue Apr 18 19:35:22 2017 Jeff.Fearn [...] gmail.com - Correspondence added

Thanks for the report. https://github.com/jfearn/HTML-Tree/commit/dc5585bd81dee2240c3a58d92e1dbcc04e672d44 Now to wait rand() to see if there are any other things requiring patching.

Tue Apr 18 19:35:33 2017 Jeff.Fearn [...] gmail.com - Status changed from 'open' to 'patched'

Thu Apr 20 02:32:28 2017 KENTNL [...] cpan.org - Correspondence added

Looks like in the migration from DZil, you overlooked the dependencies.

For instance, there's a new dependency on Test::Exception, even though none of the code uses it.

Additionally, LWP is now an unconditional dependency instead of a recommendation, but HTML::FormatText is no longer present in the metadata, even though its present at runtime.

And given Module::Build supports both "Recommends" and "Test_requires", I consider It a bit of a regression that the recommendations are removed, _and_ that test dependencies are now considered "build" dependencies, as the latter now means test dependencies are *unconditionally* required even for people using cpanm --notest

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Wed Apr 26 00:38:40 2017 KENTNL [...] cpan.org - Status changed from 'patched' to 'open'

Wed Apr 26 00:39:37 2017 KENTNL [...] cpan.org - Correspondence added

Ugh. this should be fixed in 5.05, I just can't update the RT status yet because my perm haven't propagated yet.

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Wed Apr 26 04:11:21 2017 KENTNL [...] cpan.org - Status changed from 'open' to 'resolved'