Bug #121197 for SVG: Makefile.PL generates hybrid Meta-1.x data wrongly

Mon Apr 17 00:56:32 2017 KENTNL [...] cpan.org - Ticket created

Subject:

Makefile.PL generates hybrid Meta-1.x data wrongly

https://metacpan.org/diff/file?target=MANWAR%2FSVG-2.65%2F&source=SZABGAB%2FSVG-2.64#META.json

This is because you're using Meta 2.0 structures and EUMM is only generating 1.x structures.

To solve this, you need to ensure the following data is in your input META:

    'meta-spec' => { version => 2 }

Otherwise EUMM assumes Version 1 input.

Make sure to diff the releases before releasing next time to ensure this is fixed as intended :)

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Mon Apr 17 05:13:36 2017 MANWAR [...] cpan.org - Correspondence added

Thanks @KENTNL for pointing the error and suggestion. Much appreciated. Best Regards, Mohammad S Anwar

Mon Apr 17 05:13:37 2017 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 17 05:13:37 2017 MANWAR [...] cpan.org - Taken

Mon Apr 17 05:13:59 2017 MANWAR [...] cpan.org - Severity Important added

Mon Apr 17 08:42:14 2017 KENTNL [...] cpan.org - Correspondence added

On 2017-04-17 21:13:36, MANWAR wrote:
> Thanks @KENTNL for pointing the error and suggestion. Much appreciated.
>
> Best Regards,
> Mohammad S Anwar

I should also point out the wrong JSON is still present in 2.66

https://metacpan.org/diff/file?target=MANWAR%2FSVG-2.66%2F&source=SZABGAB%2FSVG-2.64#META.json

But this seems I overlooked something in your code as well :(

     resources => {
            repository => {    # <-- this level of nesting is missing but necessary for the right result
              type => 'git',
              url   => 'https://github.com/manwar/SVG.git',
              web   => 'https://github.com/manwar/SVG',
            }
        },

You only have resources->{type} but you need resources->{repository}->{type}

Local testing suggests this *SHOULD* Be enough.

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Thu Apr 20 08:29:59 2017 MANWAR [...] cpan.org - Correspondence added

Fixed.

Thu Apr 20 08:30:15 2017 MANWAR [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Apr 20 08:30:15 2017 MANWAR [...] cpan.org - Fixed in 2.67 added