Skip Menu |

This queue is for tickets about the Win32-Process-CommandLine CPAN distribution.

Report information
The Basics
Id: 120937
Status: open
Priority: 0/
Queue: Win32-Process-CommandLine

People
Owner: Nobody in particular
Requestors: jason [...] froebe.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.03
Fixed in: (no value)



Subject: Tests fail on Strawberry Perl 5.24.1.1 (64bit) Windows 10
Platform: Strawberry Perl 5.24.1.1 (64bit) Windows 10 Win32::Process::CommandLine version: 0.03 Show quoted text
cpan> install Win32::Process::CommandLine
Running install for module 'Win32::Process::CommandLine' Fetching with LWP: http://cpan.strawberryperl.com/authors/id/K/KX/KXJ/Win32-Process-CommandLine-0.03.tar.gz Fetching with LWP: http://cpan.strawberryperl.com/authors/id/K/KX/KXJ/CHECKSUMS Checksum for C:\Perl\STRAWB~1\cpan\sources\authors\id\K\KX\KXJ\Win32-Process-CommandLine-0.03.tar.gz ok Configuring K/KX/KXJ/Win32-Process-CommandLine-0.03.tar.gz with Makefile.PL Checking if your kit is complete... Looks good Generating a dmake-style Makefile Writing Makefile for Win32::Process::CommandLine Writing MYMETA.yml and MYMETA.json KXJ/Win32-Process-CommandLine-0.03.tar.gz C:\Perl\Strawberry\perl\bin\perl.exe Makefile.PL -- OK Running make for K/KX/KXJ/Win32-Process-CommandLine-0.03.tar.gz cp test_all_pid.pl blib\lib\Win32\Process\test_all_pid.pl cp test_one_pid.pl blib\lib\Win32\Process\test_one_pid.pl cp lib/Win32/Process/CommandLine.pm blib\lib\Win32\Process\CommandLine.pm AutoSplitting blib\lib\Win32\Process\CommandLine.pm (blib\lib\auto\Win32\Process\CommandLine) Running Mkbootstrap for CommandLine () "C:\Perl\Strawberry\perl\bin\perl.exe" -MExtUtils::Command -e chmod -- 644 "CommandLine.bs" "C:\Perl\Strawberry\perl\bin\perl.exe" -MExtUtils::Command::MM -e cp_nonempty -- CommandLine.bs blib\arch\auto\Win32\Pro cess\CommandLine\CommandLine.bs 644 "C:\Perl\Strawberry\perl\bin\perl.exe" "C:\Perl\Strawberry\perl\lib\ExtUtils\xsubpp" -typemap C:\Perl\STRAWB~1\perl\lib \ExtUtils\typemap CommandLine.xs > CommandLine.xsc Please specify prototyping behavior for CommandLine.xs (see perlxs manual) "C:\Perl\Strawberry\perl\bin\perl.exe" -MExtUtils::Command -e mv -- CommandLine.xsc CommandLine.c gcc -c -I. -s -O2 -DWIN32 -DWIN64 -DCONSERVATIVE -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SY S -fwrapv -fno-strict-aliasing -mms-bitfields -s -O2 -DVERSION=\"0.03\" -DXS_VERSION=\"0.03\" "-IC:\Perl\STRAWB ~1\perl\lib\CORE" CommandLine.c CommandLine.xs: In function 'GetProcessCmdLine': CommandLine.xs:170:29: warning: passing argument 5 of 'ReadProcessMemory' from incompatible pointer type &dwDummy ^ In file included from C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/winbase.h:25:0, from C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/windows.h:70, from C:\Perl\STRAWB~1\perl\lib\CORE/win32.h:131, from C:\Perl\STRAWB~1\perl\lib\CORE/win32thread.h:4, from C:\Perl\STRAWB~1\perl\lib\CORE/perl.h:3159, from CommandLine.xs:2: C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/memoryapi.h:61:29: note: expected 'SIZE_T *' but argument is of type 'DW ORD *' WINBASEAPI WINBOOL WINAPI ReadProcessMemory (HANDLE hProcess, LPCVOID lpBaseAddress, LPVOID lpBuffer, SIZE_T nSize, S IZE_T *lpNumberOfBytesRead); ^ CommandLine.xs:179:29: warning: passing argument 5 of 'ReadProcessMemory' from incompatible pointer type &dwDummy ^ In file included from C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/winbase.h:25:0, from C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/windows.h:70, from C:\Perl\STRAWB~1\perl\lib\CORE/win32.h:131, from C:\Perl\STRAWB~1\perl\lib\CORE/win32thread.h:4, from C:\Perl\STRAWB~1\perl\lib\CORE/perl.h:3159, from CommandLine.xs:2: C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/memoryapi.h:61:29: note: expected 'SIZE_T *' but argument is of type 'DW ORD *' WINBASEAPI WINBOOL WINAPI ReadProcessMemory (HANDLE hProcess, LPCVOID lpBaseAddress, LPVOID lpBuffer, SIZE_T nSize, S IZE_T *lpNumberOfBytesRead); ^ CommandLine.xs:196:29: warning: passing argument 5 of 'ReadProcessMemory' from incompatible pointer type &dwDummy ^ In file included from C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/winbase.h:25:0, from C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/windows.h:70, from C:\Perl\STRAWB~1\perl\lib\CORE/win32.h:131, from C:\Perl\STRAWB~1\perl\lib\CORE/win32thread.h:4, from C:\Perl\STRAWB~1\perl\lib\CORE/perl.h:3159, from CommandLine.xs:2: C:/Perl/Strawberry/c/x86_64-w64-mingw32/include/memoryapi.h:61:29: note: expected 'SIZE_T *' but argument is of type 'DW ORD *' WINBASEAPI WINBOOL WINAPI ReadProcessMemory (HANDLE hProcess, LPCVOID lpBaseAddress, LPVOID lpBuffer, SIZE_T nSize, S IZE_T *lpNumberOfBytesRead); ^ "C:\Perl\Strawberry\perl\bin\perl.exe" -MExtUtils::Mksymlists \ -e "Mksymlists('NAME'=>\"Win32::Process::CommandLine\", 'DLBASE' => 'CommandLine', 'DL_FUNCS' => { }, 'FUNCLIST' = Show quoted text
> [], 'IMPORTS' => { }, 'DL_VARS' => []);"
g++ CommandLine.def -o blib\arch\auto\Win32\Process\CommandLine\CommandLine.xs.dll -mdll -s -L"C:\Perl\STRAWB~1\perl\lib \CORE" -L"C:\Perl\STRAWB~1\c\lib" CommandLine.o "C:\Perl\STRAWB~1\perl\lib\CORE\libperl524.a" -lmoldname -lkernel32 -l user32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -l version -lodbc32 -lodbccp32 -lcomctl32 -Wl,--enable-auto-image-base "C:\Perl\Strawberry\perl\bin\perl.exe" -MExtUtils::Command -e chmod -- 755 blib\arch\auto\Win32\Process\CommandLine\Comm andLine.xs.dll KXJ/Win32-Process-CommandLine-0.03.tar.gz C:\Perl\STRAWB~1\c\bin\dmake.exe -- OK Running make test "C:\Perl\Strawberry\perl\bin\perl.exe" -MExtUtils::Command::MM -e cp_nonempty -- CommandLine.bs blib\arch\auto\Win32\Pro cess\CommandLine\CommandLine.bs 644 "C:\Perl\Strawberry\perl\bin\perl.exe" "-Iblib\lib" "-Iblib\arch" test.pl notepad.exe started with pid 8340 return code is the length of command line (include \0) : -1 command line of pid 8340: fail"C:\Perl\Strawberry\perl\bin\perl.exe" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switc hes; test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/Win32-Process-CommandLine.t .. 3/3 # Failed test at t/Win32-Process-CommandLine.t line 55. # Looks like you failed 1 test of 3. t/Win32-Process-CommandLine.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/Win32-Process-CommandLine.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=1, Tests=3, 2 wallclock secs ( 0.06 usr + 0.02 sys = 0.08 CPU) Result: FAIL Failed 1/1 test programs. 1/3 subtests failed. dmake.exe: Error code 129, while making 'test_dynamic' KXJ/Win32-Process-CommandLine-0.03.tar.gz C:\Perl\STRAWB~1\c\bin\dmake.exe test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports KXJ/Win32-Process-CommandLine-0.03.tar.gz Stopping: 'install' failed for 'Win32::Process::CommandLine'. Failed during this command: KXJ/Win32-Process-CommandLine-0.03.tar.gz : make_test NO Show quoted text
cpan>
Subject: [rt.cpan.org #120937]
Date: Thu, 2 Nov 2017 10:08:50 -0400
To: bug-Win32-Process-CommandLine [...] rt.cpan.org
From: Laurent <laurent.aml [...] gmail.com>
Here is a patch, fixing the Win32 structure declarations, in a Windows 64 compatible way (matching MS documentation). Not tested on Windows 32bits, though. Second unrelated patch fixes a commented debug printf. Thanks, -- Laurent Aml

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

I've applied Laurents 64bit patch here: https://github.com/wchristian/Win32-Process-CommandLine/tree/64bit_fix Anyone who needs this module on 64bit can install it with: cpanm https://github.com/wchristian/Win32-Process-CommandLine.git@64bit_fix