Bug #120839 for Net-SSLeay: Fails tests when no "." in @INC

Sun Apr 02 06:57:46 2017 KENTNL [...] cpan.org - Ticket created

Subject:

Fails tests when no "." in @INC

Following on from https://rt.cpan.org/Ticket/Display.html?id=120403 as requested, after 0.81 , Makefile.PL now works properly on 5.26

However, Tests still exhibit failures if PERL_USE_UNSAFE_INC=0 , as tests also rely on assumed '.' in @INC

These failures are slightly less critical, as they're harder for end users to see due to the CPAN toolchains *and* TAP::Harness ( make test, prove, ./Build test, etc ) setting PERL_USE_UNSAFE_INC=1 automatically when PERL_USE_UNSAFE_INC is not defined.

However, this can be *hiding* real problems, and so people doing wide scale CPAN Testing are encouraged to expose and report these kinds of failures.

When fixing the failures, please take care to choose @INC modifications or require/do invocations so that libraries in other paths not loaded explicitly don't automatically load. ( That is, you want to have the tests set up so any failures in runtime loading still fail if they needed '.' in @INC to work )

t/local/07_sslecho.t ................... ok
do "t/data/cert_paypal.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/cert_twitter.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_extended.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_simple.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_strange.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_cdp.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.

#   Failed test 'X509_NAME_entry_count   cert_twitter.crt.pem'
#   at t/local/32_x509_get_cert_info.t line 50.
#          got: '12'
#     expected: undef

with a final run of

t/local/32_x509_get_cert_info.t      (Wstat: 512 Tests: 190 Failed: 95)
Failed tests: 7, 13-15, 19-21, 25-27, 31-33, 37-39, 43-45
                49-51, 55-57, 61-63, 67-69, 73-75, 79-81
                83-85, 89-91, 95-97, 101-103, 107-109, 113-120
                124-129, 131-134, 138-139, 143-144, 148-149
                153-154, 158-159, 163-164, 168-169, 173-174
                178-179, 183-187, 189-190
Non-zero exit status: 2
Parse errors: Bad plan. You planned 1243 tests but ran 190.

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Sun Apr 16 08:43:15 2017 jkeenan [...] cpan.org - Correspondence added

On Sun Apr 02 06:57:46 2017, KENTNL wrote: Show quoted text

> Following on from https://rt.cpan.org/Ticket/Display.html?id=120403 as > requested, after 0.81 , Makefile.PL now works properly on 5.26 > > However, Tests still exhibit failures if PERL_USE_UNSAFE_INC=0 , as > tests also > rely on assumed '.' in @INC > > These failures are slightly less critical, as they're harder for end > users to > see due to the CPAN toolchains *and* TAP::Harness ( make test, prove, > ./Build > test, etc ) setting PERL_USE_UNSAFE_INC=1 automatically when > PERL_USE_UNSAFE_INC is not defined. > > However, this can be *hiding* real problems, and so people doing wide > scale > CPAN Testing are encouraged to expose and report these kinds of > failures. > > When fixing the failures, please take care to choose @INC > modifications or > require/do invocations so that libraries in other paths not loaded > explicitly > don't automatically load. ( That is, you want to have the tests set up > so any > failures in runtime loading still fail if they needed '.' in @INC to > work ) > > t/local/07_sslecho.t ................... ok > do "t/data/cert_paypal.crt.pem_dump" failed, '.' is no longer in @INC > at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/cert_twitter.crt.pem_dump" failed, '.' is no longer in @INC > at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_extended.crt.pem_dump" failed, '.' is no longer in > @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_simple.crt.pem_dump" failed, '.' is no longer in > @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_strange.crt.pem_dump" failed, '.' is no longer in > @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_cdp.crt.pem_dump" failed, '.' is no longer in @INC > at > t/local/32_x509_get_cert_info.t line 23. > > # Failed test 'X509_NAME_entry_count cert_twitter.crt.pem' > # at t/local/32_x509_get_cert_info.t line 50. > # got: '12' > # expected: undef > > > with a final run of > > > t/local/32_x509_get_cert_info.t (Wstat: 512 Tests: 190 Failed: 95) > Failed tests: 7, 13-15, 19-21, 25-27, 31-33, 37-39, 43-45 > 49-51, 55-57, 61-63, 67-69, 73-75, 79-81 > 83-85, 89-91, 95-97, 101-103, 107-109, 113-120 > 124-129, 131-134, 138-139, 143-144, 148-149 > 153-154, 158-159, 163-164, 168-169, 173-174 > 178-179, 183-187, 189-190 > Non-zero exit status: 2 > Parse errors: Bad plan. You planned 1243 tests but ran 190. > > > -- > - CPAN kentnl@cpan.org > - Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

The attached may work. Thank you very much. Jim Keenan

Subject:

net-ssleay-t-local-31.diff

--- t/local/32_x509_get_cert_info.t (revision 494) +++ t/local/32_x509_get_cert_info.t (working copy) @@ -20,6 +20,7 @@ # NOTE: *.pem_dump files are generated by helper script e.g.: # perl examples/X509_cert_details.pl -dump -pem t/data/cert_twitter.crt.pem > t/data/cert_paypal.crt.pem_dump # +push @INC, '.'; my $dump = { "cert_paypal.crt.pem" => do(File::Spec->catfile('t', 'data', 'cert_paypal.crt.pem_dump')), "cert_twitter.crt.pem" => do(File::Spec->catfile('t', 'data', 'cert_twitter.crt.pem_dump')),

Sun Apr 16 08:43:17 2017 The RT System itself - Status changed from 'new' to 'open'

Wed Apr 26 14:12:40 2017 ether [...] cpan.org - Correspondence added

Message body is not shown because it is too large.

Thu May 11 04:32:10 2017 ether [...] cpan.org - Correspondence added

On 2017-04-16 05:43:15, JKEENAN wrote: Show quoted text

> The attached may work.

Alternatively, change do "t/foo/..." to do "./t/foo", without changing @INC.

Fri May 12 08:32:51 2017 ether [...] cpan.org - Severity Important added

Sat May 27 20:46:58 2017 ether [...] cpan.org - Correspondence added

5.26.0 is expected this week, so I'm raising the priority of this from Important to Critical.

Sat May 27 20:47:12 2017 ether [...] cpan.org - Severity Important changed to Critical

Sun May 28 03:46:58 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120839] Fails tests when no "." in @INC
Date:	Sun, 28 May 2017 08:25:23 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Thanks Karen I'm travelling and won't get to this until early June Cheers Sent from my iPhone Show quoted text

> On 28 May 2017, at 1:47 am, Karen Etheridge via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120839 > > > 5.26.0 is expected this week, so I'm raising the priority of this from Important to Critical.

Wed May 31 05:30:45 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120839] Fails tests when no "." in @INC
Date:	Wed, 31 May 2017 19:06:00 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Thanks again for reporting this, Im back and ready to work on it. but I'm unclear on how to reproduce this issue. Cheers. On Saturday, 27 May 2017 8:47:00 PM AEST Karen Etheridge via RT wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120839 > > > 5.26.0 is expected this week, so I'm raising the priority of this from > Important to Critical.

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Wed May 31 05:49:09 2017 KENTNL [...] cpan.org - Correspondence added

On 2017-05-31 21:30:45, mikem@airspayce.com wrote:
> Thanks again for reporting this,
> Im back and ready to work on it.
>
> but I'm unclear on how to reproduce this issue.
>
> Cheers.
>

You need to be on Perl 5.25.11 or greater ( 5.26 perferred ), and then you can demonstrate the test failures by running the tests with your usual

perl -Mblib -Mlib=lib t/foo.t

Command.

If you simply use "make test", a hack in TAP::Harness will step in and hide the problem again. That hack is in place to isolate end users from this issue in the short, term, and you can defeat that hack by setting PERL_USE_UNSAFE_INC=0 in your environment prior to running make test.

More details: https://metacpan.org/pod/release/XSAWYERX/perl-5.26.0/pod/perldelta.pod#Removal-of-the-current-directory-%28%22.%22%29-from-@INC

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Wed May 31 20:04:11 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120839] Fails tests when no "." in @INC
Date:	Thu, 01 Jun 2017 09:42:29 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Thanks, I was able to reproduce. A fix has ben committed in SVN 496. Pls test and if OK for you I w8ill make a new release. Cheers. On Wednesday, 31 May 2017 5:49:11 AM AEST you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120839 > > > On 2017-05-31 21:30:45, mikem@airspayce.com wrote:

> > Thanks again for reporting this, > > Im back and ready to work on it. > > > > but I'm unclear on how to reproduce this issue. > > > > Cheers.

> > You need to be on Perl 5.25.11 or greater ( 5.26 perferred ), and then you > can demonstrate the test failures by running the tests with your usual > > perl -Mblib -Mlib=lib t/foo.t > > Command. > > If you simply use "make test", a hack in TAP::Harness will step in and hide > the problem again. That hack is in place to isolate end users from this > issue in the short, term, and you can defeat that hack by setting > PERL_USE_UNSAFE_INC=0 in your environment prior to running make test. > > More details: > https://metacpan.org/pod/release/XSAWYERX/perl-5.26.0/pod/perldelta.pod#Remo > val-of-the-current-directory-%28%22.%22%29-from-@INC > > > -- > - CPAN kentnl@cpan.org > - Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Thu Aug 03 23:47:38 2017 jkeenan [...] cpan.org - Correspondence added

On Wed May 31 20:04:11 2017, mikem@airspayce.com wrote: Show quoted text

> Thanks, I was able to reproduce. > A fix has ben committed in SVN 496. Pls test and if OK for you I > w8ill make a > new release. >

Do you anticipate making a new CPAN release soon? Today I attempted to install Net::SSLeay from CPAN vi 'cpanm' built against perl 5 blead with $PERL_USE_UNSAFE_INC set to 0. I got failures similar to what was reported earlier this year in this RT. These failures block the building and testing of, among other things, IO-Socket-SSL and LWP-protocol-https. Thank you very much. Jim Keenan

Fri Aug 04 00:18:40 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120839] Fails tests when no "." in @INC
Date:	Fri, 04 Aug 2017 13:57:44 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hello Jim, version 1.81 was release in March this year and should have addressed that problem. The only updated waiting for the next release are Added support for building under Linuxbrew (a linuxbrew version of MacOS Homebrew) Patch from Matthew Altus, that implements SSL_CTX_set_psk_client_callback() and SSL_set_psk_client_callback(). Cheers. On Thursday, 3 August 2017 11:47:40 PM AEST you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120839 > > > On Wed May 31 20:04:11 2017, mikem@airspayce.com wrote:

> > Thanks, I was able to reproduce. > > > > A fix has ben committed in SVN 496. Pls test and if OK for you I > > > > w8ill make a > > new release.

> > Do you anticipate making a new CPAN release soon? > > Today I attempted to install Net::SSLeay from CPAN vi 'cpanm' built against > perl 5 blead with $PERL_USE_UNSAFE_INC set to 0. I got failures similar to > what was reported earlier this year in this RT. These failures block the > building and testing of, among other things, IO-Socket-SSL and > LWP-protocol-https. > > Thank you very much. > Jim Keenan

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Wed Jul 25 08:46:15 2018 chrisn [...] cpan.org - Correspondence added

On Fri Aug 04 04:47:38 2017, JKEENAN wrote: Show quoted text

> On Wed May 31 20:04:11 2017, mikem@airspayce.com wrote:

> > Thanks, I was able to reproduce. > > A fix has ben committed in SVN 496. Pls test and if OK for you I > > w8ill make a > > new release. > >

> > Do you anticipate making a new CPAN release soon? > > Today I attempted to install Net::SSLeay from CPAN vi 'cpanm' built > against perl 5 blead with $PERL_USE_UNSAFE_INC set to 0. I got > failures similar to what was reported earlier this year in this RT. > These failures block the building and testing of, among other things, > IO-Socket-SSL and LWP-protocol-https.

SVN revision 496 (now Git commit 4b5d47c) was included in version 1.82, so this shouldn't be a problem from that version onwards. I've just successfully compiled 1.86_03 and executed the tests on Perl 5.28 with default_inc_excludes_dot=define and PERL_USE_UNSAFE_INC=0 - if this is still causing problems in the latest developer release, please feel free to reopen this ticket and we'll look into it.

Wed Jul 25 08:46:16 2018 chrisn [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Jul 25 08:46:16 2018 chrisn [...] cpan.org - Given to MIKEM

Wed Jul 25 08:46:17 2018 chrisn [...] cpan.org - Fixed in 1.82 added