Skip Menu |

This queue is for tickets about the Text-CSV CPAN distribution.

Report information
The Basics
Id: 120818
Status: resolved
Priority: 0/
Queue: Text-CSV

People
Owner: Nobody in particular
Requestors: jkeenan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.91
Fixed in: (no value)



Subject: Tests fail with Perl 5 blead due to non-dot-by-default-in-@INC
In Perl 5.26.0, '.' will no longer be found by default in @INC. When built against a recent Perl 5 blead which incorporates this new feature, most of Text-CSV's tests fail. Here is an excerpt from the output of trying to install Text-CSV against blead using 'cpanm': ##### Searching Text::CSV () on cpanmetadb ... --> Working on Text::CSV Fetching http://www.cpan.org/authors/id/I/IS/ISHIGAKI/Text-CSV-1.91.tar.gz -> OK [snip] PERL_DL_NONLAZY=1 "/home/jkeenan/testing/blead/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t # PERL_TEXT_CSV: undef t/00_pod.t ............... ok t/10_base.t .............. ok t/12_acc.t ............... ok t/15_flags.t ............. ok Can't locate t/util.pl in @INC (@INC contains: /home/jkeenan/.cpanm/work/1490881305.4413/Text-CSV-1.91/blib/lib /home/jkeenan/.cpanm/work/1490881305.4413/Text-CSV-1.91/blib/arch /home/jkeenan/testing/blead/lib/perl5/site_perl/5.25.11/x86_64-linux /home/jkeenan/testing/blead/lib/perl5/site_perl/5.25.11 /home/jkeenan/testing/blead/lib/perl5/5.25.11/x86_64-linux /home/jkeenan/testing/blead/lib/perl5/5.25.11) at t/20_file.t line 12. BEGIN failed--compilation aborted at t/20_file.t line 13. # Looks like your test exited with 2 just after 1. t/20_file.t .............. Dubious, test returned 2 (wstat 512, 0x200) Failed 104/105 subtests t/21_lexicalio.t ......... Dubious, test returned 2 (wstat 512, 0x200) Failed 104/105 subtests Can't locate t/util.pl in @INC (@INC contains: /home/jkeenan/.cpanm/work/1490881305.4413/Text-CSV-1.91/blib/lib /home/jkeenan/.cpanm/work/1490881305.4413/Text-CSV-1.91/blib/arch /home/jkeenan/testing/blead/lib/perl5/site_perl/5.25.11/x86_64-linux /home/jkeenan/testing/blead/lib/perl5/site_perl/5.25.11 /home/jkeenan/testing/blead/lib/perl5/5.25.11/x86_64-linux /home/jkeenan/testing/blead/lib/perl5/5.25.11) at t/22_scalario.t line 26. BEGIN failed--compilation aborted at t/22_scalario.t line 27. # Looks like your test exited with 2 just after 1. [snip] Dubious, test returned 2 (wstat 512, 0x200) Failed 7/8 subtests Test Summary Report ------------------- t/20_file.t (Wstat: 512 Tests: 1 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 105 tests but ran 1. t/21_lexicalio.t (Wstat: 512 Tests: 1 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 105 tests but ran 1. t/22_scalario.t (Wstat: 512 Tests: 1 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 132 tests but ran 1. [snip] Files=31, Tests=919, 2 wallclock secs ( 0.11 usr 0.03 sys + 1.31 cusr 0.10 csys = 1.55 CPU) Result: FAIL Failed 18/31 test programs. 0/919 subtests failed. Makefile:857: recipe for target 'test_dynamic' failed make: *** [test_dynamic] Error 2 ##### I will submit a pull request. Thank you very much. Jim Keenan
On Fri Mar 31 19:47:00 2017, JKEENAN wrote: Show quoted text
> > I will submit a pull request. >
Please review: https://github.com/makamaka/Text-CSV/pull/35 Since I and other CPAN contributors have libraries which have Text-CSV as a dependency (e.g., http://search.cpan.org/~jkeenan/Text-CSV-Hashify-0.08/), it would be appreciated if you could review the p.r. and issue a new CPAN release at your earliest opportunity. Thank you very much. Jim Keenan
This is still broken in 1.92 despite changelogs suggesting to the contrary.

t/80_diag.t .............. ok
t/90_csv.t ............... ok
Can't locate t/util.pl in @INC (@INC contains: /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/site_perl/5.25.11 /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc-nodot/lib/5.25.11) at t/rt99774.t line 12.
BEGIN failed--compilation aborted at t/rt99774.t line 13.
Show quoted text
# Looks like your test exited with 2 just after 1.
t/rt99774.t ..............
Dubious, test returned 2 (wstat 512, 0x200)
Failed 7/8 subtests



-- 
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )
On Tue Apr 04 19:09:07 2017, KENTNL wrote: Show quoted text
> This is still broken in 1.92 despite changelogs suggesting to the > contrary. > > t/80_diag.t .............. ok > t/90_csv.t ............... ok > Can't locate t/util.pl in @INC (@INC contains: > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/lib > /home/kent/.cpanm/work/1491300354.28786/Text-CSV-1.92/blib/arch > /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc- > nodot/lib/site_perl/5.25.11/x86_64-linux > /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc- > nodot/lib/site_perl/5.25.11 > /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc- > nodot/lib/5.25.11/x86_64-linux > /home/kent/perl5/perlbrew/perls/5.25.11-nossp-sip13-nopmc- > nodot/lib/5.25.11) at > t/rt99774.t line 12. > BEGIN failed--compilation aborted at t/rt99774.t line 13. > # Looks like your test exited with 2 just after 1. > t/rt99774.t .............. > Dubious, test returned 2 (wstat 512, 0x200) > Failed 7/8 subtests > > > > -- > - CPAN kentnl@cpan.org > - Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )
Thanks for spotting. I synched tests with the ones for the already-fixed Text::CSV_XS but I forgot there was one test that was for PP only and thus needed to be fixed separately. Fixed with https://github.com/makamaka/Text-CSV/commit/aa9aa66071ef9057f03b27c8309eae1edcfbbc81 and shipped 1.93.
Closed because this was fixed as of 1.93. Thanks.