Skip Menu |

This queue is for tickets about the Panda-Date CPAN distribution.

Report information
The Basics
Id: 120733
Status: resolved
Priority: 0/
Queue: Panda-Date

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 3.0.4
Fixed in: (no value)



Subject: Compilation error with threaded perls
Compiling util.cc fails with threaded perls: ... c++ -c -Isrc -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/Time.x/i -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/XS.x/i -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/Lib.x/i -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/XS.x/i -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/Lib.x/i -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/XS.x/i -D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -o util.o -std=c++11 -g0 -O2 -DVERSION=\"3.0.4\" -DXS_VERSION=\"3.0.4\" -fPIC "-I/opt/perl-5.25.11t/lib/5.25.11/x86_64-linux-thread-multi/CORE" util.cc In file included from util.h:2:0, from util.cc:1: Date.h: In function ‘const panda::time::Timezone* xs::date::tzget_required(PerlInterpreter*, SV*)’: Date.h:27:66: error: cannot convert ‘SV* {aka sv*}’ to ‘PerlInterpreter* {aka interpreter*}’ for argument ‘1’ to ‘std::string_view xs::lib::sv2string_view(PerlInterpreter*, SV*)’ return tzget(zone != NULL && SvOK(zone) ? sv2string_view(zone) : string_view()); ^ Date.h: In function ‘const panda::time::Timezone* xs::date::tzget_optional(PerlInterpreter*, SV*)’: Date.h:31:57: error: cannot convert ‘SV* {aka sv*}’ to ‘PerlInterpreter* {aka interpreter*}’ for argument ‘1’ to ‘std::string_view xs::lib::sv2string_view(PerlInterpreter*, SV*)’ return zone ? tzget(SvOK(zone) ? sv2string_view(zone) : string_view()) : NULL; ^ make: *** [util.o] Error 1 ...
Птн Мар 24 02:47:13 2017, SREZIC писал: Show quoted text
> Compiling util.cc fails with threaded perls: > > ... > c++ -c -Isrc -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux- > thread-multi/Panda/Time.x/i -I/opt/perl- > 5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/XS.x/i > -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread- > multi/Panda/Lib.x/i -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64- > linux-thread-multi/Panda/XS.x/i -I/opt/perl- > 5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread-multi/Panda/Lib.x/i > -I/opt/perl-5.25.11t/lib/site_perl/5.25.11/x86_64-linux-thread- > multi/Panda/XS.x/i -D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict- > aliasing -pipe -fstack-protector-strong -I/usr/local/include > -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -o > util.o -std=c++11 -g0 -O2 -DVERSION=\"3.0.4\" -DXS_VERSION=\"3.0.4\" > -fPIC "-I/opt/perl-5.25.11t/lib/5.25.11/x86_64-linux-thread- > multi/CORE" util.cc > In file included from util.h:2:0, > from util.cc:1: > Date.h: In function ‘const panda::time::Timezone* > xs::date::tzget_required(PerlInterpreter*, SV*)’: > Date.h:27:66: error: cannot convert ‘SV* {aka sv*}’ to > ‘PerlInterpreter* {aka interpreter*}’ for argument ‘1’ to > ‘std::string_view xs::lib::sv2string_view(PerlInterpreter*, SV*)’ > return tzget(zone != NULL && SvOK(zone) ? sv2string_view(zone) : > string_view()); > ^ > Date.h: In function ‘const panda::time::Timezone* > xs::date::tzget_optional(PerlInterpreter*, SV*)’: > Date.h:31:57: error: cannot convert ‘SV* {aka sv*}’ to > ‘PerlInterpreter* {aka interpreter*}’ for argument ‘1’ to > ‘std::string_view xs::lib::sv2string_view(PerlInterpreter*, SV*)’ > return zone ? tzget(SvOK(zone) ? sv2string_view(zone) : > string_view()) : NULL; > ^ > make: *** [util.o] Error 1 > ...
Ahhh, i'm always forgetting to pass aTHX_ while not testing with threaded perls :( Fixed and uploaded