Bug #120697 for Sys-Virt: Fails install when no '.' in @INC

Wed Mar 22 21:21:10 2017 KENTNL [...] cpan.org - Ticket created

Subject:

Fails install when no '.' in @INC

On 5.25.10+ with -Ddefault_inc_excludes_dot

Running Mkbootstrap for Virt ()
chmod 644 "Virt.bs"
"/home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/bin/perl5.25.10" -MExtUtils::Command::MM -e 'cp_nonempty' -- Virt.bs blib/arch/auto/Sys/Virt/Virt.bs 644
"/home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/bin/perl5.25.10" "/home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/5.25.10/ExtUtils/xsubpp" -typemap '/home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/5.25.10/ExtUtils/typemap' -typemap '/home/kent/.cpanm/work/1490232010.30357/Sys-Virt-3.1.0/typemap' Virt.xs > Virt.xsc
mv Virt.xsc Virt.c
cc -c -Wall -fstack-protector-strong -fno-stack-protector -DPERL_HASH_FUNC_SDBM -DPERL_DISABLE_PMC -fwrapv -fno-strict-aliasing -pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fstack-protector-strong -fno-stack-protector -O3 -march=native -mtune=native -DVERSION=\"3.1.0\" -DXS_VERSION=\"3.1.0\" -fPIC "-I/home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/5.25.10/x86_64-linux/CORE" Virt.c
rm -f blib/arch/auto/Sys/Virt/Virt.so
LD_RUN_PATH="/usr/lib" cc -shared -fstack-protector-strong -fno-stack-protector -O3 -march=native -mtune=native -L/usr/local/lib Virt.o -o blib/arch/auto/Sys/Virt/Virt.so \
-lvirt \

chmod 755 blib/arch/auto/Sys/Virt/Virt.so
"/home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/bin/perl5.25.10" "-Iblib/arch" "-Iblib/lib" META.yml.PL META.yml
"/home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/bin/perl5.25.10" "-Iblib/arch" "-Iblib/lib" perl-Sys-Virt.spec.PL perl-Sys-Virt.spec
lib/Sys/Virt.pm: No such file or directory at perl-Sys-Virt.spec.PL line 12.
make: *** [Makefile:542: perl-Sys-Virt.spec] Error 2

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Thu Jun 08 19:13:46 2017 KENTNL [...] cpan.org - Correspondence added

Patch is quite straight forward, attached.

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Subject:

0001-Fix-spec.PL-for-Perl-5.26-.-removal-from-INC.patch

From b04fcc43f602d865f9f5d4fdf90de47943e0027b Mon Sep 17 00:00:00 2001 From: Kent Fredric <kentfredric@gmail.com> Date: Fri, 9 Jun 2017 10:19:57 +1200 Subject: [PATCH] Fix spec.PL for Perl 5.26 '.' removal from @INC Perl 5.26 removes '.' from @INC, and this breaks the semantics of <<do $file>> where $file was assumed to be loaded from '.', but not explicitly stated, as 'do' is implemented using the same code as "require", that is, assuming @INC traversal. Inserting a leading "./" forces do to use a special-cased path where @INC is not consulted. Fixes RT#120697 Bug: https://rt.cpan.org/Ticket/Display.html?id=120697 --- perl-Sys-Virt.spec.PL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index aa3f6fc..d2d687c 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -6,10 +6,10 @@ use strict; die unless (scalar @ARGV == 1); -unless (do 'lib/Sys/Virt.pm') +unless (do './lib/Sys/Virt.pm') { if ($@) { die $@ }; - die "lib/Sys/Virt.pm: $!"; + die "./lib/Sys/Virt.pm: $!"; } local $/ = undef; -- 2.13.1

Wed Aug 15 07:55:20 2018 dan [...] berrange.com - Correspondence added

On Thu Jun 08 19:13:46 2017, KENTNL wrote: Show quoted text

> Patch is quite straight forward, attached.

Opps, I had in fact applied this patch, but forgot to update the ticket. commit 4ee3aad605f16ba836a11e6807dd2ef3693faf6d Author: Daniel P. Berrange <berrange@redhat.com> Date: Thu Jun 15 18:26:08 2017 +0100 Use ./ when loading Virt.pm since "." is no longer in @INC

Wed Aug 15 07:55:21 2018 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 15 07:55:21 2018 dan [...] berrange.com - Status changed from 'open' to 'resolved'