Skip Menu |

This queue is for tickets about the Clone CPAN distribution.

Report information
The Basics
Id: 120648
Status: resolved
Priority: 0/
Queue: Clone
People
Owner: Nobody in particular
Requestors: simcop [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 0.38
Fixed in: (no value)

History Show all quoted text
  Fri Mar 17 18:04:45 2017 simcop [...] cpan.org - Ticket created
Subject: Clone fails tests on perl 5.25.11 and newer
Newer perls (5.26 and above) are removing '.' from @INC. this is causing a few failing tests. Here's a patch to fix them:
Subject: Clone.patch
diff --git a/t/04tie.t b/t/04tie.t index 6fe1d27..02b931e 100755 --- a/t/04tie.t +++ b/t/04tie.t @@ -17,8 +17,8 @@ print "ok 1\n"; my $test = 2; -require 't/dump.pl'; -require 't/tied.pl'; +require './t/dump.pl'; +require './t/tied.pl'; my ($a, @a, %a); tie $a, TIED_SCALAR; diff --git a/t/dclone.t b/t/dclone.t index 0ffae19..8b62f68 100755 --- a/t/dclone.t +++ b/t/dclone.t @@ -55,7 +55,7 @@ # Baseline for first beta release. # -require 't/dump.pl'; +require './t/dump.pl'; # use Storable qw(dclone); use Clone qw(clone); diff --git a/t/tied.pl b/t/tied.pl index 61a7366..c1a942f 100755 --- a/t/tied.pl +++ b/t/tied.pl @@ -50,7 +50,7 @@ # Baseline for first beta release. # -require 't/dump.pl'; +require './t/dump.pl'; package TIED_HASH;
  Thu Mar 30 11:40:03 2017 jkeenan [...] cpan.org - Correspondence added
On Fri Mar 17 18:04:45 2017, SIMCOP wrote: Show quoted text
> Newer perls (5.26 and above) are removing '.' from @INC. this is > causing a few failing tests. Here's a patch to fix them:
Garu, I would like to second the request for the evaluation of this patch and a new CPAN release. Clone is depended upon by hundreds of other CPAN libraries -- over 250 at the top level alone! (http://deps.cpantesters.org/depended-on-by.pl?dist=Clone-0.38). If Clone's tests do not pass, CPAN testers are unable to evaluate the 5.26.0-readiness of all these down-river libraries. Should be busy but are willing to share COMAINT on this distribution so that we can get a corrected CPAN release out soon, please ping me. Thank you very much. Jim Keenan
  Thu Mar 30 11:40:03 2017 The RT System itself - Status changed from 'new' to 'open'
  Fri Apr 07 07:28:46 2017 garu [...] cpan.org - Correspondence added
Hi Jim! Hi Ryan! Thanks for the patch and the nudge. Clone 0.39 was just pushed to CPAN with it, so I'm closing the issue. Please let me know if you still see errors on 5.25.7 and above. Cheers! On Thu Mar 30 11:40:03 2017, JKEENAN wrote: Show quoted text
> On Fri Mar 17 18:04:45 2017, SIMCOP wrote:
> > Newer perls (5.26 and above) are removing '.' from @INC. this is > > causing a few failing tests. Here's a patch to fix them:
> > Garu, I would like to second the request for the evaluation of this > patch and a new CPAN release. > > Clone is depended upon by hundreds of other CPAN libraries -- over 250 > at the top level alone! (http://deps.cpantesters.org/depended-on- > by.pl?dist=Clone-0.38). If Clone's tests do not pass, CPAN testers > are unable to evaluate the 5.26.0-readiness of all these down-river > libraries. > > Should be busy but are willing to share COMAINT on this distribution > so that we can get a corrected CPAN release out soon, please ping me. > > Thank you very much. > Jim Keenan
  Fri Apr 07 07:28:59 2017 garu [...] cpan.org - Status changed from 'open' to 'resolved'