Skip Menu |

This queue is for tickets about the Devel-Callsite CPAN distribution.

Report information
The Basics
Id: 120632
Status: resolved
Priority: 0/
Queue: Devel-Callsite
People
Owner: Rocky Bernstein (no email address)
Requestors: ZHENYZ [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.10

History Show all quoted text
  Thu Mar 16 05:09:31 2017 ZHENYZ [...] cpan.org - Ticket created
Subject: Support older versions of MSVC
With older versions of MSVC, I got errors like below Callsite.xs(89) : error C2143: syntax error : missing ';' before 'const' Callsite.xs(90) : error C2143: syntax error : missing ';' before 'type' Callsite.xs(92) : error C2065: 'cx' : undeclared identifier Callsite.xs(92) : error C2065: 'dbcx' : undeclared identifier I would suggest applying a patch like this, for C90 compatibility. --- Callsite.xs.orig 2017-03-16 02:47:53.000000002 +0000 +++ Callsite.xs 2017-03-16 08:52:08.000000002 +0000 @@ -85,7 +85,7 @@ SV * callsite(level = 0) I32 level - INIT: + PREINIT: const PERL_CONTEXT *cx, *dbcx; int rv = 1; PPCODE:
  Sat Mar 18 23:21:10 2017 Rocky Bernstein - Correspondence added
Commit 1267765 applies this. Let me know if this works. On Thu Mar 16 05:09:31 2017, ZHENYZ wrote: Show quoted text
> With older versions of MSVC, I got errors like below > > Callsite.xs(89) : error C2143: syntax error : missing ';' before 'const' > Callsite.xs(90) : error C2143: syntax error : missing ';' before 'type' > Callsite.xs(92) : error C2065: 'cx' : undeclared identifier > Callsite.xs(92) : error C2065: 'dbcx' : undeclared identifier > > > I would suggest applying a patch like this, for C90 compatibility. > > > --- Callsite.xs.orig 2017-03-16 02:47:53.000000002 +0000 > +++ Callsite.xs 2017-03-16 08:52:08.000000002 +0000 > @@ -85,7 +85,7 @@ > SV * > callsite(level = 0) > I32 level > - INIT: > + PREINIT: > const PERL_CONTEXT *cx, *dbcx; > int rv = 1; > PPCODE:
  Sat Mar 18 23:21:10 2017 The RT System itself - Status changed from 'new' to 'open'
  Mon Mar 20 07:24:18 2017 ZHENYZ [...] cpan.org - Correspondence added
version 0.10 is good. This ticket can be closed. Thanks! On Sat Mar 18 23:21:10 2017, ROCKY wrote: Show quoted text
> Commit 1267765 applies this. Let me know if this works. > > On Thu Mar 16 05:09:31 2017, ZHENYZ wrote:
> > With older versions of MSVC, I got errors like below > > > > Callsite.xs(89) : error C2143: syntax error : missing ';' before 'const' > > Callsite.xs(90) : error C2143: syntax error : missing ';' before 'type' > > Callsite.xs(92) : error C2065: 'cx' : undeclared identifier > > Callsite.xs(92) : error C2065: 'dbcx' : undeclared identifier > > > > > > I would suggest applying a patch like this, for C90 compatibility. > > > > > > --- Callsite.xs.orig 2017-03-16 02:47:53.000000002 +0000 > > +++ Callsite.xs 2017-03-16 08:52:08.000000002 +0000 > > @@ -85,7 +85,7 @@ > > SV * > > callsite(level = 0) > > I32 level > > - INIT: > > + PREINIT: > > const PERL_CONTEXT *cx, *dbcx; > > int rv = 1; > > PPCODE:
> >
  Thu Mar 23 12:52:51 2017 Rocky Bernstein - Status changed from 'open' to 'resolved'
  Thu Mar 23 12:52:52 2017 Rocky Bernstein - Taken
  Thu Mar 23 12:52:52 2017 Rocky Bernstein - Fixed in 0.10 added