Bug #12063 for HTML-FillInForm: Problem With Array Field Of Different Sorts

Tue Mar 29 20:02:22 2005 Guest - Ticket created

Subject:

Problem With Array Field Of Different Sorts

$form->fill(scalarref => \$html, fdat => {'test'=>['123','456']}, ); <select name="test"> <option>123</option> <option>456</option> </select> <input type="text" name="test"> ------------------------------------------------------ In this case it turns out that both the 'select' field and 'text' field have the same value of "123"

Tue Mar 29 20:28:14 2005 Guest - Correspondence added

Here I am 25min later with a solution patch... line 174 chang from $value = [ $value ] unless ( ref($value) eq 'ARRAY' ); to $value = [ shift @$value ] unless ( ref($value) eq 'ARRAY' ); [guest - Tue Mar 29 20:02:22 2005]: Show quoted text

> $form->fill(scalarref => \$html, > fdat => {'test'=>['123','456']}, > ); > > <select name="test"> > <option>123</option> > <option>456</option> > </select> > > <input type="text" name="test"> > > ------------------------------------------------------ > In this case it turns out that both the 'select' field and 'text' > field have the same value of "123"

Tue Mar 29 21:42:58 2005 Guest - Correspondence added

Sorry guys my mistake that last fix has some bugs when dealign with many fields so a made a counter fix after looking into it a bit more. Scratch the last fix and do this: Add the following line $values = [shift @$values || ''] if ref($values) eq 'ARRAY'; in between line 252 and 253 252 $self->{output} .= ' selected="selected"'; 253 } I also tested this with multifield drop down and it works too. Hopefully it works everywhere. But don't take my fix withotu testing it yourselves, as you can see I'm not the most trustable source. As far as I checked wich was 15 minutes of testing this works.

Thu Mar 31 13:21:58 2005 Guest - Correspondence added

Also, due to certain feilds apearing twice you might want to cancel repeating. Add this under 'sub fill' $self->{no_repeat} = $option{no_repeat}; and is '_sub_get_param' replace return undef if $self->{ignore_fields}{$param} with $self->{repeatcount}{$param}++; return undef if $self->{ignore_fields}{$param} or ($self->{no_repeat} == 1 and $self->{repeatcount}{$param} > 0); so by adding a no_repeat => 1 in your call you can turn of repeating. I what have made something like ignore_fields thing for repeats as well and a special no repeat that will repeat on similar fields only. but I don't have the tiem for that, maybe the author of this module may plan on adding it.

Thu Mar 31 15:14:56 2005 Guest - Correspondence added

Again a mistake on the repeating though, so ignore that and here is the right way Add this under 'sub fill' after the my headers $self->{no_repeat} = $option{no_repeat}; and is '_sub_get_param' replace return undef if $self->{ignore_fields}{$param} with return undef if $self->{ignore_fields}{$param} or ($self->{no_repeat} == 1 and $self->{repeatcount}{$param} > 1); Add this under 'sub start' after the my headers $self->{repeatcount}{$attr->{'name'}}++ if ref($self->{fdat}{$attr-> {'name'}}) ne 'ARRAY'; Add this under 'sub start' after "} elsif (lc $attr->{'type'} eq 'radio'){" $self->{repeatcount}{$attr->{'name'}}--; the reason is cause radio boxes and other stuff.

Thu Mar 31 15:17:39 2005 Guest - Correspondence added

the above no repeat does may still repeat array references so you mgith nead to add the $# of the array to the 1. make sure you use the cahced version or the array size wil ldecrease and wont work.

Mon Aug 08 23:33:13 2005 Guest - Correspondence added

okay since the update of HTML Parser, my patch seems to have crashed....so $self->{repeatcount}{$attr->{'name'}}++ if (ref($self->{fdat}{$attr-> {'name'}}) ne 'ARRAY'); Needs to be changed to if ($tagname eq 'input' or $tagname eq 'radio' or $tagname eq 'checkbox' or $tagname eq 'select') { $self->{repeatcount}{$attr->{'name'}}++ if (ref($self->{fdat}{$attr-> {'name'}}) ne 'ARRAY'); } or you can make it if ($tagname=~m/^(?:input|radio|checkbox|select)$/) { $self->{repeatcount}{$attr->{'name'}}++ if (ref($self->{fdat}{$attr-> {'name'}}) ne 'ARRAY'); } depending the way you like ;)

Thu Oct 13 16:28:01 2005 TJMATHER [...] cpan.org - Correspondence added

I'm not sure I understand, why would you have two different types of fields with the same name? Why not just rewrite the HTML code to: <select name="test1"> <option>123</option> <option>456</option> </select> <input type="text" name="test2"> To support having two different fields with the same name seems like a lot of extra complication.

Wed Nov 16 01:33:25 2005 Guest - Correspondence added

It is often the case that arrays are needed. even cgi.pm comes with ARRAY capability. Checkboxes also count as an array. so if you have more then one selected. you can't fill them in now can you? What do you like? <input type="text" name="like" value="cats"> Cats <input type="text" name="like" value="dogs"> Dogs <input type="text" name="like" value="birds"> Birds <input type="text" name="like" value="dragons"> Dragons Are you saying you want me to give each checkbox its own name? that can be rather cynical. also for multiple select box will work as well. [TJMATHER - Thu Oct 13 16:28:01 2005]: Show quoted text

> I'm not sure I understand, why would you have two different types of > fields with the same name? Why not just rewrite the HTML code to: > > <select name="test1"> > <option>123</option> > <option>456</option> > </select> > > <input type="text" name="test2"> > > To support having two different fields with the same name seems like a > lot of extra complication.

Wed Nov 16 01:41:13 2005 Guest - Correspondence added

As for different fields, well its because lets say "Security Question". In it you have a drop down for questiosn and texfield for answer. This requires differnet types and you may want to group it. [TJMATHER - Thu Oct 13 16:28:01 2005]: Show quoted text

> I'm not sure I understand, why would you have two different types of > fields with the same name? Why not just rewrite the HTML code to: > > <select name="test1"> > <option>123</option> > <option>456</option> > </select> > > <input type="text" name="test2"> > > To support having two different fields with the same name seems like a > lot of extra complication.

Fri Oct 02 22:26:18 2009 MARKSTOS [...] cpan.org - Told changed from Not set to Fri Oct 02 22:26:17 2009