Skip Menu |

This queue is for tickets about the Test-Kwalitee CPAN distribution.

Report information
The Basics
Id: 120554
Status: resolved
Priority: 0/
Queue: Test-Kwalitee
People
Owner: ether [...] cpan.org
Requestors: haarg [...] haarg.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.26

History Show all quoted text
  Wed Mar 08 06:11:34 2017 haarg [...] haarg.org - Ticket created
Subject: Misfiring AUTHOR_TESTING/RELEASE_TESTING warning in xt tests
If you run these tests without AUTHOR_TESTING or RELEASE_TESTING set, they will issue a warning "These tests should not be running unless AUTHOR_TESTING=1 and/or RELEASE_TESTING=1!". There is also code to skip the warning for xt tests, but it doesn't work correctly. It checks ((caller)[0]->isa(__PACKAGE__) and (caller(1))[1] =~ m{^\./xt}). A better regex would be m{^(?:\.[/\\])?xt\b}. Also, this only work if called through the import method. If an xt test calls kwalitee_ok directly, it will always warn.
  Mon Apr 17 15:13:34 2017 ether [...] cpan.org - Taken
  Thu May 11 08:05:15 2017 ether [...] cpan.org - Correspondence added
On 2017-03-08 03:11:34, haarg wrote: Show quoted text
> If you run these tests without AUTHOR_TESTING or RELEASE_TESTING set, > they will issue a warning "These tests should not be running unless > AUTHOR_TESTING=1 and/or RELEASE_TESTING=1!". There is also code to > skip the warning for xt tests, but it doesn't work correctly. > > It checks ((caller)[0]->isa(__PACKAGE__) and (caller(1))[1] =~ > m{^\./xt}). A better regex would be m{^(?:\.[/\\])?xt\b}. Also, this > only work if called through the import method. If an xt test calls > kwalitee_ok directly, it will always warn.
thanks, this is improved in 1.26
  Thu May 11 08:05:16 2017 The RT System itself - Status changed from 'new' to 'open'
  Thu May 11 08:05:26 2017 ether [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri May 12 06:42:32 2017 ether [...] cpan.org - Fixed in 1.26 added