Skip Menu |

This queue is for tickets about the CGI-Uploader CPAN distribution.

Report information
The Basics
Id: 12051
Status: resolved
Priority: 0/
Queue: CGI-Uploader

People
Owner: MARKSTOS [...] cpan.org
Requestors: william [...] knowmad.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.00
Fixed in: (no value)



Subject: Cross-site scripting bug in FriendsPhotos.pm
The FriendsPhotos.pm example application has a XSS bug due to passing the msg through the uri. This was discussed recently on the CGI::App list and one possible solution would be to use a code that selects the message to be displayed rather than displaying raw input from the url. Be safe, William
Date: Tue, 29 Mar 2005 09:31:54 -0500
From: Mark Stosberg <mark [...] summersault.com>
To: Guest via RT <bug-CGI-Uploader [...] rt.cpan.org>
Subject: Re: [cpan #12051] Cross-site scripting bug in FriendsPhotos.pm
RT-Send-Cc:
On Tue, Mar 29, 2005 at 08:38:29AM -0500, Guest via RT wrote: Show quoted text
> > The FriendsPhotos.pm example application has a XSS bug due to passing > the msg through the uri. This was discussed recently on the CGI::App > list and one possible solution would be to use a code that selects the > message to be displayed rather than displaying raw input from the url.
Thanks for the note, William. Would I be correct that there are two levels of solution here: 1. Simply escapeHTML() the msg when it comes in. It's possible someone could still adjust the page to look silly, but can't really alter the HTML or JavaScript in the page. If I don't care if the page can be made to look silly, this is enough. 2. Use the solution you recommend: Pass codes which can't be usefully altered. Mark