Skip Menu |

This queue is for tickets about the Net-Async-WebSocket CPAN distribution.

Report information
The Basics
Id: 120504
Status: open
Priority: 0/
Queue: Net-Async-WebSocket
People
Owner: Nobody in particular
Requestors: chohag [...] jtan.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sat Mar 04 15:06:52 2017 chohag [...] jtan.com - Ticket created
Subject: [Wishlist [but easy]] Handshake result in on_client callback
Date: Sat, 04 Mar 2017 21:58:32 +0200
To: bug-Net-Async-WebSocket [...] rt.cpan.org
From: chohag [...] jtan.com
It would be nice to pass information from the http/websockets handshake which can deal with session handling, AAA, etc, to the on_client callback. This can be achieved easlily by including @_ in the invoke_event/on_client call in on_accept (line 97). The handshake result can still be a boolean and ignored, or as it's now passed to the on_client event it can be associated with whatever the user wishes. An alternative would be to store it somehow in the object created for the client session but I couldn't find a way to do that which fits well in my app, and this seemed a straightforward and sane workaround. Matthew
  Fri Dec 08 20:28:05 2017 leonerd-cpan [...] leonerd.org.uk - Correspondence added
On Sat Mar 04 15:06:52 2017, chohag@jtan.com wrote: Show quoted text
> It would be nice to pass information from the http/websockets > handshake which can deal with session handling, AAA, etc, to the > on_client callback. This can be achieved easlily by including @_ > in the invoke_event/on_client call in on_accept (line 97).
Server has had the 'on_handshake' event since 0.06 https://metacpan.org/pod/Net::Async::WebSocket::Server#on_handshake Will this be sufficient? -- Paul Evans
  Fri Dec 08 20:28:06 2017 The RT System itself - Status changed from 'new' to 'open'