Bug #120403 for Net-SSLeay: Makefile.PL broken without "." in @INC

Mon Feb 27 00:57:31 2017 KENTNL [...] cpan.org - Ticket created

Subject:

Makefile.PL broken without "." in @INC

With Perl 5.25.10 and -Ddefault_inc_excludes_dot , Makefile.PL fails for everyone who hasn't preinstalled Module::Install

Configuring Net-SSLeay-1.80 ... Can't locate inc/Module/Install.pm in @INC (you may need to install the inc::Module::Install module) (@INC contains: ext /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/site_perl/5.25.10/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/site_perl/5.25.10 /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/5.25.10/x86_64-linux /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/5.25.10) at Makefile.PL line 6.
BEGIN failed--compilation aborted at Makefile.PL line 6.
Configuring Net-SSLeay failed.

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Wed Mar 01 20:56:53 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120403] Makefile.PL broken without "." in @INC
Date:	Thu, 02 Mar 2017 11:34:40 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi, thanks for reporting this. SVN 489 should fix this. Perhaps you an test? Cheers. On Monday, 27 February 2017 12:57:33 AM AEST you wrote: Show quoted text

> Mon Feb 27 00:57:31 2017: Request 120403 was acted upon. > Transaction: Ticket created by KENTNL > Queue: Net-SSLeay > Subject: Makefile.PL broken without "." in @INC > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: KENTNL@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120403 > > > > With Perl 5.25.10 and -Ddefault_inc_excludes_dot , Makefile.PL fails for > everyone who hasn't preinstalled Module::Install > > Configuring Net-SSLeay-1.80 ... Can't locate inc/Module/Install.pm in @INC > (you may need to install the inc::Module::Install module) (@INC contains: > ext > /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/site_per > l/5.25.10/x86_64-linux > /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/site_per > l/5.25.10 > /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/5.25.10/ > x86_64-linux > /home/kent/perl5/perlbrew/perls/5.25.10-nossp-sdbm-nopmc-nodot/lib/5.25.10) > at Makefile.PL line 6. > BEGIN failed--compilation aborted at Makefile.PL line 6. > Configuring Net-SSLeay failed. > > -- > - CPAN kentnl@cpan.org > - Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Wed Mar 01 20:56:55 2017 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 23 04:57:20 2017 PLICEASE [...] cpan.org - Cc PLICEASE added

Thu Mar 23 05:00:00 2017 PLICEASE [...] cpan.org - Correspondence added

What is in viewvc looks like it should work. I wasn't able to checkout of subversion to test: % svn co https://anonscm.debian.org/viewvc/net-ssleay/trunk/ Net-SSLeay Redirecting to URL 'https://anonscm.debian.org/viewvc/net-ssleay/trunk': Redirecting to URL 'https://anonscm.debian.org/viewvc/net-ssleay/trunk': svn: E195019: Redirect cycle detected for URL 'https://anonscm.debian.org/viewvc/net-ssleay/trunk' may be user error, I haven't used subversion in a long time. Perl 5.25.11 does not have . in @INC by default, so install is broken with the default configuration.

Mon Mar 27 04:47:23 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120403] Makefile.PL broken without "." in @INC
Date:	Mon, 27 Mar 2017 18:26:46 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi, this works for me: svn co svn://svn.debian.org/svn/net-ssleay Cheers. On Thursday, 23 March 2017 5:00:02 AM AEST you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120403 > > > What is in viewvc looks like it should work. I wasn't able to checkout of > subversion to test: > > % svn co https://anonscm.debian.org/viewvc/net-ssleay/trunk/ Net-SSLeay > Redirecting to URL 'https://anonscm.debian.org/viewvc/net-ssleay/trunk': > Redirecting to URL 'https://anonscm.debian.org/viewvc/net-ssleay/trunk': > svn: E195019: Redirect cycle detected for URL > 'https://anonscm.debian.org/viewvc/net-ssleay/trunk' > > may be user error, I haven't used subversion in a long time. > > Perl 5.25.11 does not have . in @INC by default, so install is broken with > the default configuration.

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Mon Mar 27 09:58:50 2017 PLICEASE [...] cpan.org - Correspondence added

Thanks, I can confirm that what is in subversion works with 5.25.11, so I think the only thing keeping this from being resolved is doing a release. Adding the subversion URL as well as the web visible URL might be helpful to the dist metadata since it isn't obvious what the subversion URL should be (at least not to me). I am not sure how to do that via Module::Install, but this is how I do it in MakeMaker: https://metacpan.org/source/PLICEASE/PkgConfig-0.16026/Makefile.PL#L86 Graham

Mon Mar 27 17:02:45 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120403] Makefile.PL broken without "." in @INC
Date:	Tue, 28 Mar 2017 07:02:19 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi, OK, version 1.81 has been sent to CPAN. The setting of repository in Makefile.PL is as per instructions for Module::Install. Cheers. On Monday, 27 March 2017 9:58:52 AM AEST you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120403 > > > Thanks, > > I can confirm that what is in subversion works with 5.25.11, so I think the > only thing keeping this from being resolved is doing a release. > > Adding the subversion URL as well as the web visible URL might be helpful to > the dist metadata since it isn't obvious what the subversion URL should be > (at least not to me). I am not sure how to do that via Module::Install, > but this is how I do it in MakeMaker: > > https://metacpan.org/source/PLICEASE/PkgConfig-0.16026/Makefile.PL#L86 > > Graham

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Sat Apr 01 18:36:14 2017 KENTNL [...] cpan.org - Correspondence added

Makefile.PL now passes.

However, this exposes that the tests are also subject to failures. ( Though you need to export PERL_USE_UNSAFE_INC=0 explicitly in your environment to counteract TAP::Harness adding them for you via make/prove )

Starts up with :

t/local/07_sslecho.t ................... ok
do "t/data/cert_paypal.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/cert_twitter.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_extended.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_simple.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_strange.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.
do "t/data/testcert_cdp.crt.pem_dump" failed, '.' is no longer in @INC at t/local/32_x509_get_cert_info.t line 23.

#   Failed test 'X509_NAME_entry_count   cert_twitter.crt.pem'
#   at t/local/32_x509_get_cert_info.t line 50.
#          got: '12'
#     expected: undef

with a final run of

t/local/32_x509_get_cert_info.t      (Wstat: 512 Tests: 190 Failed: 95)
Failed tests: 7, 13-15, 19-21, 25-27, 31-33, 37-39, 43-45
                49-51, 55-57, 61-63, 67-69, 73-75, 79-81
                83-85, 89-91, 95-97, 101-103, 107-109, 113-120
                124-129, 131-134, 138-139, 143-144, 148-149
                153-154, 158-159, 163-164, 168-169, 173-174
                178-179, 183-187, 189-190
Non-zero exit status: 2
Parse errors: Bad plan. You planned 1243 tests but ran 190.

Would you prefer a dedicated bug for this ?

--
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Sun Apr 02 01:43:05 2017 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #120403] Makefile.PL broken without "." in @INC
Date:	Sun, 2 Apr 2017 06:22:02 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

A new bug report would be best but I am travelling at the moment and realistically won't get to it for 2 months. Maybe you should tackle it yourself and send patch? Cheers Sent from my iPhone Show quoted text

> On 1 Apr 2017, at 11:36 pm, Kent Fredric via RT <bug-Net-SSLeay@rt.cpan.org> wrote: > > Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=120403 > > > Makefile.PL now passes. > > However, this exposes that the tests are also subject to failures. ( Though you > need to export PERL_USE_UNSAFE_INC=0 explicitly in your environment to > counteract TAP::Harness adding them for you via make/prove ) > > Starts up with : > > t/local/07_sslecho.t ................... ok > do "t/data/cert_paypal.crt.pem_dump" failed, '.' is no longer in @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/cert_twitter.crt.pem_dump" failed, '.' is no longer in @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_extended.crt.pem_dump" failed, '.' is no longer in @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_simple.crt.pem_dump" failed, '.' is no longer in @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_strange.crt.pem_dump" failed, '.' is no longer in @INC at > t/local/32_x509_get_cert_info.t line 23. > do "t/data/testcert_cdp.crt.pem_dump" failed, '.' is no longer in @INC at > t/local/32_x509_get_cert_info.t line 23. > > # Failed test 'X509_NAME_entry_count cert_twitter.crt.pem' > # at t/local/32_x509_get_cert_info.t line 50. > # got: '12' > # expected: undef > > > with a final run of > > > t/local/32_x509_get_cert_info.t (Wstat: 512 Tests: 190 Failed: 95) > Failed tests: 7, 13-15, 19-21, 25-27, 31-33, 37-39, 43-45 > 49-51, 55-57, 61-63, 67-69, 73-75, 79-81 > 83-85, 89-91, 95-97, 101-103, 107-109, 113-120 > 124-129, 131-134, 138-139, 143-144, 148-149 > 153-154, 158-159, 163-164, 168-169, 173-174 > 178-179, 183-187, 189-190 > Non-zero exit status: 2 > Parse errors: Bad plan. You planned 1243 tests but ran 190. > > Would you prefer a dedicated bug for this ? > > -- > - CPAN kentnl@cpan.org > - Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )

Wed Jul 25 08:39:56 2018 chrisn [...] cpan.org - Correspondence added

The problems in Makefile.PL were resolved with the release of 1.81 - in 1.86_03 we changed the build system so it no longer uses Module::Install, but I've just tested Makefile.PL on Perl 5.28 with default_inc_excludes_dot=define and PERL_USE_UNSAFE_INC=0 and compilation still succeeds, so there hasn't been a regression. RT#120839 is being used to track the test failures, so I'll mark this as resolved.

Wed Jul 25 08:39:59 2018 chrisn [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Jul 25 08:39:59 2018 chrisn [...] cpan.org - Given to MIKEM

Wed Jul 25 08:40:00 2018 chrisn [...] cpan.org - Fixed in 1.81 added