| Subject: | bug report/patch (v3.5.3) |
| Date: | Fri, 24 Feb 2017 15:18:38 -0800 |
| To: | bug-DBD-Pg [...] rt.cpan.org |
| From: | Alice Maz <alice [...] alicemaz.com> |
hi! small bug report/patch for v3.5.3. mapping SQL_NUMERIC to PG_FLOAT8
causes prepared statements with numeric-typed parameters to miss
indexes. I've changed this to map to PG_NUMERIC in the perl portion of
types.c instead, which solves the problem. diff pasted below with the
relevant change, before regenerating the file.
emailed as per the CPAN RT page, but if you'd prefer I open a ticket,
I'd be more than happy. thanks!
diff --git a/types.c b/types.c
index 7d49a91..12b0661 100644
--- a/types.c
+++ b/types.c
@@ -761,8 +761,8 @@ int2 quote_int null_dequote
SQL_SMALLINT|SQL_TINYINT 1 1
int4 quote_int null_dequote SQL_INTEGER 1 1
int8 quote_int null_dequote SQL_BIGINT 1 0
float4 quote_float null_dequote 0 1 2
-float8 quote_float null_dequote
SQL_FLOAT|SQL_DOUBLE|SQL_NUMERIC|SQL_REAL 1 2
-numeric quote_float null_dequote SQL_DECIMAL 1 2
+float8 quote_float null_dequote SQL_FLOAT|SQL_DOUBLE|SQL_REAL 1
2
+numeric quote_float null_dequote SQL_NUMERIC|SQL_DECIMAL 1 2
oid quote_int null_dequote 0 0 1
name quote_name null_dequote SQL_VARCHAR 0 0
## XXX Wrong
-Alice