Skip Menu |

This queue is for tickets about the PDF-Reuse CPAN distribution.

Report information
The Basics
Id: 120346
Status: patched
Priority: 0/
Queue: PDF-Reuse
People
Owner: cnighs [...] cpan.org
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Feb 24 00:31:14 2017 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Ticket created
Subject: Parsing of refs is too strict
Just FYI, the PDF specification allows any amount of whitespace between the tokens in ‘Root 1 0 R’ etc. I see code like this in your module: m'\/Root\s+(\d+)\s{1,2}\d+\s{1,2}R'so which only allows up to two whitespace characters. (Also, \0 is considered whitespace in PDF syntax, but PDF::Reuse won’t recognise it as such.)
  Sun Feb 26 18:18:49 2017 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Fri Feb 24 00:31:14 2017, SPROUT wrote: Show quoted text
> Just FYI, the PDF specification allows any amount of whitespace > between the tokens in ‘Root 1 0 R’ etc. I see code like this in your > module: > > m'\/Root\s+(\d+)\s{1,2}\d+\s{1,2}R'so > > which only allows up to two whitespace characters. (Also, \0 is > considered whitespace in PDF syntax, but PDF::Reuse won’t recognise it > as such.)
Also, comments are allowed between the tokens. This is valid: 1 % eieio 0 R
  Sun Feb 26 18:18:50 2017 The RT System itself - Status changed from 'new' to 'open'
  Mon Feb 27 09:08:48 2017 cnighs [...] cpan.org - Correspondence added
Thanks for taking time to open a bug! Any suggestions on a modified regexp that will work better? Chris
  Mon Feb 27 09:08:49 2017 cnighs [...] cpan.org - Taken
  Mon Feb 27 22:57:26 2017 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Mon Feb 27 09:08:48 2017, CNIGHS wrote: Show quoted text
> Thanks for taking time to open a bug! > > Any suggestions on a modified regexp that will work better?
This will match a single whitespace character or comment: $ws = '(?:[ \0\n\r\t\f]|%[^\r\n]*[\r\n])'; Then /...$ws*.../ will match optional whitespace, and /...$ws+.../ will match mandatory whitespace.
  Fri Jan 25 09:30:35 2019 cnighs [...] cpan.org - Correspondence added
On Mon Feb 27 22:57:26 2017, SPROUT wrote: Show quoted text
> On Mon Feb 27 09:08:48 2017, CNIGHS wrote:
> > Thanks for taking time to open a bug! > > > > Any suggestions on a modified regexp that will work better?
> > This will match a single whitespace character or comment: > > $ws = '(?:[ \0\n\r\t\f]|%[^\r\n]*[\r\n])'; > > Then /...$ws*.../ will match optional whitespace, and /...$ws+.../ > will match mandatory whitespace.
I've pushed your patch to the 0.40 branch. Please test and see if this addresses the issue. https://github.com/cnighswonger/PDF-Reuse/tree/ver_0.40 Thanks! Chris
  Fri Jan 25 09:30:36 2019 cnighs [...] cpan.org - Status changed from 'open' to 'patched'