Bug #120339 for Git-Repo-Commits: t/perlcritic.t may fail (0.0.3, 0.0.4)

Thu Feb 23 03:01:36 2017 SREZIC [...] cpan.org - Ticket created

Subject:

t/perlcritic.t may fail (0.0.3, 0.0.4)

Depending on what critic modules are installed the test may fail. On one of my smoker machines: ... # Failed test 'Test::Perl::Critic for "blib/lib/Git/Repo/Commits.pm"' # at /usr/perl5.16.3t/lib/site_perl/5.16.3/Test/Perl/Critic.pm line 104. # # Variable, subroutine, and package names have to be in CamelCase at line 19, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 20, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 21, column 7. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 21, column 23. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 22, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 22, column 44. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 23, column 6. (no explanation). (Severity: 5) ... # Variable, subroutine, and package names have to be in CamelCase at line 48, column 6. (no explanation). (Severity: 5) # Variable, subroutine, and package names have to be in CamelCase at line 49, column 10. (no explanation). (Severity: 5) t/perlcritic.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests ...

Thu Feb 23 03:25:31 2017 jjmerelo [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #120339] t/perlcritic.t may fail (0.0.3, 0.0.4)
Date:	Thu, 23 Feb 2017 09:25:00 +0100
To:	bug-Git-Repo-Commits [...] rt.cpan.org
From:	JJ Merelo <jjmerelo [...] gmail.com>

Thanks for the report. I'll check it out.

Thu Feb 23 03:25:31 2017 The RT System itself - Status changed from 'new' to 'open'

Thu Feb 23 14:05:40 2017 ether [...] cpan.org - Correspondence added

On 2017-02-23 00:01:36, SREZIC wrote: Show quoted text

> Depending on what critic modules are installed the test may fail. On > one of my smoker machines:

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Thu Feb 23 14:07:00 2017 JMERELO [...] cpan.org - Correspondence added 30 min

On Thu Feb 23 14:05:40 2017, ETHER wrote: Show quoted text

> On 2017-02-23 00:01:36, SREZIC wrote:

> > Depending on what critic modules are installed the test may fail. On > > one of my smoker machines:

> > While this test failure is indeed an issue that should be corrected, > please don't allow pod, critic, coverage or kwalitee tests to run for > normal user installs, as they make the installation fail unnecessarily > when newer versions of the tester module introduces errors that you > cannot anticipate. Also spelling tests are dependent on what > dictionaries are installed locally, and critic tests use all plugins > that are installed, neither of which can be predicted in advance. > > Either move these tests to xt/, or guard them with: > > plan skip_all => "These tests are for authors only!" unless > $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

That's what I have done for the updated version. Thanks for the report.

Thu Feb 23 14:07:00 2017 JMERELO [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Feb 23 14:07:10 2017 JMERELO [...] cpan.org - Taken