| Subject: | inflateUndermine: subvert arg conditionally used/unused |
Sorry, it seems that this spot has been patched several times, due to fighting requirements.
In 2.069 the line with
state->sane = !subvert;
was unused just below the #ifdef line due to https://rt.cpan.org/Public/Bug/Display.html?id=105414 because if both that line and the later
state->sane = 1;
are to be executed, the !subvert line has no effect and is redundant.
In 2.070 the line was moved back above the #ifdef, due to https://rt.cpan.org/Public/Bug/Display.html?id=107642 because compilers were warning about the unused subvert argument. This undid the change in 2.069.
(In 2.071 there was no change to this spot.)
My suggested patch (attached) moves the !subvert line back inside the #ifdef, but adds (void)subvert; (the usual way to deal with unused args) to the #else branch.
| Subject: | zlib.pat |
Message body not shown because it is not plain text.