Show quoted text
Do lot's of tiny patches create an impressive result.
No worries :)
Please also try some combinations (ON foo AND bar OR baz) and stacks (foo AND bar OR fom AND baz)
Show quoted text> I will create some test cases and submit an updated patch
You can also submit pull-requests on Github which will lead to Travis will run all tests against your patches.
Cheers,
Jens
Show quoted text> On Feb 9, 2017 16:21, "Jens Rehsack via RT" <bug-SQL-Statement@rt.cpan.org>
> wrote:
>
>> <URL:
https://rt.cpan.org/Ticket/Display.html?id=120163 >
>>
>>
>>> Am 09.02.2017 um 23:06 schrieb jleu@mindspring.com via RT <
>> bug-SQL-Statement@rt.cpan.org>:
>>>
>>> Thu Feb 09 17:06:33 2017: Request 120163 was acted upon.
>>> Transaction: Ticket created by jleu@mindspring.com
>>> Queue: SQL-Statement
>>> Subject: Support OR in JOIN clause - patch
>>> Broken in: 1.410
>>> Severity: Wishlist
>>> Owner: Nobody
>>> Requestors: jleu@mindspring.com
>>> Status: new
>>> Ticket <URL:
https://rt.cpan.org/Ticket/Display.html?id=120163 >
>>>
>>>
>>> I'm including a patch that has two changes:
>>> - Add support for LIMIT d OFFSET d
>>> - Add support for OR in JOIN clause
>>> - this required addition of < > to term split
>>> - required stripping of ()'s from ids
>>>
>>> Please email me with any questions
>>> <diff>
>>
>> I didn't review the patch at all, but I miss definitively some tests
>> proving that it works and ensure future patches don't add new regressions.
>> Would you please so kind and add some?
>>
>> I expect that no of existing tests fail with that patch. I will surely
>> prove, but for now - expecting everything is fine :)
>>
>> Cheers
>> --
>> Jens Rehsack - rehsack@gmail.com
>>
>>
>>
--
Jens Rehsack - rehsack@gmail.com
RT for rt.cpan.org