Bug #120079 for String-CamelCase: perl Makefile.PL broken when . not in @INC

Fri Feb 03 00:52:39 2017 TODDR [...] cpan.org - Ticket created

Subject:

perl Makefile.PL broken when . in @INC

Your Makefile.PL will not run unless . is in @INC. As a result of CVE-2016-1238, In 5.26 it will be a build option to make a perl without . in @INC. This requires the script writer to be explicit if they want to load modules from relative paths. For more info you can also see https://rt.perl.org/Ticket/Display.html?id=130467 and https://rt.perl.org/Ticket/Display.html?id=127810 for core perl discussions. My doc is here http://blogs.perl.org/users/todd_rinaldo/2016/11/how-removing-from-inc-is-about-to-break-cpan.html

Fri Feb 03 00:55:08 2017 TODDR [...] cpan.org - Correspondence added

You can fix this by inserting . in @INC prior to the module load in question. Patch attached.

Subject:

String-CamelCase.patch

diff --git a/Makefile.PL b/Makefile.PL index 19d495e..ac78b9a 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,6 +1,8 @@ use strict; use warnings; use ExtUtils::MakeMaker; + +BEGIN { pop @INC, "." } use inc::ExtUtils::MY_Metafile qw(my_metafile); my_metafile {

Fri Feb 03 01:25:56 2017 TODDR [...] cpan.org - Correspondence added

oops! push not pop

Subject:

String-CamelCase.patch

diff --git a/Makefile.PL b/Makefile.PL index 19d495e..ac78b9a 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,6 +1,8 @@ use strict; use warnings; use ExtUtils::MakeMaker; + +BEGIN { push @INC, "." } use inc::ExtUtils::MY_Metafile qw(my_metafile); my_metafile {

Fri Feb 03 13:10:02 2017 ether [...] cpan.org - Subject changed from 'perl Makefile.PL broken when . in @INC' to 'perl Makefile.PL broken when . not in @INC'

Sun Apr 02 14:55:46 2017 jkeenan [...] cpan.org - Correspondence added

On Fri Feb 03 01:25:56 2017, TODDR wrote: Show quoted text

> oops! push not pop >

HIO, This library is a prerequisite for other CPAN distributions such as DBIx-Class-Schema-Loader. Those other distributions will not work with perl-5.26.0 unless this distribution works with that upcoming release. So if you could review the patch, apply as needed and generate a new CPAN release, that would be great! Thank you very much. Jim Keenan

Sun Apr 02 14:55:47 2017 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 16 12:14:42 2018 SUNGO [...] cpan.org - Correspondence added

Looks like this got fixed in Sept 2017 as part of 0.03. https://metacpan.org/changes/distribution/String-CamelCase

Tue Jan 16 12:27:54 2018 TODDR [...] cpan.org - Correspondence added

On Tue Jan 16 12:14:42 2018, SUNGO wrote: Show quoted text

> Looks like this got fixed in Sept 2017 as part of 0.03. > https://metacpan.org/changes/distribution/String-CamelCase

Yep. https://metacpan.org/source/HIO/String-CamelCase-0.03/Makefile.PL#L5

Tue Jan 16 12:27:54 2018 TODDR [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jan 16 12:27:55 2018 TODDR [...] cpan.org - Fixed in 0.03 added