Skip Menu |

This queue is for tickets about the PAR-Packer CPAN distribution.

Report information
The Basics
Id: 120041
Status: resolved
Priority: 0/
Queue: PAR-Packer

People
Owner: RSCHUPP [...] cpan.org
Requestors: Ralf.Neubauer [...] wido.bv.aok.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.031_01



Subject: --exclude gets confused by missing modules
Date: Mon, 30 Jan 2017 14:22:29 +0000
To: "bug-PAR-Packer [...] rt.cpan.org" <bug-PAR-Packer [...] rt.cpan.org>
From: "Neubauer, Ralf" <ralf.neubauer [...] wido.bv.aok.de>
Hi, C:\Users\NEU\Desktop>copy con simple.pl exit 0; ^Z 1 Datei(en) kopiert. C:\Users\NEU\Desktop>pp simple.pl C:\Users\NEU\Desktop>pp simple.pl --exclude DBD::Pg C:\Users\NEU\Desktop>pp simple.pl --exclude DBD::PgPP Odd number of elements in hash assignment at c:/strawberry-5.24.0.1-64/perl/site/lib/PAR/Packer.pm line 729. Odd number of elements in hash assignment at c:/strawberry-5.24.0.1-64/perl/site/lib/PAR/Packer.pm line 783. C:\Users\NEU\Desktop>pp simple.pl --exclude DBD::PgPP --exclude Made::Up C:\Users\NEU\Desktop> Line 729: my %skip = map { Module::ScanDeps::_find_in_inc($_), 1 } @exclude; Line 783: %skip = map { Module::ScanDeps::_find_in_inc($_), 1 } @exclude; It should be allowed to --exclude packages that are not installed. It is useful to be able to write general scripts that don't include a module, regardless if it is installed or not. At least it shouldn't deactivate the other excludes (silently, if the number of uninstalled excludes is even). Ralf
On 2017-01-30 09:38:26, Ralf.Neubauer@wido.bv.aok.de wrote: Show quoted text
> It should be allowed to --exclude packages that are not installed. It
Agreed :) Show quoted text
> C:\Users\NEU\Desktop>pp simple.pl --exclude DBD::PgPP > Odd number of elements in hash assignment at c:/strawberry-5.24.0.1- > 64/perl/site/lib/PAR/Packer.pm line 729.
This error message puzzled me for a moment, I would have expected "Use of uninitialized value in list assignment" when _find_in_inc can't find anything. But... it's the context, stupid! Anyway, fixed on GitHub, will be in the next release. Cheers, Roderich