Skip Menu |

This queue is for tickets about the Locale-SubCountry CPAN distribution.

Report information
The Basics
Id: 120002
Status: resolved
Priority: 0/
Queue: Locale-SubCountry
People
Owner: Nobody in particular
Requestors: doug [...] theschrags.net
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2.00
Fixed in: 2.02

History Show all quoted text
  Thu Jan 26 14:12:41 2017 https://openid.stackexchange.com/user/3cffd334-9f13-42d9-894d-ec689b4ad3c5 - Ticket created
Subject: Module pollutes main:: namespace
The main module imports several packages (including JSON) outside of any package declaration. This results in any default imports (such as from_json, to_json, ...) being imported into the main:: namespace. It looks like no imports are intended anyway, only ensuring that the modules are loaded. For a minimal fix, the pull request: https://github.com/kimryan/Locale-SubCountry/pull/1 places those use statements in the package namespace for the file. It also prevents JSON from exporting any of its defaults.
  Tue Jan 31 09:26:13 2017 https://openid.stackexchange.com/user/3cffd334-9f13-42d9-894d-ec689b4ad3c5 - Correspondence added
From: dmaestro12
The pull request above has been accepted and merged. Just waiting for a new release ;-)
  Tue Jan 31 09:26:13 2017 The RT System itself - Status changed from 'new' to 'open'
  Thu Mar 09 13:56:34 2017 https://openid.stackexchange.com/user/3cffd334-9f13-42d9-894d-ec689b4ad3c5 - Correspondence added
From: dmaestro12
On Tue Jan 31 09:26:13 2017, https://openid.stackexchange.com/user/3cffd334-9f13-42d9-894d-ec689b4ad3c5 wrote: Show quoted text
> The pull request above has been accepted and merged. Just waiting for > a new release ;-)
Release v2.02 is out and fixes my problem! Thanks.
  Sun Mar 12 21:31:38 2017 kimryan [...] cpan.org - Correspondence added
Added package declaration before external module imports
  Sun Mar 12 21:31:58 2017 kimryan [...] cpan.org - Status changed from 'open' to 'resolved'
  Sun Mar 12 21:31:59 2017 kimryan [...] cpan.org - Fixed in 2.02 added